All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] erofs-utils: mkfs: fix segfault with `--compress-hints`
@ 2026-10-06 22:18 Gao Xiang
  0 siblings, 0 replies; only message in thread
From: Gao Xiang @ 2026-10-06 22:18 UTC (permalink / raw)
  To: linux-erofs; +Cc: Gao Xiang, Jan Čermák

Reported-and-suggested-by: Jan Čermák <sairon@sairon.cz>
Fixes: bb9f75521465 ("erofs-utils: lib: migrate `c_compr_opts`")
Closes: https://github.com/erofs/erofs-utils/issues/56
Signed-off-by: Gao Xiang <xiang@kernel.org>
---
 mkfs/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/main.c b/mkfs/main.c
index f0d3d8c..93123c1 100644
--- a/mkfs/main.c
+++ b/mkfs/main.c
@@ -1886,6 +1886,7 @@ int main(int argc, char **argv)
 		}
 	}
 
+	importer_params.z_paramsets = mkfscfg.zcfgs;
 	err = erofs_load_compress_hints(&importer, &g_sbi);
 	if (err) {
 		erofs_err("failed to load compress hints %s",
@@ -1895,7 +1896,6 @@ int main(int argc, char **argv)
 
 	if (mkfscfg.inlinexattr_tolerance < 0)
 		importer_params.no_xattrs = true;
-	importer_params.z_paramsets = mkfscfg.zcfgs;
 	importer_params.source = cfg.c_src_path;
 	importer_params.no_datainline = mkfs_no_datainline;
 	importer_params.dot_omitted = mkfs_dot_omitted;
-- 
2.50.1 (Apple Git-155)



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-10-06 22:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-06 22:18 [PATCH] erofs-utils: mkfs: fix segfault with `--compress-hints` Gao Xiang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.