* [merged mm-stable] mm-oom_kill-remove-unreachable-__gfp_thisnode-check-in-constrained_alloc.patch removed from -mm tree
@ 2026-10-07 0:50 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-10-07 0:50 UTC (permalink / raw)
To: mm-commits, shakeel.butt, rientjes, mhocko, liuye, akpm
The quilt patch titled
Subject: mm/oom_kill: remove unreachable __GFP_THISNODE check in constrained_alloc()
has been removed from the -mm tree. Its filename was
mm-oom_kill-remove-unreachable-__gfp_thisnode-check-in-constrained_alloc.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Ye Liu <liuye@kylinos.cn>
Subject: mm/oom_kill: remove unreachable __GFP_THISNODE check in constrained_alloc()
Date: Thu, 13 Aug 2026 17:38:09 +0800
The __GFP_THISNODE check in constrained_alloc() is dead code: global OOM
is never triggered with __GFP_THISNODE (blocked in __alloc_pages_may_oom
before out_of_memory() is called), and memcg OOM returns CONSTRAINT_MEMCG
at the top of the function before reaching this point. Remove the check,
its stale comment, and update the following comment that referenced
__GFP_THISNODE.
Link: https://lore.kernel.org/20260813093810.573302-1-ye.liu@linux.dev
Signed-off-by: Ye Liu <liuye@kylinos.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Cc: David Rientjes <rientjes@google.com>
---
mm/oom_kill.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
--- a/mm/oom_kill.c~mm-oom_kill-remove-unreachable-__gfp_thisnode-check-in-constrained_alloc
+++ a/mm/oom_kill.c
@@ -267,18 +267,11 @@ static enum oom_constraint constrained_a
if (!oc->zonelist)
return CONSTRAINT_NONE;
- /*
- * Reach here only when __GFP_NOFAIL is used. So, we should avoid
- * to kill current.We have to random task kill in this case.
- * Hopefully, CONSTRAINT_THISNODE...but no way to handle it, now.
- */
- if (oc->gfp_mask & __GFP_THISNODE)
- return CONSTRAINT_NONE;
/*
- * This is not a __GFP_THISNODE allocation, so a truncated nodemask in
- * the page allocator means a mempolicy is in effect. Cpuset policy
- * is enforced in get_page_from_freelist().
+ * A truncated nodemask in the page allocator means a mempolicy
+ * is in effect. Cpuset policy is enforced in
+ * get_page_from_freelist().
*/
if (oc->nodemask &&
!nodes_subset(node_states[N_MEMORY], *oc->nodemask)) {
_
Patches currently in -mm which might be from liuye@kylinos.cn are
mm-vmalloc-group-xa_init-with-vbq-field-initializations.patch
mm-vmalloc-extract-vmap_insert_free_area-helper.patch
mm-vmalloc-extract-show_busy_info-from-vmalloc_info_show.patch
mm-vmalloc-fix-vmalloc_dump_obj-address-alignment-for-last-page-lookups.patch
mm-vmalloc-fix-vmalloc_dump_obj-cross-zone-va-lookup.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-07 0:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-07 0:50 [merged mm-stable] mm-oom_kill-remove-unreachable-__gfp_thisnode-check-in-constrained_alloc.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.