* + mm-damon-ops-common-fix-age_in_sec-overflow-on-32-bit.patch added to mm-unstable branch
@ 2026-10-07 19:35 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-10-07 19:35 UTC (permalink / raw)
To: mm-commits, sj, jaeyeon.lee.dev, akpm
The patch titled
Subject: mm/damon/ops-common: fix age_in_sec overflow on 32-bit
has been added to the -mm mm-unstable branch. Its filename is
mm-damon-ops-common-fix-age_in_sec-overflow-on-32-bit.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-damon-ops-common-fix-age_in_sec-overflow-on-32-bit.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
Subject: mm/damon/ops-common: fix age_in_sec overflow on 32-bit
Date: Mon, 5 Oct 2026 23:52:05 -0700
Patch series "mm/damon: fix a minor bug, clean code, and add a test".
Patch 1 from Jaeyeon Lee fixes a minor overflow issue in DAMOS. Patch 2
from Gregory Price (Meta) cleans up the code for handling of hugetlb
pages. Patch 3 from Liew Rui Yan adds a kunit test for a recently fixed
bug.
This patch (of 3):
damon_hot_score() calculates the age of a region by multiplying r->age and
the aggregation interval. On 32-bit architectures, unsigned long is 32
bits, so the multiplication overflows once the age exceeds about 4295
seconds. Then old regions are scored as if they were young.
Fix it by doing the calculation in 64-bit arithmetic using div_u64().
Also make age_in_sec u64, so the result is not truncated back to 32 bits.
The issue was discovered [1] by Sashiko.
Link: https://lore.kernel.org/20261006065209.41507-1-sj@kernel.org
Link: https://lore.kernel.org/20261006065209.41507-2-sj@kernel.org
Link: https://lore.kernel.org/20260623011652.1354-1-sj@kernel.org [1]
Fixes: 198f0f4c58b9 ("mm/damon/vaddr,paddr: support pageout prioritization")
Signed-off-by: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
Signed-off-by: SJ Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: SJ Park <sj@kernel.org>
Assisted-by: LLM
---
mm/damon/ops-common.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- a/mm/damon/ops-common.c~mm-damon-ops-common-fix-age_in_sec-overflow-on-32-bit
+++ a/mm/damon/ops-common.c
@@ -164,7 +164,7 @@ int damon_hot_score(struct damon_ctx *c,
struct damos *s)
{
int freq_subscore;
- unsigned int age_in_sec;
+ u64 age_in_sec;
int age_in_log, age_subscore;
unsigned int freq_weight = s->quota.weight_nr_accesses;
unsigned int age_weight = s->quota.weight_age;
@@ -174,7 +174,8 @@ int damon_hot_score(struct damon_ctx *c,
DAMON_MAX_SUBSCORE,
damon_nr_samples_per_aggr(&c->attrs));
- age_in_sec = (unsigned long)r->age * c->attrs.aggr_interval / 1000000;
+ age_in_sec = div_u64((u64)r->age * c->attrs.aggr_interval,
+ USEC_PER_SEC);
if (age_in_sec)
age_in_log = min_t(int, ilog2(age_in_sec) + 1,
DAMON_MAX_AGE_IN_LOG);
_
Patches currently in -mm which might be from jaeyeon.lee.dev@gmail.com are
selftests-mm-skip-khugepaged-file-tests-if-mkfsxfs-is-unavailable.patch
selftests-mm-hugetlb-read-hwpoison-add-setup-of-hugetlb-pages.patch
selftests-mm-hugetlb_madv_vs_map-fix-tap-plan-mismatches.patch
mm-damon-ops-common-fix-age_in_sec-overflow-on-32-bit.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-07 19:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-07 19:35 + mm-damon-ops-common-fix-age_in_sec-overflow-on-32-bit.patch added to mm-unstable branch Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.