From: Conor Dooley <conor@kernel.org>
To: Brian Masney <bmasney@redhat.com>
Cc: Junhui Liu <junhui.liu@pigmoral.tech>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Conor Dooley <conor.dooley@microchip.com>,
Yixun Lan <dlan@kernel.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 2/2] riscv: dts: anlogic: drop unused DR1V90 external clocks
Date: Thu, 8 Oct 2026 15:12:43 +0100 [thread overview]
Message-ID: <20261008-c59c47fb901176a0137497d9@squawk> (raw)
In-Reply-To: <ar_wmUWEXgIzq1XM@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]
On Fri, Oct 02, 2026 at 01:57:45PM -0400, Brian Masney wrote:
> On Fri, Oct 02, 2026 at 05:33:24PM +0100, Conor Dooley wrote:
> > On Sat, Oct 03, 2026 at 12:28:40AM +0800, Junhui Liu wrote:
> > > The external CAN and watchdog clock inputs are not routed on the MLKPAI
> > > FS01, the only board currently supported. Drop the two fixed-clock
> > > placeholders from the common dtsi, as fixed clocks require a valid
> > > clock-frequency property.
> > >
> > > Both clock muxes select their internal parent clocks after reset, so
> > > the CRU operates correctly without the external inputs. Keep only the
> > > required oscillator input to the CRU.
> > >
> > > A board using these external clocks should define them in its own
> > > board-level dts and override the clocks and clock-names properties of
> > > the CRU node.
> > >
> > > Reported-by: Yixun Lan <dlan@kernel.org>
> > > Fixes: 7849521aaac2 ("riscv: dts: anlogic: add clocks and CRU for DR1V90")
> > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
> >
> > Per the v1, Brian said he would rebase the clock tree, so I'll just
> > squash this into the original patch I think.
>
> It's already rebased, and dropped from the clk-next history.
Cool. Note to self: 7,5 material, cos I don't have the headers to do
anything with "riscv: dts: anlogic: add clocks and CRU for DR1V90"
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Brian Masney <bmasney@redhat.com>
Cc: Junhui Liu <junhui.liu@pigmoral.tech>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Conor Dooley <conor.dooley@microchip.com>,
Yixun Lan <dlan@kernel.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 2/2] riscv: dts: anlogic: drop unused DR1V90 external clocks
Date: Thu, 8 Oct 2026 15:12:43 +0100 [thread overview]
Message-ID: <20261008-c59c47fb901176a0137497d9@squawk> (raw)
In-Reply-To: <ar_wmUWEXgIzq1XM@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1519 bytes --]
On Fri, Oct 02, 2026 at 01:57:45PM -0400, Brian Masney wrote:
> On Fri, Oct 02, 2026 at 05:33:24PM +0100, Conor Dooley wrote:
> > On Sat, Oct 03, 2026 at 12:28:40AM +0800, Junhui Liu wrote:
> > > The external CAN and watchdog clock inputs are not routed on the MLKPAI
> > > FS01, the only board currently supported. Drop the two fixed-clock
> > > placeholders from the common dtsi, as fixed clocks require a valid
> > > clock-frequency property.
> > >
> > > Both clock muxes select their internal parent clocks after reset, so
> > > the CRU operates correctly without the external inputs. Keep only the
> > > required oscillator input to the CRU.
> > >
> > > A board using these external clocks should define them in its own
> > > board-level dts and override the clocks and clock-names properties of
> > > the CRU node.
> > >
> > > Reported-by: Yixun Lan <dlan@kernel.org>
> > > Fixes: 7849521aaac2 ("riscv: dts: anlogic: add clocks and CRU for DR1V90")
> > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
> >
> > Per the v1, Brian said he would rebase the clock tree, so I'll just
> > squash this into the original patch I think.
>
> It's already rebased, and dropped from the clk-next history.
Cool. Note to self: 7,5 material, cos I don't have the headers to do
anything with "riscv: dts: anlogic: add clocks and CRU for DR1V90"
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-10-08 14:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 16:28 [PATCH v2 0/2] riscv: dts: anlogic: dr1v90: fix clock dtbs_check errors Junhui Liu
2026-10-02 16:28 ` Junhui Liu
2026-10-02 16:28 ` [PATCH v2 1/2] dt-bindings: clock: anlogic,dr1v90-cru: make external clocks optional Junhui Liu
2026-10-02 16:28 ` Junhui Liu
2026-10-02 16:32 ` Conor Dooley
2026-10-02 16:32 ` Conor Dooley
2026-10-02 16:28 ` [PATCH v2 2/2] riscv: dts: anlogic: drop unused DR1V90 external clocks Junhui Liu
2026-10-02 16:28 ` Junhui Liu
2026-10-02 16:33 ` Conor Dooley
2026-10-02 16:33 ` Conor Dooley
2026-10-02 17:57 ` Brian Masney
2026-10-02 17:57 ` Brian Masney
2026-10-08 14:12 ` Conor Dooley [this message]
2026-10-08 14:12 ` Conor Dooley
2026-10-02 19:10 ` (subset) [PATCH v2 0/2] riscv: dts: anlogic: dr1v90: fix clock dtbs_check errors Brian Masney
2026-10-02 19:10 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008-c59c47fb901176a0137497d9@squawk \
--to=conor@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=bmasney+clk@redhat.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=jbrunet+clk@baylibre.com \
--cc=junhui.liu@pigmoral.tech \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.