* [linux-next:master 13311/15025] drivers/dma/amlogic-dma.c:636 aml_dma_probe() warn: passing zero to 'PTR_ERR'
@ 2026-10-08 7:22 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-10-08 7:22 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
Unfiltered warning: this smatch report is sent as-is and has not been
reviewed for false positives, so please treat it with due skepticism.
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Xianwei Zhao <xianwei.zhao@amlogic.com>
CC: Vinod Koul <vkoul@kernel.org>
CC: Frank Li <Frank.Li@nxp.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: b018686719706a781c45a874ed51374a2dc4b767
commit: b84b5197e344e2d378a9edf5d782b6fbddff8d06 [13311/15025] dmaengine: amlogic: Add general DMA driver for A9
:::::: branch date: 18 hours ago
:::::: commit date: 3 days ago
config: openrisc-randconfig-r2202-20261008 (https://download.01.org/0day-ci/archive/20261008/202610080953.C5TYlCaA-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 15.2.0
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202610080953.C5TYlCaA-lkp@intel.com/
smatch warnings:
drivers/dma/amlogic-dma.c:636 aml_dma_probe() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +636 drivers/dma/amlogic-dma.c
b84b5197e344e2 Xianwei Zhao 2026-09-03 596
b84b5197e344e2 Xianwei Zhao 2026-09-03 597 static int aml_dma_probe(struct platform_device *pdev)
b84b5197e344e2 Xianwei Zhao 2026-09-03 598 {
b84b5197e344e2 Xianwei Zhao 2026-09-03 599 struct device_node *np = pdev->dev.of_node;
b84b5197e344e2 Xianwei Zhao 2026-09-03 600 struct dma_device *dma_dev;
b84b5197e344e2 Xianwei Zhao 2026-09-03 601 struct aml_dma_dev *aml_dma;
b84b5197e344e2 Xianwei Zhao 2026-09-03 602 int ret, i, len;
b84b5197e344e2 Xianwei Zhao 2026-09-03 603 u32 chan_nr;
b84b5197e344e2 Xianwei Zhao 2026-09-03 604
b84b5197e344e2 Xianwei Zhao 2026-09-03 605 const struct regmap_config aml_regmap_config = {
b84b5197e344e2 Xianwei Zhao 2026-09-03 606 .reg_bits = 32,
b84b5197e344e2 Xianwei Zhao 2026-09-03 607 .val_bits = 32,
b84b5197e344e2 Xianwei Zhao 2026-09-03 608 .reg_stride = 4,
b84b5197e344e2 Xianwei Zhao 2026-09-03 609 .max_register = 0x3000,
b84b5197e344e2 Xianwei Zhao 2026-09-03 610 };
b84b5197e344e2 Xianwei Zhao 2026-09-03 611
b84b5197e344e2 Xianwei Zhao 2026-09-03 612 ret = of_property_read_u32(np, "dma-channels", &chan_nr);
b84b5197e344e2 Xianwei Zhao 2026-09-03 613 if (ret)
b84b5197e344e2 Xianwei Zhao 2026-09-03 614 return dev_err_probe(&pdev->dev, ret, "failed to read dma-channels\n");
b84b5197e344e2 Xianwei Zhao 2026-09-03 615 if (chan_nr > (MAX_CHAN_ID * 2))
b84b5197e344e2 Xianwei Zhao 2026-09-03 616 return dev_err_probe(&pdev->dev, -EINVAL, "dma-channels unusual\n");
b84b5197e344e2 Xianwei Zhao 2026-09-03 617
b84b5197e344e2 Xianwei Zhao 2026-09-03 618 len = sizeof(struct aml_dma_dev) + sizeof(struct aml_dma_chan) * chan_nr;
b84b5197e344e2 Xianwei Zhao 2026-09-03 619 aml_dma = devm_kzalloc(&pdev->dev, len, GFP_KERNEL);
b84b5197e344e2 Xianwei Zhao 2026-09-03 620 if (!aml_dma)
b84b5197e344e2 Xianwei Zhao 2026-09-03 621 return -ENOMEM;
b84b5197e344e2 Xianwei Zhao 2026-09-03 622
b84b5197e344e2 Xianwei Zhao 2026-09-03 623 aml_dma->free_wq = alloc_ordered_workqueue("aml_dma_free", 0);
b84b5197e344e2 Xianwei Zhao 2026-09-03 624 if (!aml_dma->free_wq)
b84b5197e344e2 Xianwei Zhao 2026-09-03 625 return -ENOMEM;
b84b5197e344e2 Xianwei Zhao 2026-09-03 626
b84b5197e344e2 Xianwei Zhao 2026-09-03 627 aml_dma->chan_nr = chan_nr;
b84b5197e344e2 Xianwei Zhao 2026-09-03 628
b84b5197e344e2 Xianwei Zhao 2026-09-03 629 aml_dma->base = devm_platform_ioremap_resource(pdev, 0);
b84b5197e344e2 Xianwei Zhao 2026-09-03 630 if (IS_ERR(aml_dma->base))
b84b5197e344e2 Xianwei Zhao 2026-09-03 631 return PTR_ERR(aml_dma->base);
b84b5197e344e2 Xianwei Zhao 2026-09-03 632
b84b5197e344e2 Xianwei Zhao 2026-09-03 633 aml_dma->regmap = devm_regmap_init_mmio(&pdev->dev, aml_dma->base,
b84b5197e344e2 Xianwei Zhao 2026-09-03 634 &aml_regmap_config);
b84b5197e344e2 Xianwei Zhao 2026-09-03 635 if (IS_ERR_OR_NULL(aml_dma->regmap))
b84b5197e344e2 Xianwei Zhao 2026-09-03 @636 return PTR_ERR(aml_dma->regmap);
b84b5197e344e2 Xianwei Zhao 2026-09-03 637
b84b5197e344e2 Xianwei Zhao 2026-09-03 638 aml_dma->clk = devm_clk_get_enabled(&pdev->dev, NULL);
b84b5197e344e2 Xianwei Zhao 2026-09-03 639 if (IS_ERR(aml_dma->clk))
b84b5197e344e2 Xianwei Zhao 2026-09-03 640 return PTR_ERR(aml_dma->clk);
b84b5197e344e2 Xianwei Zhao 2026-09-03 641
b84b5197e344e2 Xianwei Zhao 2026-09-03 642 aml_dma->irq = platform_get_irq(pdev, 0);
b84b5197e344e2 Xianwei Zhao 2026-09-03 643
b84b5197e344e2 Xianwei Zhao 2026-09-03 644 aml_dma->pdev = pdev;
b84b5197e344e2 Xianwei Zhao 2026-09-03 645 aml_dma->dma_device.dev = &pdev->dev;
b84b5197e344e2 Xianwei Zhao 2026-09-03 646
b84b5197e344e2 Xianwei Zhao 2026-09-03 647 dma_dev = &aml_dma->dma_device;
b84b5197e344e2 Xianwei Zhao 2026-09-03 648 INIT_LIST_HEAD(&dma_dev->channels);
b84b5197e344e2 Xianwei Zhao 2026-09-03 649
b84b5197e344e2 Xianwei Zhao 2026-09-03 650 /* Initialize channel parameters */
b84b5197e344e2 Xianwei Zhao 2026-09-03 651 for (i = 0; i < chan_nr; i++) {
b84b5197e344e2 Xianwei Zhao 2026-09-03 652 struct aml_dma_chan *aml_chan = &aml_dma->aml_chans[i];
b84b5197e344e2 Xianwei Zhao 2026-09-03 653
b84b5197e344e2 Xianwei Zhao 2026-09-03 654 aml_chan->aml_dma = aml_dma;
b84b5197e344e2 Xianwei Zhao 2026-09-03 655 aml_chan->vchan.desc_free = aml_dma_free_desc;
b84b5197e344e2 Xianwei Zhao 2026-09-03 656 vchan_init(&aml_chan->vchan, &aml_dma->dma_device);
b84b5197e344e2 Xianwei Zhao 2026-09-03 657 }
b84b5197e344e2 Xianwei Zhao 2026-09-03 658 aml_dma->chan_used = 0;
b84b5197e344e2 Xianwei Zhao 2026-09-03 659
b84b5197e344e2 Xianwei Zhao 2026-09-03 660 dma_set_max_seg_size(dma_dev->dev, SG_MAX_LEN);
b84b5197e344e2 Xianwei Zhao 2026-09-03 661 dma_cap_set(DMA_SLAVE, dma_dev->cap_mask);
b84b5197e344e2 Xianwei Zhao 2026-09-03 662 dma_dev->device_alloc_chan_resources = aml_dma_alloc_chan_resources;
b84b5197e344e2 Xianwei Zhao 2026-09-03 663 dma_dev->device_free_chan_resources = aml_dma_free_chan_resources;
b84b5197e344e2 Xianwei Zhao 2026-09-03 664 dma_dev->device_tx_status = aml_dma_tx_status;
b84b5197e344e2 Xianwei Zhao 2026-09-03 665 dma_dev->device_prep_slave_sg = aml_dma_prep_slave_sg;
b84b5197e344e2 Xianwei Zhao 2026-09-03 666 dma_dev->device_pause = aml_dma_chan_pause;
b84b5197e344e2 Xianwei Zhao 2026-09-03 667 dma_dev->device_resume = aml_dma_chan_resume;
b84b5197e344e2 Xianwei Zhao 2026-09-03 668 dma_dev->device_terminate_all = aml_dma_terminate_all;
b84b5197e344e2 Xianwei Zhao 2026-09-03 669 dma_dev->device_issue_pending = aml_dma_issue_pending;
b84b5197e344e2 Xianwei Zhao 2026-09-03 670 /* PIO 4 bytes and I2C 1 byte */
b84b5197e344e2 Xianwei Zhao 2026-09-03 671 dma_dev->dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) | BIT(DMA_SLAVE_BUSWIDTH_1_BYTE);
b84b5197e344e2 Xianwei Zhao 2026-09-03 672 dma_dev->directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
b84b5197e344e2 Xianwei Zhao 2026-09-03 673 dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
b84b5197e344e2 Xianwei Zhao 2026-09-03 674
b84b5197e344e2 Xianwei Zhao 2026-09-03 675 regmap_write(aml_dma->regmap, RCH_INT_MASK, INT_MASK);
b84b5197e344e2 Xianwei Zhao 2026-09-03 676 regmap_write(aml_dma->regmap, WCH_INT_MASK, INT_MASK);
b84b5197e344e2 Xianwei Zhao 2026-09-03 677
b84b5197e344e2 Xianwei Zhao 2026-09-03 678 ret = devm_request_irq(&pdev->dev, aml_dma->irq, aml_dma_interrupt_handler,
b84b5197e344e2 Xianwei Zhao 2026-09-03 679 0, dev_name(&pdev->dev), aml_dma);
b84b5197e344e2 Xianwei Zhao 2026-09-03 680 if (ret)
b84b5197e344e2 Xianwei Zhao 2026-09-03 681 return dev_err_probe(&pdev->dev, ret, "failed to register irq\n");
b84b5197e344e2 Xianwei Zhao 2026-09-03 682
b84b5197e344e2 Xianwei Zhao 2026-09-03 683 ret = dmaenginem_async_device_register(dma_dev);
b84b5197e344e2 Xianwei Zhao 2026-09-03 684 if (ret)
b84b5197e344e2 Xianwei Zhao 2026-09-03 685 return dev_err_probe(&pdev->dev, ret, "failed to register dmaenginem\n");
b84b5197e344e2 Xianwei Zhao 2026-09-03 686
b84b5197e344e2 Xianwei Zhao 2026-09-03 687 ret = of_dma_controller_register(np, aml_of_dma_xlate, aml_dma);
b84b5197e344e2 Xianwei Zhao 2026-09-03 688 if (ret)
b84b5197e344e2 Xianwei Zhao 2026-09-03 689 return dev_err_probe(&pdev->dev, ret, "failed to register xlate\n");
b84b5197e344e2 Xianwei Zhao 2026-09-03 690
b84b5197e344e2 Xianwei Zhao 2026-09-03 691 platform_set_drvdata(pdev, aml_dma);
b84b5197e344e2 Xianwei Zhao 2026-09-03 692
b84b5197e344e2 Xianwei Zhao 2026-09-03 693 return 0;
b84b5197e344e2 Xianwei Zhao 2026-09-03 694 }
b84b5197e344e2 Xianwei Zhao 2026-09-03 695
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-08 7:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-08 7:22 [linux-next:master 13311/15025] drivers/dma/amlogic-dma.c:636 aml_dma_probe() warn: passing zero to 'PTR_ERR' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.