* [android-common:android17-6.18 4/4] mm/rmap.c:902 folio_referenced_one() warn: inconsistent indenting
@ 2026-10-08 8:35 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-10-08 8:35 UTC (permalink / raw)
To: cros-kernel-buildreports; +Cc: oe-kbuild-all
tree: https://android.googlesource.com/kernel/common android17-6.18
head: 9d29ba85d8a2c505b2d049568c3b1d29c4e0c2fd
commit: 45aaa4d09fecd1c6fa743c38c14d66789640dd4d [4/4] ANDROID: vendor_hooks: Add hooks for lookaround
config: i386-randconfig-2200-20261008 (https://download.01.org/0day-ci/archive/20261008/202610081003.EEmOmKcn-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610081003.EEmOmKcn-lkp@intel.com/
smatch warnings:
mm/rmap.c:902 folio_referenced_one() warn: inconsistent indenting
vim +902 mm/rmap.c
1acbc3f936146d1 Yin Fengwei 2023-09-18 847
8749cfea11f3fff Vladimir Davydov 2016-01-15 848 /*
b3ac04132c4b9bc Matthew Wilcox (Oracle 2022-01-21 849) * arg: folio_referenced_arg will be passed
8749cfea11f3fff Vladimir Davydov 2016-01-15 850 */
2f031c6f042cb8a Matthew Wilcox (Oracle 2022-01-29 851) static bool folio_referenced_one(struct folio *folio,
2f031c6f042cb8a Matthew Wilcox (Oracle 2022-01-29 852) struct vm_area_struct *vma, unsigned long address, void *arg)
8749cfea11f3fff Vladimir Davydov 2016-01-15 853 {
b3ac04132c4b9bc Matthew Wilcox (Oracle 2022-01-21 854) struct folio_referenced_arg *pra = arg;
b3ac04132c4b9bc Matthew Wilcox (Oracle 2022-01-21 855) DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, 0);
a2880202767dade Kiryl Shutsemau 2025-09-23 856 int ptes = 0, referenced = 0;
8749cfea11f3fff Vladimir Davydov 2016-01-15 857
8eaedede825a02d Kiryl Shutsemau 2017-02-24 858 while (page_vma_mapped_walk(&pvmw)) {
8eaedede825a02d Kiryl Shutsemau 2017-02-24 859 address = pvmw.address;
71e3aac0724ffe8 Andrea Arcangeli 2011-01-13 860
1acbc3f936146d1 Yin Fengwei 2023-09-18 861 if (vma->vm_flags & VM_LOCKED) {
a2880202767dade Kiryl Shutsemau 2025-09-23 862 ptes++;
a2880202767dade Kiryl Shutsemau 2025-09-23 863 pra->mapcount--;
a2880202767dade Kiryl Shutsemau 2025-09-23 864
a2880202767dade Kiryl Shutsemau 2025-09-23 865 /* Only mlock fully mapped pages */
a2880202767dade Kiryl Shutsemau 2025-09-23 866 if (pvmw.pte && ptes != pvmw.nr_pages)
a2880202767dade Kiryl Shutsemau 2025-09-23 867 continue;
a2880202767dade Kiryl Shutsemau 2025-09-23 868
a2880202767dade Kiryl Shutsemau 2025-09-23 869 /*
a2880202767dade Kiryl Shutsemau 2025-09-23 870 * All PTEs must be protected by page table lock in
a2880202767dade Kiryl Shutsemau 2025-09-23 871 * order to mlock the page.
a2880202767dade Kiryl Shutsemau 2025-09-23 872 *
a2880202767dade Kiryl Shutsemau 2025-09-23 873 * If page table boundary has been cross, current ptl
a2880202767dade Kiryl Shutsemau 2025-09-23 874 * only protect part of ptes.
a2880202767dade Kiryl Shutsemau 2025-09-23 875 */
a2880202767dade Kiryl Shutsemau 2025-09-23 876 if (pvmw.flags & PVMW_PGTABLE_CROSSED)
a2880202767dade Kiryl Shutsemau 2025-09-23 877 continue;
a2880202767dade Kiryl Shutsemau 2025-09-23 878
47d4f3eeef5f7fd Hugh Dickins 2022-02-14 879 /* Restore the mlock which got missed */
1acbc3f936146d1 Yin Fengwei 2023-09-18 880 mlock_vma_folio(folio, vma);
8eaedede825a02d Kiryl Shutsemau 2017-02-24 881 page_vma_mapped_walk_done(&pvmw);
9f32624be943538 Joonsoo Kim 2014-01-21 882 pra->vm_flags |= VM_LOCKED;
e4b82222712ed15 Minchan Kim 2017-05-03 883 return false; /* To break the loop */
2da28bfd9665f49 Andrea Arcangeli 2011-03-11 884 }
2da28bfd9665f49 Andrea Arcangeli 2011-03-11 885
c495b97624d0c05 Zhiguo Jiang 2024-07-10 886 /*
c495b97624d0c05 Zhiguo Jiang 2024-07-10 887 * Skip the non-shared swapbacked folio mapped solely by
c495b97624d0c05 Zhiguo Jiang 2024-07-10 888 * the exiting or OOM-reaped process. This avoids redundant
c495b97624d0c05 Zhiguo Jiang 2024-07-10 889 * swap-out followed by an immediate unmap.
c495b97624d0c05 Zhiguo Jiang 2024-07-10 890 */
c495b97624d0c05 Zhiguo Jiang 2024-07-10 891 if ((!atomic_read(&vma->vm_mm->mm_users) ||
c495b97624d0c05 Zhiguo Jiang 2024-07-10 892 check_stable_address_space(vma->vm_mm)) &&
c495b97624d0c05 Zhiguo Jiang 2024-07-10 893 folio_test_anon(folio) && folio_test_swapbacked(folio) &&
003fde4492c88ac David Hildenbrand 2025-03-03 894 !folio_maybe_mapped_shared(folio)) {
c495b97624d0c05 Zhiguo Jiang 2024-07-10 895 pra->referenced = -1;
c495b97624d0c05 Zhiguo Jiang 2024-07-10 896 page_vma_mapped_walk_done(&pvmw);
c495b97624d0c05 Zhiguo Jiang 2024-07-10 897 return false;
c495b97624d0c05 Zhiguo Jiang 2024-07-10 898 }
c495b97624d0c05 Zhiguo Jiang 2024-07-10 899
1d4832becdc2cdb Yu Zhao 2024-10-19 900 if (lru_gen_enabled() && pvmw.pte) {
45aaa4d09fecd1c Peifeng Li 2022-09-13 901 trace_android_vh_look_around(&pvmw, folio, vma, &referenced);
1d4832becdc2cdb Yu Zhao 2024-10-19 @902 if (lru_gen_look_around(&pvmw))
018ee47f14893d5 Yu Zhao 2022-09-18 903 referenced++;
1d4832becdc2cdb Yu Zhao 2024-10-19 904 } else if (pvmw.pte) {
8eaedede825a02d Kiryl Shutsemau 2017-02-24 905 if (ptep_clear_flush_young_notify(vma, address,
8788f6781486769 Yu Zhao 2022-12-30 906 pvmw.pte))
^1da177e4c3f415 Linus Torvalds 2005-04-16 907 referenced++;
8749cfea11f3fff Vladimir Davydov 2016-01-15 908 } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) {
8eaedede825a02d Kiryl Shutsemau 2017-02-24 909 if (pmdp_clear_flush_young_notify(vma, address,
8eaedede825a02d Kiryl Shutsemau 2017-02-24 910 pvmw.pmd))
8749cfea11f3fff Vladimir Davydov 2016-01-15 911 referenced++;
8749cfea11f3fff Vladimir Davydov 2016-01-15 912 } else {
b3ac04132c4b9bc Matthew Wilcox (Oracle 2022-01-21 913) /* unexpected pmd-mapped folio? */
8749cfea11f3fff Vladimir Davydov 2016-01-15 914 WARN_ON_ONCE(1);
8749cfea11f3fff Vladimir Davydov 2016-01-15 915 }
8eaedede825a02d Kiryl Shutsemau 2017-02-24 916
8eaedede825a02d Kiryl Shutsemau 2017-02-24 917 pra->mapcount--;
8eaedede825a02d Kiryl Shutsemau 2017-02-24 918 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 919
33c3fc71c8cfa3c Vladimir Davydov 2015-09-09 920 if (referenced)
b3ac04132c4b9bc Matthew Wilcox (Oracle 2022-01-21 921) folio_clear_idle(folio);
b3ac04132c4b9bc Matthew Wilcox (Oracle 2022-01-21 922) if (folio_test_clear_young(folio))
33c3fc71c8cfa3c Vladimir Davydov 2015-09-09 923 referenced++;
33c3fc71c8cfa3c Vladimir Davydov 2015-09-09 924
9f32624be943538 Joonsoo Kim 2014-01-21 925 if (referenced) {
9f32624be943538 Joonsoo Kim 2014-01-21 926 pra->referenced++;
47d4f3eeef5f7fd Hugh Dickins 2022-02-14 927 pra->vm_flags |= vma->vm_flags & ~VM_LOCKED;
^1da177e4c3f415 Linus Torvalds 2005-04-16 928 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 929
9f32624be943538 Joonsoo Kim 2014-01-21 930 if (!pra->mapcount)
e4b82222712ed15 Minchan Kim 2017-05-03 931 return false; /* To break the loop */
34bbd704051c9d0 Oleg Nesterov 2007-02-28 932
e4b82222712ed15 Minchan Kim 2017-05-03 933 return true;
^1da177e4c3f415 Linus Torvalds 2005-04-16 934 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 935
:::::: The code at line 902 was first introduced by commit
:::::: 1d4832becdc2cdb2cffe2a6050c9d9fd8ff1c58c mm: multi-gen LRU: use {ptep,pmdp}_clear_young_notify()
:::::: TO: Yu Zhao <yuzhao@google.com>
:::::: CC: Andrew Morton <akpm@linux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-08 8:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-08 8:35 [android-common:android17-6.18 4/4] mm/rmap.c:902 folio_referenced_one() warn: inconsistent indenting kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.