From: phucduc.bui@gmail.com
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
povik+lin@cutebit.org, Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Andrei Simion <andrei.simion@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: Kees Cook <kees@kernel.org>,
Syed Saba Kareem <syed.sabakareem@amd.com>,
wangdicheng <wangdicheng@kylinos.cn>,
Chris Bainbridge <chris.bainbridge@gmail.com>,
Linus Walleij <linusw@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Neo Chang <YLCHANG2@nuvoton.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
u.kleine-koenig@baylibre.com, Pengpeng Hou <pengpeng@iscas.ac.cn>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Hemanth Selam <hemanth.selam@gmail.com>,
Md Shofiqul Islam <shofiqtest@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Zain Aboobacker <zainaboobacker33@gmail.com>,
Sang-Heon Jeon <ekffu200098@gmail.com>,
Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@amd.com>,
Bo Shen <voice.shen@atmel.com>, Vinod Koul <vkoul@kernel.org>,
linux-sound@vger.kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org,
imx@lists.linux.dev, linux-rockchip@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 10/24] ASoC: codecs: cs42l42: Ensure the DAI is marked as started on success
Date: Thu, 8 Oct 2026 17:38:17 +0700 [thread overview]
Message-ID: <20261008103831.542533-11-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
snd_pcm_hw_constraint_minmax() may return 1, which is then returned
from cs42l42_dai_startup(). ASoC only marks the DAI as started when
.startup() returns 0.
This currently has no functional impact, as cs42l42_ops has no
.shutdown() callback. Still, return 0 explicitly on success to
match what ASoC expects and ensure the DAI is correctly marked as
started.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/codecs/cs42l42.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c
index b5d69d5516a6..f6e4bf6206b7 100644
--- a/sound/soc/codecs/cs42l42.c
+++ b/sound/soc/codecs/cs42l42.c
@@ -890,6 +890,7 @@ static int cs42l42_dai_startup(struct snd_pcm_substream *substream, struct snd_s
{
struct snd_soc_component *component = dai->component;
struct cs42l42_private *cs42l42 = snd_soc_component_get_drvdata(component);
+ int ret;
/*
* Sample rates < 44.1 kHz would produce an out-of-range SCLK with
@@ -900,9 +901,13 @@ static int cs42l42_dai_startup(struct snd_pcm_substream *substream, struct snd_s
return 0;
/* Machine driver has not set a SCLK, limit bottom end to 44.1 kHz */
- return snd_pcm_hw_constraint_minmax(substream->runtime,
- SNDRV_PCM_HW_PARAM_RATE,
- 44100, 96000);
+ ret = snd_pcm_hw_constraint_minmax(substream->runtime,
+ SNDRV_PCM_HW_PARAM_RATE,
+ 44100, 96000);
+ if (ret < 0)
+ return ret;
+
+ return 0;
}
static int cs42l42_pcm_hw_params(struct snd_pcm_substream *substream,
--
2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: phucduc.bui@gmail.com
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
povik+lin@cutebit.org, Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Andrei Simion <andrei.simion@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: imx@lists.linux.dev, wangdicheng <wangdicheng@kylinos.cn>,
Kees Cook <kees@kernel.org>,
Sang-Heon Jeon <ekffu200098@gmail.com>,
Pengpeng Hou <pengpeng@iscas.ac.cn>,
Bo Shen <voice.shen@atmel.com>, Neo Chang <YLCHANG2@nuvoton.com>,
linux-rockchip@lists.infradead.org,
bui duc phuc <phucduc.bui@gmail.com>,
Chris Bainbridge <chris.bainbridge@gmail.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
linux-sound@vger.kernel.org,
Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@amd.com>,
u.kleine-koenig@baylibre.com,
Zain Aboobacker <zainaboobacker33@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Md Shofiqul Islam <shofiqtest@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
patches@opensource.cirrus.com, Linus Walleij <linusw@kernel.org>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>,
asahi@lists.linux.dev, Hemanth Selam <hemanth.selam@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
Syed Saba Kareem <syed.sabakareem@amd.com>
Subject: [PATCH 10/24] ASoC: codecs: cs42l42: Ensure the DAI is marked as started on success
Date: Thu, 8 Oct 2026 17:38:17 +0700 [thread overview]
Message-ID: <20261008103831.542533-11-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
snd_pcm_hw_constraint_minmax() may return 1, which is then returned
from cs42l42_dai_startup(). ASoC only marks the DAI as started when
.startup() returns 0.
This currently has no functional impact, as cs42l42_ops has no
.shutdown() callback. Still, return 0 explicitly on success to
match what ASoC expects and ensure the DAI is correctly marked as
started.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/codecs/cs42l42.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c
index b5d69d5516a6..f6e4bf6206b7 100644
--- a/sound/soc/codecs/cs42l42.c
+++ b/sound/soc/codecs/cs42l42.c
@@ -890,6 +890,7 @@ static int cs42l42_dai_startup(struct snd_pcm_substream *substream, struct snd_s
{
struct snd_soc_component *component = dai->component;
struct cs42l42_private *cs42l42 = snd_soc_component_get_drvdata(component);
+ int ret;
/*
* Sample rates < 44.1 kHz would produce an out-of-range SCLK with
@@ -900,9 +901,13 @@ static int cs42l42_dai_startup(struct snd_pcm_substream *substream, struct snd_s
return 0;
/* Machine driver has not set a SCLK, limit bottom end to 44.1 kHz */
- return snd_pcm_hw_constraint_minmax(substream->runtime,
- SNDRV_PCM_HW_PARAM_RATE,
- 44100, 96000);
+ ret = snd_pcm_hw_constraint_minmax(substream->runtime,
+ SNDRV_PCM_HW_PARAM_RATE,
+ 44100, 96000);
+ if (ret < 0)
+ return ret;
+
+ return 0;
}
static int cs42l42_pcm_hw_params(struct snd_pcm_substream *substream,
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-10-08 10:41 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 10:38 [PATCH 00/24] ASoC: Fix constraint return value handling phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 01/24] ASoC: amd: acp: Fix .close() being skipped on rollback phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 02/24] ASoC: amd: ps: Fix acp63_pdm_dma_close() " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 03/24] ASoC: amd: ps: Fix acp63_sdw_dma_close() " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 04/24] ASoC: amd: raven: Fix acp3x_dma_close() " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 05/24] ASoC: amd: renoir: Fix acp_pdm_dma_close() " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 06/24] ASoC: amd: vangogh: Fix acp5x_dma_close() " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:54 ` sashiko-bot
2026-10-08 10:38 ` [PATCH 07/24] ASoC: amd: yc: Fix acp6x_pdm_dma_close() " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 08/24] ASoC: apple: mca: Ensure the DAI is marked as started on success phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 09/24] ASoC: atmel: atmel-pcm-pdc: Fix atmel_pcm_close() being skipped on rollback phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` phucduc.bui [this message]
2026-10-08 10:38 ` [PATCH 10/24] ASoC: codecs: cs42l42: Ensure the DAI is marked as started on success phucduc.bui
2026-10-08 10:47 ` Richard Fitzgerald
2026-10-08 10:47 ` Richard Fitzgerald
2026-10-08 11:00 ` Bui Duc Phuc
2026-10-08 11:00 ` Bui Duc Phuc
2026-10-08 10:38 ` [PATCH 11/24] ASoC: codecs: nau8325: " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 12/24] ASoC: codecs: nau8540: " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 13/24] ASoC: codecs: nau8821: " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 14/24] ASoC: codecs: nau8824: " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 15/24] ASoC: codecs: nau8825: " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 16/24] ASoC: codecs: wm8580: " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 17/24] ASoC: codecs: wm8782: " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 18/24] ASoC: imx-pcm-rpmsg: Fix imx_rpmsg_pcm_close() being skipped on rollback phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-13 6:04 ` Chancel Liu
2026-10-13 6:04 ` Chancel Liu
2026-10-08 10:38 ` [PATCH 19/24] ASoC: intel: atom: Fix .shutdown() " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 20/24] ASoC: renesas: fsi: Ensure the component is marked as opened on success phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 21/24] ASoC: renesas: msiof: Fix msiof_close() being skipped on rollback phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:57 ` sashiko-bot
2026-10-11 1:41 ` Bui Duc Phuc
2026-10-13 0:02 ` Kuninori Morimoto
2026-10-13 0:02 ` Kuninori Morimoto
2026-10-13 4:18 ` Bui Duc Phuc
2026-10-13 4:18 ` Bui Duc Phuc
2026-10-13 5:49 ` Kuninori Morimoto
2026-10-13 5:49 ` Kuninori Morimoto
2026-10-13 10:12 ` Bui Duc Phuc
2026-10-13 10:12 ` Bui Duc Phuc
2026-10-08 10:38 ` [PATCH 22/24] ASoC: renesas: rz-ssi: Ensure the component is marked as opened on success phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 23/24] ASoC: rockchip: rk3399_gru_sound: Mark the link as started " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-08 10:38 ` [PATCH 24/24] ASoC: rockchip: rockchip_max98090: " phucduc.bui
2026-10-08 10:38 ` phucduc.bui
2026-10-13 6:13 ` [PATCH 00/24] ASoC: Fix constraint return value handling Mukunda,Vijendar
2026-10-13 6:13 ` Mukunda,Vijendar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008103831.542533-11-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=AjitKumar.Pandey@amd.com \
--cc=Frank.Li@nxp.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=Xiubo.Lee@gmail.com \
--cc=YLCHANG2@nuvoton.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrei.simion@microchip.com \
--cc=asahi@lists.linux.dev \
--cc=bhelgaas@google.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=chris.bainbridge@gmail.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=cristian.ciocaltea@collabora.com \
--cc=david.rhodes@cirrus.com \
--cc=ekffu200098@gmail.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=hemanth.selam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kai.vehmanen@linux.intel.com \
--cc=kees@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=magnus.damm@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=nicoleotsuka@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=pengpeng@iscas.ac.cn \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=povik+lin@cutebit.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rf@opensource.cirrus.com \
--cc=s.hauer@pengutronix.de \
--cc=shengjiu.wang@gmail.com \
--cc=shofiqtest@gmail.com \
--cc=syed.sabakareem@amd.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=venkataprasad.potturu@amd.com \
--cc=vkoul@kernel.org \
--cc=voice.shen@atmel.com \
--cc=wangdicheng@kylinos.cn \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zainaboobacker33@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.