* [merged mm-stable] mm-huge_memory-move-memcg-switch-into-the-file-split-helper.patch removed from -mm tree
@ 2026-10-09 6:00 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-10-09 6:00 UTC (permalink / raw)
To: mm-commits, ziy, youngjun.park, yeoreum.yun, vbabka, usama.arif,
surenb, shivamkalra98, shikemeng, ryncsn, ryan.roberts, rppt,
nphamcs, nico.pache, mhocko, ljs, liam, lance.yang, kas, dev.jain,
david, chrisl, baoquan.he, baolin.wang, baohua, kasong, akpm
The quilt patch titled
Subject: mm/huge_memory: move memcg switch into the file split helper
has been removed from the -mm tree. Its filename was
mm-huge_memory-move-memcg-switch-into-the-file-split-helper.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Kairui Song <kasong@tencent.com>
Subject: mm/huge_memory: move memcg switch into the file split helper
Date: Wed, 23 Sep 2026 23:32:44 +0200
The xarray node allocations in __folio_freeze_split_file() need to be
charged to the folio's memcg, so move the memcg switch from
__folio_split() into the helper.
The anon split helper and the after-split folio freeing perform no
chargeable allocations, so no memcg handling is left in __folio_split().
Rename its out_no_memcg label to out.
Link: https://lore.kernel.org/20260923-swap-thp-cleanup-v6-13-ba1b4ba72c6f@tencent.com
Signed-off-by: Kairui Song <kasong@tencent.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Zi Yan <ziy@nvidia.com>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Reviewed-by: Yeoreum Yun <yeoreum.yun@arm.com>
Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Nico Pache <nico.pache@linux.dev>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Lance Yang <lance.yang@linux.dev>
Cc: Usama Arif <usama.arif@linux.dev>
Cc: Vlastimil Babka <vbabka@kernel.org>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Chris Li <chrisl@kernel.org>
Cc: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: Nhat Pham <nphamcs@gmail.com>
Cc: Baoquan He <baoquan.he@linux.dev>
Cc: Barry Song <baohua@kernel.org>
Cc: Youngjun Park <youngjun.park@lge.com>
Cc: Shivam Kalra <shivamkalra98@zohomail.in>
Cc: Kairui Song <ryncsn@gmail.com>
---
mm/huge_memory.c | 36 +++++++++++++++++++-----------------
1 file changed, 19 insertions(+), 17 deletions(-)
--- a/mm/huge_memory.c~mm-huge_memory-move-memcg-switch-into-the-file-split-helper
+++ a/mm/huge_memory.c
@@ -4142,6 +4142,7 @@ static int __folio_freeze_split_file(str
struct address_space *mapping = folio->mapping;
XA_STATE(xas, &mapping->i_pages, folio->index);
struct folio *end_folio = folio_next(folio);
+ struct mem_cgroup *memcg, *old_memcg;
struct folio *new_folio, *next;
int nr_shmem_dropped = 0;
unsigned int min_order;
@@ -4154,9 +4155,18 @@ static int __folio_freeze_split_file(str
if (new_order < min_order)
return -EINVAL;
+ /*
+ * Switch to folio's memcg as xarray node allocation can happen and
+ * needs to charge to it.
+ */
+ memcg = get_mem_cgroup_from_folio(folio);
+ old_memcg = set_active_memcg(memcg);
+
gfp = current_gfp_context(mapping_gfp_mask(mapping) & GFP_RECLAIM_MASK);
- if (!filemap_release_folio(folio, gfp))
- return -EBUSY;
+ if (!filemap_release_folio(folio, gfp)) {
+ ret = -EBUSY;
+ goto fail_free;
+ }
mapping_set_update(&xas, mapping);
@@ -4288,6 +4298,9 @@ fail_mmap_unlock:
*/
i_mmap_unlock_read(mapping);
fail_free:
+ /* Restore the previously active memcg */
+ set_active_memcg(old_memcg);
+ mem_cgroup_put(memcg);
xas_destroy(&xas);
return ret;
}
@@ -4319,7 +4332,6 @@ static int __folio_split(struct folio *f
{
struct folio *end_folio = folio_next(folio);
bool is_anon = folio_test_anon(folio);
- struct mem_cgroup *memcg, *old_memcg;
int old_order = folio_order(folio);
struct folio *new_folio, *next;
int ret;
@@ -4329,27 +4341,20 @@ static int __folio_split(struct folio *f
if (folio != page_folio(split_at) || folio != page_folio(lock_at)) {
ret = -EINVAL;
- goto out_no_memcg;
+ goto out;
}
if (new_order >= old_order) {
ret = -EINVAL;
- goto out_no_memcg;
+ goto out;
}
ret = folio_check_splittable(folio, new_order, split_type);
if (ret) {
VM_WARN_ONCE(ret == -EINVAL, "Tried to split an unsplittable folio");
- goto out_no_memcg;
+ goto out;
}
- /*
- * switch to folio's memcg as xarray node allocation can happen and
- * needs to charge to it.
- */
- memcg = get_mem_cgroup_from_folio(folio);
- old_memcg = set_active_memcg(memcg);
-
if (is_anon)
ret = __folio_freeze_split_anon(folio, new_order, split_at,
true, list, split_type);
@@ -4376,10 +4381,7 @@ static int __folio_split(struct folio *f
free_folio_and_swap_cache(new_folio);
}
- /* restore to caller's old_memcg */
- set_active_memcg(old_memcg);
- mem_cgroup_put(memcg);
-out_no_memcg:
+out:
if (is_pmd_order(old_order))
count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED);
count_mthp_stat(old_order, !ret ? MTHP_STAT_SPLIT : MTHP_STAT_SPLIT_FAILED);
_
Patches currently in -mm which might be from kasong@tencent.com are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-09 6:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-09 6:00 [merged mm-stable] mm-huge_memory-move-memcg-switch-into-the-file-split-helper.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.