[linux-next:master 2129/15343] drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c:3124:5-12: Unneeded variable: "handled". Return "1" on line 3134

[linux-next:master 2129/15343] drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c:3124:5-12: Unneeded variable: "handled". Return "1" on line 3134

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   aac26bee2287c88af5be5a5ff96d783b19a28790
commit: 27e8d24f653f2089b2eaea55538b7d172a77e46c [2129/15343] drm/amdgpu: Add UALink IH ring and enable interrupt
config: x86_64-randconfig-2100-20261008 (https://download.01.org/0day-ci/archive/20261009/202610091139.jj0KTOHT-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610091139.jj0KTOHT-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c:3124:5-12: Unneeded variable: "handled". Return "1" on line 3134
--
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c:3157:2-34: opportunity for str_enable_disable(state == AMDGPU_IRQ_STATE_ENABLE)

vim +3124 drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c

  3119	
  3120	static int amdgpu_ualink_process_irq(struct amdgpu_device *adev,
  3121					     struct amdgpu_irq_src *source,
  3122					     struct amdgpu_iv_entry *entry)
  3123	{
> 3124		int handled = 1;
  3125	
  3126		dev_dbg(adev->dev, "%s client_id 0x%x src_id 0x%x ih\n",
  3127			entry->ih == &adev->irq.ih ? "ring" : "ualink soft ring",
  3128			entry->client_id, entry->src_id);
  3129	
  3130		/* Copy IH entry into ualink soft ring. */
  3131		if (entry->ih == &adev->irq.ih) {
  3132			dev_dbg(adev->dev, "delegate to ualink irq soft ring\n");
  3133			amdgpu_irq_ualink_delegate(adev, entry, 8);
> 3134			return handled;
  3135		}
  3136	
  3137		/*
  3138		 * Call amdgpu_ualink_interrupt handler
  3139		 * amdgpu_ualink_interrupt(adev, entry);
  3140		 */
  3141	
  3142		return handled;
  3143	}
  3144	
  3145	static int amdgpu_ualink_set_irq_state(struct amdgpu_device *adev,
  3146						struct amdgpu_irq_src *source,
  3147						u32 type,
  3148						enum amdgpu_interrupt_state state)
  3149	{
  3150		/*
  3151		 * Don't set register to enable/disable nHT controller interrupt.
  3152		 *
  3153		 * F/W running on MP2, which can always send cookie to IH block to
  3154		 * interrupt driver.
  3155		 */
  3156		dev_dbg(adev->dev, "ualink interrupt %s\n",
> 3157			state == AMDGPU_IRQ_STATE_ENABLE ? "enable" : "disable");
  3158		return 0;
  3159	}
  3160	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki