From: Magnus Lindholm <linmag7@gmail.com>
To: richard.henderson@linaro.org, mattst88@gmail.com,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org
Cc: linmag7@gmail.com, stable@vger.kernel.org
Subject: [PATCH v5 4/8] alpha: invalidate the local context in flush_tlb_page()
Date: Sat, 10 Oct 2026 16:24:30 +0200 [thread overview]
Message-ID: <20261010142533.974797-5-linmag7@gmail.com> (raw)
In-Reply-To: <20261010142533.974797-1-linmag7@gmail.com>
When the target mm is not the calling CPU's active_mm, flush_tlb_page()
does nothing locally, and smp_call_function() reaches only the other CPUs.
This CPU may still hold translations for the mm and can later reuse the
old ASN together with them.
Add the missing else branch. flush_tlb_other() clears mm->context[cpu] so
a fresh ASN is taken at the next switch. Add this before changing the
current->active_mm test to current->mm: that change will also send lazy
callers here, so their local invalidate must already be in place.
The uniprocessor implementations of flush_tlb_mm() and
flush_icache_user_page() in asm/tlbflush.h and asm/cacheflush.h already
contain exactly this branch.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Magnus Lindholm <linmag7@gmail.com>
---
arch/alpha/kernel/smp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c
index 1ad448105201..e4ba0aab8a66 100644
--- a/arch/alpha/kernel/smp.c
+++ b/arch/alpha/kernel/smp.c
@@ -697,6 +697,9 @@ flush_tlb_page(struct vm_area_struct *vma, unsigned long addr)
preempt_enable();
return;
}
+ } else {
+ /* smp_call_function() does not call back into this CPU. */
+ flush_tlb_other(mm);
}
data.vma = vma;
--
2.43.0
next prev parent reply other threads:[~2026-10-10 14:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 14:24 [PATCH v5 0/8] alpha: fix stale TLB translations breaking copy-on-write and writeback Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 1/8] alpha: load the MMU context when switch_mm() switches the current task Magnus Lindholm
2026-10-10 23:32 ` Matt Turner
2026-10-11 14:48 ` Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 2/8] alpha: run check_mmu_context() from finish_arch_post_lock_switch() Magnus Lindholm
2026-10-10 23:32 ` Matt Turner
2026-10-11 14:56 ` Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 3/8] alpha: only use a targeted tbi() when the target mm is really current Magnus Lindholm
2026-10-10 14:24 ` Magnus Lindholm [this message]
2026-10-10 14:24 ` [PATCH v5 5/8] alpha: fix the local TLB invalidate in flush_tlb_page() Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 6/8] alpha: fix the local TLB invalidate in the UP flush_tlb_page() Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 7/8] alpha: invalidate the local context in flush_tlb_mm() Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 8/8] alpha: invalidate the local context in flush_icache_user_page() Magnus Lindholm
2026-10-10 23:31 ` [PATCH v5 0/8] alpha: fix stale TLB translations breaking copy-on-write and writeback Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261010142533.974797-5-linmag7@gmail.com \
--to=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=richard.henderson@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.