All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Lindholm <linmag7@gmail.com>
To: richard.henderson@linaro.org, mattst88@gmail.com,
	linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org
Cc: linmag7@gmail.com, stable@vger.kernel.org
Subject: [PATCH v5 6/8] alpha: fix the local TLB invalidate in the UP flush_tlb_page()
Date: Sat, 10 Oct 2026 16:24:32 +0200	[thread overview]
Message-ID: <20261010142533.974797-7-linmag7@gmail.com> (raw)
In-Reply-To: <20261010142533.974797-1-linmag7@gmail.com>

The uniprocessor flush_tlb_page() in asm/tlbflush.h has the same wrong
test as the SMP one: a targeted tbi() is only guaranteed to invalidate
the intended translations when the target mm's context is loaded, but
the gate is current->active_mm, which a lazily borrowed mm also
satisfies.

Test current->mm instead. The else branch it falls to already exists
here, so unlike the SMP side this is the whole fix.
arch/alpha/kernel/smp.c is not built with CONFIG_SMP=n, so this is how
the same defect reaches a uniprocessor, where the flusher kworker
necessarily shares the only CPU with the writer.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Magnus Lindholm <linmag7@gmail.com>
---
 arch/alpha/include/asm/tlbflush.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/alpha/include/asm/tlbflush.h b/arch/alpha/include/asm/tlbflush.h
index 0c8529997f54..9ae1902faf8e 100644
--- a/arch/alpha/include/asm/tlbflush.h
+++ b/arch/alpha/include/asm/tlbflush.h
@@ -87,7 +87,8 @@ flush_tlb_page(struct vm_area_struct *vma, unsigned long addr)
 {
 	struct mm_struct *mm = vma->vm_mm;
 
-	if (mm == current->active_mm)
+	/* A targeted tbi() needs a thread of MM to be current.  */
+	if (mm == current->mm)
 		flush_tlb_current_page(mm, vma, addr);
 	else
 		flush_tlb_other(mm);
-- 
2.43.0


  parent reply	other threads:[~2026-10-10 14:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10 14:24 [PATCH v5 0/8] alpha: fix stale TLB translations breaking copy-on-write and writeback Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 1/8] alpha: load the MMU context when switch_mm() switches the current task Magnus Lindholm
2026-10-10 23:32   ` Matt Turner
2026-10-11 14:48     ` Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 2/8] alpha: run check_mmu_context() from finish_arch_post_lock_switch() Magnus Lindholm
2026-10-10 23:32   ` Matt Turner
2026-10-11 14:56     ` Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 3/8] alpha: only use a targeted tbi() when the target mm is really current Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 4/8] alpha: invalidate the local context in flush_tlb_page() Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 5/8] alpha: fix the local TLB invalidate " Magnus Lindholm
2026-10-10 14:24 ` Magnus Lindholm [this message]
2026-10-10 14:24 ` [PATCH v5 7/8] alpha: invalidate the local context in flush_tlb_mm() Magnus Lindholm
2026-10-10 14:24 ` [PATCH v5 8/8] alpha: invalidate the local context in flush_icache_user_page() Magnus Lindholm
2026-10-10 23:31 ` [PATCH v5 0/8] alpha: fix stale TLB translations breaking copy-on-write and writeback Matt Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261010142533.974797-7-linmag7@gmail.com \
    --to=linmag7@gmail.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=richard.henderson@linaro.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.