Re: [PATCH v2 1/3] dt-bindings: phy: Add CIX Sky1 DP PHY

From: Conor Dooley <conor@kernel.org>
To: Luo Liu <Luo.Liu@cixtech.com>
Cc: vkoul@kernel.org, neil.armstrong@linaro.org, mani@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	gary.yang@cixtech.com, fugang.duan@cixtech.com,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	cix-kernel-upstream@cixtech.com, p.zabel@pengutronix.de,
	linux-kernel@vger.kernel.org, Wuyi.Shen@cixtech.com,
	EastLake.Yang@cixtech.com
Subject: Re: [PATCH v2 1/3] dt-bindings: phy: Add CIX Sky1 DP PHY
Date: Mon, 12 Oct 2026 19:54:32 +0100	[thread overview]
Message-ID: <20261012-founding-stench-55cff46fe1a3@spud> (raw)
In-Reply-To: <20261012123618.648930-2-Luo.Liu@cixtech.com>

[-- Attachment #1: Type: text/plain, Size: 3040 bytes --]

On Mon, Oct 12, 2026 at 08:36:16PM +0800, Luo Liu wrote:
> Document the dedicated DisplayPort PHY on CIX Sky1, including the
> optional cix,external-dp board property for external connector swing.
> Add a MAINTAINERS entry for the binding and driver.
> 
> Signed-off-by: Luo Liu <Luo.Liu@cixtech.com>
> ---
>  .../bindings/phy/cix,sky1-dp-phy.yaml         | 53 +++++++++++++++++++
>  MAINTAINERS                                   |  8 +++
>  2 files changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/cix,sky1-dp-phy.yaml
> 
> diff --git a/Documentation/devicetree/bindings/phy/cix,sky1-dp-phy.yaml b/Documentation/devicetree/bindings/phy/cix,sky1-dp-phy.yaml
> new file mode 100644
> index 000000000000..c6914cab74e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/cix,sky1-dp-phy.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/cix,sky1-dp-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: CIX Sky1 DisplayPort PHY
> +
> +maintainers:
> +  - Luo Liu <Luo.Liu@cixtech.com>
> +
> +description:
> +  The CIX Sky1 DP PHY provides the PMA/CDB register interface for the
> +  dedicated DisplayPort instance on CIX Sky1.
> +
> +properties:
> +  compatible:
> +    const: cix,sky1-dp-phy
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#phy-cells":
> +    const: 0
> +
> +  resets:
> +    maxItems: 1
> +    description: PHY hardware reset
> +
> +  cix,external-dp:
> +    type: boolean
> +    description:
> +      Use voltage swing values suitable for an external DisplayPort
> +      connector instead of the default low-voltage values.
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#phy-cells"
> +  - resets

A reset but no clocks? That's a bit hard to believe.

Seems fine otherwise, unless I am missing some sort of common property
for the voltage swing stuff.

Thanks,
Conor.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/reset/cix,sky1-s5-system-control.h>
> +
> +    phy@1414c000 {
> +        compatible = "cix,sky1-dp-phy";
> +        reg = <0x1414c000 0x4000>;
> +        resets = <&s5_syscon SKY1_DP_PHY_RST_N>;
> +        #phy-cells = <0>;
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3a19da74d00c..b46d0f4220a9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6360,6 +6360,14 @@ M:	Satish Kharat <satishkh@cisco.com>
>  S:	Supported
>  F:	drivers/infiniband/hw/usnic/
>  
> +CIX SKY1 DISPLAYPORT PHY DRIVER
> +M:	Luo Liu <Luo.Liu@cixtech.com>
> +R:	CIX Linux Kernel Upstream Group <cix-kernel-upstream@cixtech.com>
> +L:	linux-phy@lists.infradead.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/phy/cix,sky1-dp-phy.yaml
> +F:	drivers/phy/cix/
> +
>  CLANG CONTEXT ANALYSIS
>  M:	Marco Elver <elver@google.com>
>  R:	Bart Van Assche <bvanassche@acm.org>
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]