[PATCH] EDAC/mce_amd: Add missing long names for SMCA bank types

[PATCH] EDAC/mce_amd: Add missing long names for SMCA bank types

[Guixiong Wei]

Commit 47b744ea5e3c ("x86/MCE/AMD: Add new MA_LLC, USR_DP,
and USR_CP bank types") added three SMCA bank types after the bank long
names had been moved to the MCE decoder.

The new types were added to the enum, short-name table, and HWID/McaType
mapping, but not to smca_long_names[]. As a result, an error from any of
these banks is logged with "(null)" in place of the bank name.

Add the missing long names.

Fixes: 47b744ea5e3c ("x86/MCE/AMD: Add new MA_LLC, USR_DP, and USR_CP bank types")
Cc: stable@vger.kernel.org
Signed-off-by: Guixiong Wei <weiguixiong@bytedance.com>
---
 drivers/edac/mce_amd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index 7aee57a25b689..34a44769d1d0f 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -702,6 +702,7 @@ static const char * const smca_long_names[] = {
 	[SMCA_L2_CACHE]			= "L2 Cache",
 	[SMCA_L3_CACHE]			= "L3 Cache",
 	[SMCA_LS ... SMCA_LS_V2]	= "Load Store Unit",
+	[SMCA_MA_LLC]			= "Memory Attached Last Level Cache",
 	[SMCA_MP5]			= "Microprocessor 5 Unit",
 	[SMCA_MPART]			= "MPART Unit",
 	[SMCA_MPASP ... SMCA_MPASP_V2]	= "MPASP Unit",
@@ -726,6 +727,8 @@ static const char * const smca_long_names[] = {
 	[SMCA_UMC]			= "Unified Memory Controller",
 	[SMCA_UMC_V2]			= "Unified Memory Controller v2",
 	[SMCA_USB]			= "USB Unit",
+	[SMCA_USR_CP]			= "Ultra Short Reach Control Plane Controller",
+	[SMCA_USR_DP]			= "Ultra Short Reach Data Plane Controller",
 	[SMCA_WAFL_PHY]			= "WAFL PHY Unit",
 	[SMCA_XGMI_PCS]			= "Ext Global Memory Interconnect PCS Unit",
 	[SMCA_XGMI_PHY]			= "Ext Global Memory Interconnect PHY Unit",
-- 
2.50.1 (Apple Git-155)

Re: [PATCH] EDAC/mce_amd: Add missing long names for SMCA bank types

[Borislav Petkov]

On Fri, Oct 09, 2026 at 10:04:24AM +0800, Guixiong Wei wrote:
> Commit 47b744ea5e3c ("x86/MCE/AMD: Add new MA_LLC, USR_DP,
> and USR_CP bank types") added three SMCA bank types after the bank long
> names had been moved to the MCE decoder.
> 
> The new types were added to the enum, short-name table, and HWID/McaType
> mapping, but not to smca_long_names[]. As a result, an error from any of
> these banks is logged with "(null)" in place of the bank name.
> 
> Add the missing long names.
> 
> Fixes: 47b744ea5e3c ("x86/MCE/AMD: Add new MA_LLC, USR_DP, and USR_CP bank types")
> Cc: stable@vger.kernel.org

Which of the real-bug-fix criteria at the top of that file:

Documentation/process/stable-kernel-rules.rst

justify the CC:stable tag?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH] EDAC/mce_amd: Add missing long names for SMCA bank types

[Yazen Ghannam]

On Fri, Oct 09, 2026 at 10:04:24AM +0800, Guixiong Wei wrote:
> Commit 47b744ea5e3c ("x86/MCE/AMD: Add new MA_LLC, USR_DP,
> and USR_CP bank types") added three SMCA bank types after the bank long
> names had been moved to the MCE decoder.
> 
> The new types were added to the enum, short-name table, and HWID/McaType
> mapping, but not to smca_long_names[]. As a result, an error from any of
> these banks is logged with "(null)" in place of the bank name.
> 
> Add the missing long names.
> 
> Fixes: 47b744ea5e3c ("x86/MCE/AMD: Add new MA_LLC, USR_DP, and USR_CP bank types")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guixiong Wei <weiguixiong@bytedance.com>

These were intentionaly left out as it as it seems users have been
moving to user space decode tools.

Do you actually need these in the kernel?

Thanks,
Yazen

Re: [PATCH] EDAC/mce_amd: Add missing long names for SMCA bank types

[Borislav Petkov]

On Mon, Oct 12, 2026 at 10:03:30AM -0400, Yazen Ghannam wrote:
> These were intentionaly left out as it as it seems users have been
> moving to user space decode tools.

You're making the old mistake:

a. a naked MCE record in dmesg, you have to open the PPRs and actually decode
it by hand. Or use a tool but most of the time, that tool is not updated with
the latest error definitions, and you need the exact machine info in order for
the tool to decode properly, yadda yadda...

b. Get a fully decoded error string in dmesg.

What is better: a) or b) ?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette