[PATCH 0/1] iio: atlas-ezo: Fix humidity channel read support

[PATCH 0/1] iio: atlas-ezo: Fix humidity channel read support

[Nikhil Gautam]

The atlas_ezo_read_raw() function currently rejects channels whose
type is not IIO_CONCENTRATION. As a result, the relative humidity channel
cannot access the raw or scale values, even though the driver defines support
for IIO_HUMIDITYRELATIVE.

Remove the early channel type check so that both concentration and
relative humidity channels can be handled by the existing mask-specific logic.

Nikhil Gautam (1):
  iio: atlas-ezo: Fix humidity channel read support

 drivers/iio/chemical/atlas-ezo-sensor.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.39.5

[PATCH 1/1] iio: atlas-ezo: Fix humidity channel read support

[Nikhil Gautam]

The atlas_ezo_read_raw() function rejects channels that are not of
type IIO_CONCENTRATION, preventing the relative humidity channel
from reading raw and scale values.

Remove the early channel type check to allow both concentration
and relative humidity channels to reach the mask-specific handling.

Signed-off-by: Nikhil Gautam <nikhilgtr@gmail.com>
---
 drivers/iio/chemical/atlas-ezo-sensor.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/iio/chemical/atlas-ezo-sensor.c b/drivers/iio/chemical/atlas-ezo-sensor.c
index de0b87edd188..ee939e74bdae 100644
--- a/drivers/iio/chemical/atlas-ezo-sensor.c
+++ b/drivers/iio/chemical/atlas-ezo-sensor.c
@@ -117,9 +117,6 @@ static int atlas_ezo_read_raw(struct iio_dev *indio_dev,
 	struct atlas_ezo_data *data = iio_priv(indio_dev);
 	struct i2c_client *client = data->client;
 
-	if (chan->type != IIO_CONCENTRATION)
-		return -EINVAL;
-
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW: {
 		int ret;
-- 
2.39.5

Re: [PATCH 1/1] iio: atlas-ezo: Fix humidity channel read support

[Joshua Crofts]

On Mon, 12 Oct 2026 17:15:53 +0530
Nikhil Gautam <nikhilgtr@gmail.com> wrote:

> The atlas_ezo_read_raw() function rejects channels that are not of
> type IIO_CONCENTRATION, preventing the relative humidity channel
> from reading raw and scale values.
> 
> Remove the early channel type check to allow both concentration
> and relative humidity channels to reach the mask-specific handling.
> 
> Signed-off-by: Nikhil Gautam <nikhilgtr@gmail.com>
> ---

What a weird check...

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

Additionally, Sashiko found a potential I2C read issue, please check
it out.

https://sashiko.dev/#/patchset/20261012114553.3327-1-nikhilgtr%40gmail.com

-- 
Kind regards,
Joshua Crofts

Re: [PATCH 1/1] iio: atlas-ezo: Fix humidity channel read support

[Andy Shevchenko]

On Mon, Oct 12, 2026 at 05:15:53PM +0530, Nikhil Gautam wrote:
> The atlas_ezo_read_raw() function rejects channels that are not of
> type IIO_CONCENTRATION, preventing the relative humidity channel
> from reading raw and scale values.
> 
> Remove the early channel type check to allow both concentration
> and relative humidity channels to reach the mask-specific handling.

Have you checked the Git history on this change? Anything interesting there?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/1] iio: atlas-ezo: Fix humidity channel read support

[Nikhil Gautam]

Hi Joshua, Andy,

Thanks for the review and feedback.

I checked the Git history and found that the channel type check was 
already present
in commit dc3ebfc ("iio: chemical: atlas-ezo-sensor: add humidity sensor 
support").
It was not removed when humidity sensor support was introduced, and
I couldn't find any commit message explaining the original intent of the 
check.

Regarding the potential I2C read issue reported by Sashiko,
I'll investigate it and address it in a separate patch series.

I'll also omit the cover letter for future single-patch submissions.

Thanks,
Nikhil

On 13-10-2026 02:15 am, Andy Shevchenko wrote:
> On Mon, Oct 12, 2026 at 05:15:53PM +0530, Nikhil Gautam wrote:
>> The atlas_ezo_read_raw() function rejects channels that are not of
>> type IIO_CONCENTRATION, preventing the relative humidity channel
>> from reading raw and scale values.
>>
>> Remove the early channel type check to allow both concentration
>> and relative humidity channels to reach the mask-specific handling.
> Have you checked the Git history on this change? Anything interesting there?
>

Re: [PATCH 0/1] iio: atlas-ezo: Fix humidity channel read support

[Joshua Crofts]

On Mon, 12 Oct 2026 17:15:52 +0530
Nikhil Gautam <nikhilgtr@gmail.com> wrote:

> The atlas_ezo_read_raw() function currently rejects channels whose
> type is not IIO_CONCENTRATION. As a result, the relative humidity channel
> cannot access the raw or scale values, even though the driver defines support
> for IIO_HUMIDITYRELATIVE.
> 
> Remove the early channel type check so that both concentration and
> relative humidity channels can be handled by the existing mask-specific logic.
> 
> Nikhil Gautam (1):
>   iio: atlas-ezo: Fix humidity channel read support
> 
>  drivers/iio/chemical/atlas-ezo-sensor.c | 3 ---
>  1 file changed, 3 deletions(-)
> 

No need to add a cover letter if you're just sending one patch.

Thanks.

-- 
Kind regards,
Joshua Crofts

Re: [PATCH 0/1] iio: atlas-ezo: Fix humidity channel read support

[Andy Shevchenko]

On Mon, Oct 12, 2026 at 05:15:52PM +0530, Nikhil Gautam wrote:
> The atlas_ezo_read_raw() function currently rejects channels whose
> type is not IIO_CONCENTRATION. As a result, the relative humidity channel
> cannot access the raw or scale values, even though the driver defines support
> for IIO_HUMIDITYRELATIVE.
> 
> Remove the early channel type check so that both concentration and
> relative humidity channels can be handled by the existing mask-specific logic.

Cover letter is not required for a single patch. Anything you want to say can
be added in the comment block (after '---' cutter line).

-- 
With Best Regards,
Andy Shevchenko