Re: [PATCH 05/12] xfs: update quota flags on secondary supers when metadir enabled

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Oct 12, 2026 at 06:17:46AM -0700, Christoph Hellwig wrote:
> On Sun, Oct 11, 2026 at 11:00:09PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > xfs/085 exposes an interesting bug when metadir is enabled, quotas are
> > enabled via mount option, and the primary superblock crc fails
> > validation:
> 
> The code looks ok, but I think the Sashiko complaints about non-metadir
> fses at least are valid.

Yep, I'll fix that.

> Handling the errors seems fine, but maybe the
> comments shouldn't mislead it that the update is purely opportunistic?

Yeah.  As written this patch makes secondary sb update failures block
mount, but on second thought I decided that since the secondaries only
come into play for xfs_repair, and only if the primary gets clobbered,
this all can get backed down to a warning:


/*
 * For metadir filesystems, quota flag state persists across mounts, so
 * update secondary superblocks in case xfs_repair ever has to recover
 * the primary from a secondary.  growfs also updates backup supers so
 * lock against that.  Note that the secondary backups are
 * opportunistic, so we log but do not return write errors.
 */
void
__xfs_qm_update_secondary_metadir_sb(
	struct xfs_mount	*mp,
	const char		*func)
{
	int			error;

	if (!xfs_has_metadir(mp))
		return;

	mutex_lock(&mp->m_growlock);
	error = xfs_update_secondary_sbs(mp);
	mutex_unlock(&mp->m_growlock);

	if (error)
		xfs_alert(mp, "%s: Secondary super update failed, err=%d!",
				func, error);
}

And this sole helper can get called from the three places that need it.

--D