From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 08/12] xfs: drop unnecessary sa parameter from the xrep_ag init functions
Date: Mon, 12 Oct 2026 06:18:45 -0700 [thread overview]
Message-ID: <aszeNWI4gcAFyVAY@infradead.org> (raw)
In-Reply-To: <179178065968.1058822.15486087597596647429.stgit@frogsfrogsfrogs>
On Sun, Oct 11, 2026 at 11:00:56PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM went down a crazy path complaining about the horrible things that
> happen in these functions if sa != &sc->sa. However, I observe that the
> sa argument is never not &sc->sa, so let's just drop the parameter.
> There's no bug here, but let's get rid of some stupid.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-10-12 13:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 5:55 [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 23 Darrick J. Wong
2026-10-12 5:59 ` [PATCH 01/12] xfs: don't set a metadata directory's parent to sb_rootino Darrick J. Wong
2026-10-12 13:13 ` Christoph Hellwig
2026-10-12 5:59 ` [PATCH 02/12] xfs: don't rescan ifree and icount when frozen Darrick J. Wong
2026-10-12 13:13 ` Christoph Hellwig
2026-10-12 5:59 ` [PATCH 03/12] xfs: rescan the AGs if incore delalloc counter is negative Darrick J. Wong
2026-10-12 13:16 ` Christoph Hellwig
2026-10-12 16:14 ` Darrick J. Wong
2026-10-12 5:59 ` [PATCH 04/12] xfs: don't try to repair rtsummary if the summary file isn't computed Darrick J. Wong
2026-10-12 13:16 ` Christoph Hellwig
2026-10-12 6:00 ` [PATCH 05/12] xfs: update quota flags on secondary supers when metadir enabled Darrick J. Wong
2026-10-12 13:17 ` Christoph Hellwig
2026-10-12 16:30 ` Darrick J. Wong
2026-10-12 6:00 ` [PATCH 06/12] xfs: refactor directory data block walking loops in scrub Darrick J. Wong
2026-10-12 13:18 ` Christoph Hellwig
2026-10-12 6:00 ` [PATCH 07/12] xfs: improve dirent bounds checking in scrub and repair Darrick J. Wong
2026-10-12 13:18 ` Christoph Hellwig
2026-10-12 6:00 ` [PATCH 08/12] xfs: drop unnecessary sa parameter from the xrep_ag init functions Darrick J. Wong
2026-10-12 13:18 ` Christoph Hellwig [this message]
2026-10-12 6:01 ` [PATCH 09/12] xfs: drop unnecessary sr parameter from xrep_rtgroup " Darrick J. Wong
2026-10-12 13:19 ` Christoph Hellwig
2026-10-12 6:01 ` [PATCH 10/12] xfs: drop unnecessary sa parameter from xchk_ag " Darrick J. Wong
2026-10-12 13:19 ` Christoph Hellwig
2026-10-12 6:01 ` [PATCH 11/12] xfs: drop unnecessary sr parameter from xchk_rtgroup " Darrick J. Wong
2026-10-12 13:19 ` Christoph Hellwig
2026-10-12 6:01 ` [PATCH 12/12] xfs: refactor inode forkoff to byte conversions Darrick J. Wong
2026-10-12 13:19 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2026-10-13 6:05 [PATCHSET v2 2/2] xfs: LLM-inspired bug fixes, part 23 Darrick J. Wong
2026-10-13 6:10 ` [PATCH 08/12] xfs: drop unnecessary sa parameter from the xrep_ag init functions Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aszeNWI4gcAFyVAY@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.