* [android-common:android14-kiwi-6.1 294/294] drivers/dma-buf/dma-buf.c:413: warning: Function parameter or member 'dmabuf_info' not described in 'dma_buf_account_task'
@ 2026-10-12 20:38 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-10-12 20:38 UTC (permalink / raw)
To: cros-kernel-buildreports; +Cc: oe-kbuild-all
Hi Mercier,
FYI, the error/warning still remains.
tree: https://android.googlesource.com/kernel/common android14-kiwi-6.1
head: 3c746ad5d5d2bb8acea14252e89e1395c7da86f7
commit: 5dd8a05ba11a36d91c244d3e482a18a275e5d8ad [294/294] ANDROID: Don't use current pointer for per-process dmabuf accounting
config: i386-randconfig-1009-20261012 (https://download.01.org/0day-ci/archive/20261013/202610130432.wuVmujBF-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261013/202610130432.wuVmujBF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610130432.wuVmujBF-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/dma-buf/dma-buf.c:413: warning: Function parameter or member 'dmabuf_info' not described in 'dma_buf_account_task'
>> drivers/dma-buf/dma-buf.c:413: warning: Excess function parameter 'task' description in 'dma_buf_account_task'
>> drivers/dma-buf/dma-buf.c:452: warning: Function parameter or member 'dmabuf_info' not described in 'dma_buf_unaccount_task'
>> drivers/dma-buf/dma-buf.c:452: warning: Excess function parameter 'task' description in 'dma_buf_unaccount_task'
drivers/dma-buf/dma-buf.c:932: warning: Function parameter or member 'name' not described in 'dma_buf_set_name'
drivers/dma-buf/dma-buf.c:932: warning: Excess function parameter 'buf' description in 'dma_buf_set_name'
vim +413 drivers/dma-buf/dma-buf.c
060742b3d06d5d T.J. Mercier 2025-07-22 398
060742b3d06d5d T.J. Mercier 2025-07-22 399 /**
060742b3d06d5d T.J. Mercier 2025-07-22 400 * dma_buf_account_task - Account a dmabuf to a task
060742b3d06d5d T.J. Mercier 2025-07-22 401 * @dmabuf: [in] pointer to dma_buf
060742b3d06d5d T.J. Mercier 2025-07-22 402 * @task: [in] pointer to task_struct
060742b3d06d5d T.J. Mercier 2025-07-22 403 *
060742b3d06d5d T.J. Mercier 2025-07-22 404 * When a process obtains a dmabuf file descriptor, or maps a dmabuf, this
060742b3d06d5d T.J. Mercier 2025-07-22 405 * function attributes the provided @dmabuf to the @task. The first time @dmabuf
060742b3d06d5d T.J. Mercier 2025-07-22 406 * is attributed to @task, the buffer's size is added to the @task's dmabuf RSS.
060742b3d06d5d T.J. Mercier 2025-07-22 407 *
060742b3d06d5d T.J. Mercier 2025-07-22 408 * Return:
060742b3d06d5d T.J. Mercier 2025-07-22 409 * * 0 on success
060742b3d06d5d T.J. Mercier 2025-07-22 410 * * A negative error code upon error
060742b3d06d5d T.J. Mercier 2025-07-22 411 */
5dd8a05ba11a36 T.J. Mercier 2025-11-12 412 int dma_buf_account_task(struct dma_buf *dmabuf, struct task_dma_buf_info *dmabuf_info)
060742b3d06d5d T.J. Mercier 2025-07-22 @413 {
060742b3d06d5d T.J. Mercier 2025-07-22 414 struct task_dma_buf_record *rec;
060742b3d06d5d T.J. Mercier 2025-07-22 415
baa7a3655a17c8 Suren Baghdasaryan 2025-08-01 416 if (!static_key_enabled(&dmabuf_accounting_key))
baa7a3655a17c8 Suren Baghdasaryan 2025-08-01 417 return 0;
baa7a3655a17c8 Suren Baghdasaryan 2025-08-01 418
060742b3d06d5d T.J. Mercier 2025-07-22 419 if (!dmabuf_info)
060742b3d06d5d T.J. Mercier 2025-07-22 420 return 0;
060742b3d06d5d T.J. Mercier 2025-07-22 421
060742b3d06d5d T.J. Mercier 2025-07-22 422 if (!task_dmabuf_records_preload(1))
060742b3d06d5d T.J. Mercier 2025-07-22 423 return -ENOMEM;
060742b3d06d5d T.J. Mercier 2025-07-22 424
060742b3d06d5d T.J. Mercier 2025-07-22 425 spin_lock(&dmabuf_info->lock);
060742b3d06d5d T.J. Mercier 2025-07-22 426 rec = find_task_dmabuf_record(dmabuf_info, dmabuf);
060742b3d06d5d T.J. Mercier 2025-07-22 427 if (rec) {
060742b3d06d5d T.J. Mercier 2025-07-22 428 ++rec->refcnt;
060742b3d06d5d T.J. Mercier 2025-07-22 429 trim_task_dmabuf_records_locked();
060742b3d06d5d T.J. Mercier 2025-07-22 430 } else {
060742b3d06d5d T.J. Mercier 2025-07-22 431 rec = alloc_task_dmabuf_record();
060742b3d06d5d T.J. Mercier 2025-07-22 432 WARN_ON(!rec);
060742b3d06d5d T.J. Mercier 2025-07-22 433 add_task_dmabuf_record(dmabuf_info, dmabuf, rec);
060742b3d06d5d T.J. Mercier 2025-07-22 434 }
060742b3d06d5d T.J. Mercier 2025-07-22 435 spin_unlock(&dmabuf_info->lock);
060742b3d06d5d T.J. Mercier 2025-07-22 436 task_dmabuf_records_preload_end();
060742b3d06d5d T.J. Mercier 2025-07-22 437
060742b3d06d5d T.J. Mercier 2025-07-22 438 return 0;
060742b3d06d5d T.J. Mercier 2025-07-22 439 }
060742b3d06d5d T.J. Mercier 2025-07-22 440
060742b3d06d5d T.J. Mercier 2025-07-22 441 /**
060742b3d06d5d T.J. Mercier 2025-07-22 442 * dma_buf_unaccount_task - Unaccount a dmabuf from a task
060742b3d06d5d T.J. Mercier 2025-07-22 443 * @dmabuf: [in] pointer to dma_buf
060742b3d06d5d T.J. Mercier 2025-07-22 444 * @task: [in] pointer to task_struct
060742b3d06d5d T.J. Mercier 2025-07-22 445 *
060742b3d06d5d T.J. Mercier 2025-07-22 446 * When a process closes a dmabuf file descriptor, or unmaps a dmabuf, this
060742b3d06d5d T.J. Mercier 2025-07-22 447 * function removes the provided @dmabuf attribution from the @task. When all
060742b3d06d5d T.J. Mercier 2025-07-22 448 * references to @dmabuf are removed from @task, the buffer's size is removed
060742b3d06d5d T.J. Mercier 2025-07-22 449 * from the task's dmabuf RSS.
060742b3d06d5d T.J. Mercier 2025-07-22 450 */
5dd8a05ba11a36 T.J. Mercier 2025-11-12 451 void dma_buf_unaccount_task(struct dma_buf *dmabuf, struct task_dma_buf_info *dmabuf_info)
060742b3d06d5d T.J. Mercier 2025-07-22 @452 {
060742b3d06d5d T.J. Mercier 2025-07-22 453 struct task_dma_buf_record *rec;
060742b3d06d5d T.J. Mercier 2025-07-22 454
baa7a3655a17c8 Suren Baghdasaryan 2025-08-01 455 if (!static_key_enabled(&dmabuf_accounting_key))
baa7a3655a17c8 Suren Baghdasaryan 2025-08-01 456 return;
baa7a3655a17c8 Suren Baghdasaryan 2025-08-01 457
060742b3d06d5d T.J. Mercier 2025-07-22 458 if (!dmabuf_info)
060742b3d06d5d T.J. Mercier 2025-07-22 459 return;
060742b3d06d5d T.J. Mercier 2025-07-22 460
060742b3d06d5d T.J. Mercier 2025-07-22 461 spin_lock(&dmabuf_info->lock);
060742b3d06d5d T.J. Mercier 2025-07-22 462 rec = find_task_dmabuf_record(dmabuf_info, dmabuf);
060742b3d06d5d T.J. Mercier 2025-07-22 463 if (rec) {
060742b3d06d5d T.J. Mercier 2025-07-22 464 if (--rec->refcnt == 0) {
060742b3d06d5d T.J. Mercier 2025-07-22 465 list_del(&rec->node);
060742b3d06d5d T.J. Mercier 2025-07-22 466 dmabuf_info->dmabuf_count--;
060742b3d06d5d T.J. Mercier 2025-07-22 467 dmabuf_info->rss -= dmabuf->size;
c8372adc56a99a T.J. Mercier 2025-07-01 468 trace_dmabuf_rss_stat(dmabuf_info->rss, -dmabuf->size, dmabuf);
1b269f8eb12649 T.J. Mercier 2025-07-08 469 atomic64_dec(&dmabuf->nr_task_refs);
060742b3d06d5d T.J. Mercier 2025-07-22 470 } else {
060742b3d06d5d T.J. Mercier 2025-07-22 471 rec = NULL;
060742b3d06d5d T.J. Mercier 2025-07-22 472 }
060742b3d06d5d T.J. Mercier 2025-07-22 473 } else {
5dd8a05ba11a36 T.J. Mercier 2025-11-12 474 pr_err("Could not find dmabuf %lu in unaccount\n",
5dd8a05ba11a36 T.J. Mercier 2025-11-12 475 file_inode(dmabuf->file)->i_ino);
060742b3d06d5d T.J. Mercier 2025-07-22 476 }
060742b3d06d5d T.J. Mercier 2025-07-22 477 spin_unlock(&dmabuf_info->lock);
060742b3d06d5d T.J. Mercier 2025-07-22 478 if (rec)
060742b3d06d5d T.J. Mercier 2025-07-22 479 free_task_dmabuf_record(rec);
060742b3d06d5d T.J. Mercier 2025-07-22 480 }
060742b3d06d5d T.J. Mercier 2025-07-22 481
:::::: The code at line 413 was first introduced by commit
:::::: 060742b3d06d5de7b692b6e7340e90bb950769e4 ANDROID: Track per-process dmabuf RSS
:::::: TO: T.J. Mercier <tjmercier@google.com>
:::::: CC: T.J. Mercier <tjmercier@google.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-12 20:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-12 20:38 [android-common:android14-kiwi-6.1 294/294] drivers/dma-buf/dma-buf.c:413: warning: Function parameter or member 'dmabuf_info' not described in 'dma_buf_account_task' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.