* [merged mm-stable] selftests-mm-make-the-swap-cases-swapout-reliable.patch removed from -mm tree
@ 2026-10-13 4:33 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-10-13 4:33 UTC (permalink / raw)
To: mm-commits, ziy, vbabka, usama.arif, usama.anjum, surenb, shuah,
ryan.roberts, rppt, nico.pache, mhocko, ljs, liam, leon,
lance.yang, kernel-team, jgg, hughd, dev.jain, david, baolin.wang,
baohua, agordeev, kas, akpm
The quilt patch titled
Subject: selftests/mm: make the swap cases' swapout reliable
has been removed from the -mm tree. Its filename was
selftests-mm-make-the-swap-cases-swapout-reliable.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
Subject: selftests/mm: make the swap cases' swapout reliable
Date: Sat, 19 Sep 2026 01:24:35 +0100
collapse_swapin_single_pte() and collapse_max_ptes_swap() swap a range out
and then require smaps to report exactly the count they asked for. Two
things keep that count from arriving.
MADV_PAGEOUT is best effort, so the count often turns up a moment late.
And wait_for_scan() leaves the range eligible for collapsing, so
khugepaged is still working on it. Collapsing reads the swapped-out pages
back in, so the daemon empties the swap as fast as the case fills it. On
arm64 with 64K pages max_ptes_swap is 1024 pages, which is 64M a step, and
the case loses the race:
# Swapout 1024 of 8192 pages... Fail
not ok 10 collapse_max_ptes_swap
Retry for up to two seconds, holding the range out of khugepaged's reach
meanwhile. The collapse each case runs next restores MADV_HUGEPAGE, so
only the setup is affected.
If the pages still won't swap out, skip: no swap, swap too small or full,
a memcg cap or busy writeback. None of that is a kernel bug.
Link: https://lore.kernel.org/20260919002451.496763-6-kirill@shutemov.name
Signed-off-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@arm.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Tested-by: Muhammad Usama Anjum <usama.anjum@arm.com>
Assisted-by: LLM
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Barry Song <baohua@kernel.org>
Cc: "David Hildenbrand (arm)" <david@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Hugh Dickens <hughd@google.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: kernel-team@meta.com
Cc: Lance Yang <lance.yang@linux.dev>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: Liam Howlett <liam@infradead.org>
Cc: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport (Microsoft) <rppt@kernel.org>
Cc: Nico Pache (Red Hat) <nico.pache@linux.dev>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Shuah Khan (Samsung OSG) <shuah@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Usama Arif <usama.arif@linux.dev>
Cc: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc: Zi Yan <ziy@nvidia.com>
---
tools/testing/selftests/mm/khugepaged.c | 41 +++++++++++++++-------
1 file changed, 29 insertions(+), 12 deletions(-)
--- a/tools/testing/selftests/mm/khugepaged.c~selftests-mm-make-the-swap-cases-swapout-reliable
+++ a/tools/testing/selftests/mm/khugepaged.c
@@ -221,6 +221,29 @@ err_out:
return swap;
}
+static bool swapout_range(void *p, unsigned long size)
+{
+ int i;
+
+ /* keep khugepaged from collapsing the range and swapping it back in */
+ if (madvise(p, size, MADV_NOHUGEPAGE))
+ ksft_exit_fail_perror("madvise(MADV_NOHUGEPAGE)");
+
+ /*
+ * Retry several times because MADV_PAGEOUT is best effort. Sleep
+ * between the retries to give outstanding writeback a chance to
+ * finish.
+ */
+ for (i = 0; i < 40; i++) {
+ if (madvise(p, size, MADV_PAGEOUT))
+ ksft_exit_fail_perror("madvise(MADV_PAGEOUT)");
+ if (check_swap(p, size))
+ return true;
+ usleep(50 * 1000);
+ }
+ return false;
+}
+
static void *alloc_mapping(int nr)
{
void *p;
@@ -828,12 +851,10 @@ static void collapse_swapin_single_pte(s
ops->fault(p, 0, hpage_pmd_size);
ksft_print_msg("Swapout one page...");
- if (madvise(p, page_size, MADV_PAGEOUT))
- ksft_exit_fail_perror("madvise(MADV_PAGEOUT)");
- if (check_swap(p, page_size)) {
+ if (swapout_range(p, page_size)) {
success("OK");
} else {
- fail("Fail");
+ skip("Could not swap out");
goto out;
}
@@ -854,12 +875,10 @@ static void collapse_max_ptes_swap(struc
ops->fault(p, 0, hpage_pmd_size);
ksft_print_msg("Swapout %d of %d pages...", max_ptes_swap + 1, hpage_pmd_nr);
- if (madvise(p, (max_ptes_swap + 1) * page_size, MADV_PAGEOUT))
- ksft_exit_fail_perror("madvise(MADV_PAGEOUT)");
- if (check_swap(p, (max_ptes_swap + 1) * page_size)) {
+ if (swapout_range(p, (max_ptes_swap + 1) * page_size)) {
success("OK");
} else {
- fail("Fail");
+ skip("Could not swap out");
goto out;
}
@@ -871,12 +890,10 @@ static void collapse_max_ptes_swap(struc
ops->fault(p, 0, hpage_pmd_size);
ksft_print_msg("Swapout %d of %d pages...", max_ptes_swap,
hpage_pmd_nr);
- if (madvise(p, max_ptes_swap * page_size, MADV_PAGEOUT))
- ksft_exit_fail_perror("madvise(MADV_PAGEOUT)");
- if (check_swap(p, max_ptes_swap * page_size)) {
+ if (swapout_range(p, max_ptes_swap * page_size)) {
success("OK");
} else {
- fail("Fail");
+ skip("Could not swap out");
goto out;
}
_
Patches currently in -mm which might be from kas@kernel.org are
mm-page_alloc-make-defrag_mode-retries-follow-the-promoted-order.patch
mm-khugepaged-drop-redundant-mm_struct-pin-in-madvise_collapse.patch
mm-khugepaged-count-collapses-where-khugepaged-makes-them.patch
mm-khugepaged-rename-mthp_present_ptes-bitmap-to-eligible_ptes.patch
mm-collapse-add-collapseh-for-the-collapse-interface.patch
mm-collapse-state-what-a-collapse-may-do-in-the-policy.patch
mm-collapse-drop-the-collapse_possible-wrapper.patch
mm-collapse-name-the-per-table-scan-reset-for-what-it-resets.patch
mm-collapse-call-collapse_file-from-collapse_single_pmd.patch
mm-collapse-separate-scanning-a-pte-table-from-collapsing-it.patch
mm-collapse-open-code-collapse_single_pmd-in-its-two-callers.patch
mm-collapse-work-out-the-orders-a-vma-allows-once-per-vma.patch
mm-collapse-declare-the-collapse-interface-in-collapseh.patch
mm-collapse-implement-madv_collapse-in-madvisec.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-13 4:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-13 4:33 [merged mm-stable] selftests-mm-make-the-swap-cases-swapout-reliable.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.