* [PATCH] selinux: use isdigit() in selinux_genfs_get_sid()
@ 2026-10-14 16:07 Thorsten Blum
2026-10-14 16:14 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-10-14 16:07 UTC (permalink / raw)
To: Paul Moore, Stephen Smalley, Ondrej Mosnáček
Cc: Thorsten Blum, selinux, linux-kernel
Use isdigit() to replace the open-coded implementation.
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
security/selinux/hooks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 30776b0107f2..d1304afa42fd 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -31,6 +31,7 @@
#include <linux/lsm_hooks.h>
#include <linux/xattr.h>
#include <linux/capability.h>
+#include <linux/ctype.h>
#include <linux/unistd.h>
#include <linux/mm.h>
#include <linux/mman.h>
@@ -1357,7 +1358,7 @@ static int selinux_genfs_get_sid(struct dentry *dentry,
/* each process gets a /proc/PID/ entry. Strip off the
* PID part to get a valid selinux labeling.
* e.g. /proc/1/net/rpc/nfs -> /net/rpc/nfs */
- while (path[1] >= '0' && path[1] <= '9') {
+ while (isdigit(path[1])) {
path[1] = '/';
path++;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selinux: use isdigit() in selinux_genfs_get_sid()
2026-10-14 16:07 [PATCH] selinux: use isdigit() in selinux_genfs_get_sid() Thorsten Blum
@ 2026-10-14 16:14 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-10-14 16:14 UTC (permalink / raw)
Cc: selinux
> Use isdigit() to replace the open-coded implementation.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261014160741.222219-3-blum@kernel.org?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-14 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-14 16:07 [PATCH] selinux: use isdigit() in selinux_genfs_get_sid() Thorsten Blum
2026-10-14 16:14 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.