From: George Neacsu <geocausa@gmail.com>
To: Bryan O'Donoghue <bod@kernel.org>, Vinod Koul <vkoul@kernel.org>,
David Heidelberg <david@ixit.cz>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-phy@lists.infradead.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
George Neacsu <geocausa@gmail.com>
Subject: [PATCH RFC 3/4] media: qcom: camss: csid-680: Select C-PHY in the receiver
Date: Thu, 15 Oct 2026 23:20:38 +0100 [thread overview]
Message-ID: <20261015-x1e-cphy-rfc-v1-3-1f3fa9af940a@gmail.com> (raw)
In-Reply-To: <20261015-x1e-cphy-rfc-v1-0-1f3fa9af940a@gmail.com>
CSID 680 has a PHY type select in CSI2_RX_CFG0, next to the PHY number.
The field is defined but never written, so the receiver always decodes
D-PHY. Write phy_sel to it, as csid-gen2 does for C-PHY.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: George Neacsu <geocausa@gmail.com>
---
drivers/media/platform/qcom/camss/camss-csid-680.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss-csid-680.c b/drivers/media/platform/qcom/camss/camss-csid-680.c
index 345a67c8f..16b199f06 100644
--- a/drivers/media/platform/qcom/camss/camss-csid-680.c
+++ b/drivers/media/platform/qcom/camss/camss-csid-680.c
@@ -202,6 +202,8 @@ static void __csid_configure_rx(struct csid_device *csid,
<< CSI2_RX_CFG0_PHY_NUM_SEL;
}
+ val |= phy->phy_sel << CSI2_RX_CFG0_PHY_TYPE_SEL;
+
writel(val, csid->base + CSID_CSI2_RX_CFG0);
val = CSI2_RX_CFG1_PACKET_ECC_CORRECTION_EN;
--
2.53.0
WARNING: multiple messages have this Message-ID (diff)
From: George Neacsu via B4 Relay <devnull+geocausa.gmail.com@kernel.org>
To: Bryan O'Donoghue <bod@kernel.org>, Vinod Koul <vkoul@kernel.org>,
David Heidelberg <david@ixit.cz>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-phy@lists.infradead.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
George Neacsu <geocausa@gmail.com>
Subject: [PATCH RFC 3/4] media: qcom: camss: csid-680: Select C-PHY in the receiver
Date: Thu, 15 Oct 2026 23:20:38 +0100 [thread overview]
Message-ID: <20261015-x1e-cphy-rfc-v1-3-1f3fa9af940a@gmail.com> (raw)
In-Reply-To: <20261015-x1e-cphy-rfc-v1-0-1f3fa9af940a@gmail.com>
From: George Neacsu <geocausa@gmail.com>
CSID 680 has a PHY type select in CSI2_RX_CFG0, next to the PHY number.
The field is defined but never written, so the receiver always decodes
D-PHY. Write phy_sel to it, as csid-gen2 does for C-PHY.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: George Neacsu <geocausa@gmail.com>
---
drivers/media/platform/qcom/camss/camss-csid-680.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss-csid-680.c b/drivers/media/platform/qcom/camss/camss-csid-680.c
index 345a67c8f..16b199f06 100644
--- a/drivers/media/platform/qcom/camss/camss-csid-680.c
+++ b/drivers/media/platform/qcom/camss/camss-csid-680.c
@@ -202,6 +202,8 @@ static void __csid_configure_rx(struct csid_device *csid,
<< CSI2_RX_CFG0_PHY_NUM_SEL;
}
+ val |= phy->phy_sel << CSI2_RX_CFG0_PHY_TYPE_SEL;
+
writel(val, csid->base + CSID_CSI2_RX_CFG0);
val = CSI2_RX_CFG1_PACKET_ECC_CORRECTION_EN;
--
2.53.0
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: George Neacsu via B4 Relay <devnull+geocausa.gmail.com@kernel.org>
To: Bryan O'Donoghue <bod@kernel.org>, Vinod Koul <vkoul@kernel.org>,
David Heidelberg <david@ixit.cz>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-phy@lists.infradead.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
George Neacsu <geocausa@gmail.com>
Subject: [PATCH RFC 3/4] media: qcom: camss: csid-680: Select C-PHY in the receiver
Date: Thu, 15 Oct 2026 23:20:38 +0100 [thread overview]
Message-ID: <20261015-x1e-cphy-rfc-v1-3-1f3fa9af940a@gmail.com> (raw)
In-Reply-To: <20261015-x1e-cphy-rfc-v1-0-1f3fa9af940a@gmail.com>
From: George Neacsu <geocausa@gmail.com>
CSID 680 has a PHY type select in CSI2_RX_CFG0, next to the PHY number.
The field is defined but never written, so the receiver always decodes
D-PHY. Write phy_sel to it, as csid-gen2 does for C-PHY.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: George Neacsu <geocausa@gmail.com>
---
drivers/media/platform/qcom/camss/camss-csid-680.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss-csid-680.c b/drivers/media/platform/qcom/camss/camss-csid-680.c
index 345a67c8f..16b199f06 100644
--- a/drivers/media/platform/qcom/camss/camss-csid-680.c
+++ b/drivers/media/platform/qcom/camss/camss-csid-680.c
@@ -202,6 +202,8 @@ static void __csid_configure_rx(struct csid_device *csid,
<< CSI2_RX_CFG0_PHY_NUM_SEL;
}
+ val |= phy->phy_sel << CSI2_RX_CFG0_PHY_TYPE_SEL;
+
writel(val, csid->base + CSID_CSI2_RX_CFG0);
val = CSI2_RX_CFG1_PACKET_ECC_CORRECTION_EN;
--
2.53.0
next prev parent reply other threads:[~2026-10-15 22:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 22:20 [PATCH RFC 0/4] phy: qcom-mipi-csi2: C-PHY for X1E80100 George Neacsu
2026-10-15 22:20 ` George Neacsu via B4 Relay
2026-10-15 22:20 ` George Neacsu via B4 Relay
2026-10-15 22:20 ` [PATCH RFC 1/4] phy: Add MIPI C-PHY mode and configuration options George Neacsu
2026-10-15 22:20 ` George Neacsu via B4 Relay
2026-10-15 22:20 ` George Neacsu via B4 Relay
2026-10-16 9:13 ` Bryan O'Donoghue
2026-10-16 9:13 ` Bryan O'Donoghue
2026-10-16 9:24 ` Loic Poulain
2026-10-16 9:24 ` Loic Poulain
2026-10-15 22:20 ` [PATCH RFC 2/4] phy: qcom-mipi-csi2: Add C-PHY support for X1E80100 George Neacsu
2026-10-15 22:20 ` George Neacsu via B4 Relay
2026-10-15 22:20 ` George Neacsu via B4 Relay
2026-10-16 9:29 ` Bryan O'Donoghue
2026-10-16 9:29 ` Bryan O'Donoghue
2026-10-16 10:06 ` George Neacsu
2026-10-16 10:06 ` George Neacsu
2026-10-16 10:12 ` Bryan O'Donoghue
2026-10-16 10:12 ` Bryan O'Donoghue
2026-10-16 9:59 ` Nihal Kumar Gupta
2026-10-16 9:59 ` Nihal Kumar Gupta
2026-10-16 10:06 ` George Neacsu
2026-10-16 10:06 ` George Neacsu
2026-10-16 10:23 ` Konrad Dybcio
2026-10-16 10:23 ` Konrad Dybcio
2026-10-15 22:20 ` George Neacsu [this message]
2026-10-15 22:20 ` [PATCH RFC 3/4] media: qcom: camss: csid-680: Select C-PHY in the receiver George Neacsu via B4 Relay
2026-10-15 22:20 ` George Neacsu via B4 Relay
2026-10-16 7:50 ` Loic Poulain
2026-10-16 7:50 ` Loic Poulain
2026-10-15 22:20 ` [PATCH RFC 4/4] media: qcom: camss: Configure C-PHY through the PHY API George Neacsu
2026-10-15 22:20 ` George Neacsu via B4 Relay
2026-10-15 22:20 ` George Neacsu via B4 Relay
2026-10-16 7:56 ` Loic Poulain
2026-10-16 7:56 ` Loic Poulain
2026-10-16 8:59 ` Bryan O'Donoghue
2026-10-16 8:59 ` Bryan O'Donoghue
2026-10-16 9:09 ` Bryan O'Donoghue
2026-10-16 9:09 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015-x1e-cphy-rfc-v1-3-1f3fa9af940a@gmail.com \
--to=geocausa@gmail.com \
--cc=bod@kernel.org \
--cc=david@ixit.cz \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.