Re: [PATCH v5 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345

[Rob Herring <robh@kernel.org>]

On Sun, Oct 11, 2026 at 05:37:21PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt-bindings: architecture-specific header included in yaml example
> --
> 
> commit 8b45bf401f436a6e8330c0e4539c0d77e9e73400
> Author: Aleksandrs Vinarskis <alex@vinarskis.com>
> 
> dt-bindings: platform: introduce EC for Dell XPS 13 9345
> 
> Add bindings for the Embedded Controller in the Dell XPS 13 9345. It defines
> properties for thermal and power management over multiple i2c busses.
> 
> > diff --git a/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
> > new file mode 100644
> > index 0000000000000..3485117b505cc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
> 
> [ ... ]
> 
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    #include <arm64/qcom/qcom-adc5-gen3.h>
> 
> [Severity: Low]
> Does this example include an architecture-specific header? Including headers
> outside of include/dt-bindings/ breaks dt-binding schema portability rules.

Yeah, please don't use arch headers in examples.

Rob