drivers/pinctrl/nuvoton/pinctrl-ma35.c:756 ma35_pinconf_get_drive_strength() warn: subtract is higher precedence than shift

drivers/pinctrl/nuvoton/pinctrl-ma35.c:756 ma35_pinconf_get_drive_strength() warn: subtract is higher precedence than shift

[kernel test robot]

Unfiltered warning: this smatch report is sent as-is and has not been
reviewed for false positives, so please treat it with due skepticism.

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Geert Uytterhoeven <geert+renesas@glider.be>
CC: "Yury Norov (NVIDIA)" <yury.norov@gmail.com>
CC: Linus Walleij <linus.walleij@linaro.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0fcb05b72344f40806cbe810de8872f1698bf053
commit: bb0e7fda87753a973cb4a86c22905b1177f00d4e pinctrl: ma35: Convert to common field_{get,prep}() helpers
date:   11 months ago
:::::: branch date: 10 hours ago
:::::: commit date: 11 months ago
config: m68k-randconfig-r2201-20261014 (https://download.01.org/0day-ci/archive/20261015/202610150337.EgF3D8xd-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: bb0e7fda8775 ("pinctrl: ma35: Convert to common field_{get,prep}() helpers")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202610150337.EgF3D8xd-lkp@intel.com/

New smatch warnings:
drivers/pinctrl/nuvoton/pinctrl-ma35.c:756 ma35_pinconf_get_drive_strength() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:756 ma35_pinconf_get_drive_strength() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:756 ma35_pinconf_get_drive_strength() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:756 ma35_pinconf_get_drive_strength() warn: subtract is higher precedence than shift

Old smatch warnings:
drivers/pinctrl/nuvoton/pinctrl-ma35.c:316 ma35_gpio_get_mode() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:316 ma35_gpio_get_mode() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:316 ma35_gpio_get_mode() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:316 ma35_gpio_get_mode() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:674 ma35_pinconf_get_pull() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:674 ma35_pinconf_get_pull() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:674 ma35_pinconf_get_pull() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:674 ma35_pinconf_get_pull() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:850 ma35_pinconf_get_slew_rate() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:850 ma35_pinconf_get_slew_rate() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:850 ma35_pinconf_get_slew_rate() warn: subtract is higher precedence than shift
drivers/pinctrl/nuvoton/pinctrl-ma35.c:850 ma35_pinconf_get_slew_rate() warn: subtract is higher precedence than shift

vim +756 drivers/pinctrl/nuvoton/pinctrl-ma35.c

f805e356313bbc Jacky Huang 2024-05-21  744  
f805e356313bbc Jacky Huang 2024-05-21  745  static int ma35_pinconf_get_drive_strength(struct ma35_pinctrl *npctl, unsigned int pin,
f805e356313bbc Jacky Huang 2024-05-21  746  					   u32 *strength)
f805e356313bbc Jacky Huang 2024-05-21  747  {
f805e356313bbc Jacky Huang 2024-05-21  748  	unsigned int port, group_num;
f805e356313bbc Jacky Huang 2024-05-21  749  	void __iomem *base;
f805e356313bbc Jacky Huang 2024-05-21  750  	u32 regval, ds_val;
f805e356313bbc Jacky Huang 2024-05-21  751  
f805e356313bbc Jacky Huang 2024-05-21  752  	ma35_gpio_cla_port(pin, &group_num, &port);
f805e356313bbc Jacky Huang 2024-05-21  753  	base = npctl->ctrl->pin_banks[group_num].reg_base;
f805e356313bbc Jacky Huang 2024-05-21  754  
f805e356313bbc Jacky Huang 2024-05-21  755  	regval = readl(base + MA35_GP_DS_REG(port));
f805e356313bbc Jacky Huang 2024-05-21 @756  	ds_val = field_get(MA35_GP_DS_MASK(port), regval);
f805e356313bbc Jacky Huang 2024-05-21  757  
f805e356313bbc Jacky Huang 2024-05-21  758  	if (ma35_pinconf_get_power_source(npctl, pin) == MVOLT_1800)
f805e356313bbc Jacky Huang 2024-05-21  759  		*strength = ds_1800mv_tbl[ds_val];
f805e356313bbc Jacky Huang 2024-05-21  760  	else
f805e356313bbc Jacky Huang 2024-05-21  761  		*strength = ds_3300mv_tbl[ds_val];
f805e356313bbc Jacky Huang 2024-05-21  762  
f805e356313bbc Jacky Huang 2024-05-21  763  	return 0;
f805e356313bbc Jacky Huang 2024-05-21  764  }
f805e356313bbc Jacky Huang 2024-05-21  765  

:::::: The code at line 756 was first introduced by commit
:::::: f805e356313bbcafef48808c14eb9ce7f4ff2560 pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver

:::::: TO: Jacky Huang <ychuang3@nuvoton.com>
:::::: CC: Linus Walleij <linus.walleij@linaro.org>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki