* [PATCH] hwrng: cctrng - fix destination offset in cctrng_read()
@ 2026-10-15 10:39 Thorsten Blum
0 siblings, 0 replies; only message in thread
From: Thorsten Blum @ 2026-10-15 10:39 UTC (permalink / raw)
To: Hadar Gat, Olivia Mackall, Herbert Xu
Cc: Thorsten Blum, linux-crypto, linux-kernel
cctrng_read() copies random data in two steps when a read wraps around
the end of the circular buffer.
Use the correct destination offset for the second copy instead of
overwriting the start of the destination buffer.
Fixes: a583ed310bb6 ("hwrng: cctrng - introduce Arm CryptoCell driver")
Cc: stable@vger.kernel.org
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
drivers/char/hw_random/cctrng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/cctrng.c b/drivers/char/hw_random/cctrng.c
index a6925211c3b5..e070581237e5 100644
--- a/drivers/char/hw_random/cctrng.c
+++ b/drivers/char/hw_random/cctrng.c
@@ -237,7 +237,7 @@ static int cctrng_read(struct hwrng *rng, void *data, size_t max, bool wait)
cnt_w = CIRC_CNT(drvdata->circ.head,
drvdata->circ.tail, CCTRNG_DATA_BUF_WORDS);
size = min((cnt_w<<2), left);
- memcpy(data, &(buf[drvdata->circ.tail]), size);
+ memcpy(data + copied, &buf[drvdata->circ.tail], size);
copied += size;
circ_idx_inc(&drvdata->circ.tail, size);
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-15 10:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-15 10:39 [PATCH] hwrng: cctrng - fix destination offset in cctrng_read() Thorsten Blum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.