From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 1/8] seccomp: really fix blocking of setns/execveat/unshare
Date: Fri, 16 Oct 2026 10:43:41 +0100 [thread overview]
Message-ID: <20261016094348.2616374-2-berrange@redhat.com> (raw)
In-Reply-To: <20261016094348.2616374-1-berrange@redhat.com>
The previous fix for setns/execveat/unshare mistakenly copy and
pasted the clone_args filter, which is inappropriate for these
syscalls and had the effect of weakening the seccomp filter.
Fixes: f33fb19cab (seccomp: fix blocking of setns/execveat/unshare)
Fixes: https://gitlab.com/qemu-project/qemu/-/work_items/4671
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
system/qemu-seccomp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/system/qemu-seccomp.c b/system/qemu-seccomp.c
index 3889d48b4f2..cd2c1b0b747 100644
--- a/system/qemu-seccomp.c
+++ b/system/qemu-seccomp.c
@@ -250,12 +250,12 @@ static const struct QemuSeccompSyscall denylist[] = {
#endif
#ifdef __SNR_execveat
{ SCMP_SYS(execveat), QEMU_SECCOMP_SET_SPAWN,
- ARRAY_SIZE(clone_arg_none), clone_arg_none, SCMP_ACT_ERRNO(EPERM) },
+ 0, NULL, SCMP_ACT_ERRNO(EPERM) },
#endif
{ SCMP_SYS(setns), QEMU_SECCOMP_SET_SPAWN,
- ARRAY_SIZE(clone_arg_none), clone_arg_none, SCMP_ACT_ERRNO(EPERM) },
+ 0, NULL, SCMP_ACT_ERRNO(EPERM) },
{ SCMP_SYS(unshare), QEMU_SECCOMP_SET_SPAWN,
- ARRAY_SIZE(clone_arg_none), clone_arg_none, SCMP_ACT_ERRNO(EPERM) },
+ 0, NULL, SCMP_ACT_ERRNO(EPERM) },
/* resource control */
{ SCMP_SYS(setpriority), QEMU_SECCOMP_SET_RESOURCECTL,
0, NULL, SCMP_ACT_ERRNO(EPERM) },
--
2.56.0
next prev parent reply other threads:[~2026-10-16 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 9:43 [PULL 0/8] Misc fixes patches Daniel P. Berrangé
2026-10-16 9:43 ` Daniel P. Berrangé [this message]
2026-10-16 9:43 ` [PULL 2/8] seccomp: drop redundant match for clone() flags == 0 Daniel P. Berrangé
2026-10-16 9:43 ` [PULL 3/8] qtest: fail fast when QEMU terminates early Daniel P. Berrangé
2026-10-16 9:43 ` [PULL 4/8] qom: deprecate use of instance level properties Daniel P. Berrangé
2026-10-16 9:43 ` [PULL 5/8] Revert "migration: activate TLS thread safety workaround" Daniel P. Berrangé
2026-10-16 9:43 ` [PULL 6/8] Revert "io: add support for activating " Daniel P. Berrangé
2026-10-16 9:43 ` [PULL 7/8] Revert "crypto: add tracing & warning about GNUTLS countermeasures" Daniel P. Berrangé
2026-10-16 9:43 ` [PULL 8/8] Revert "crypto: implement workaround for GNUTLS thread safety problems" Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016094348.2616374-2-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.