All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Peter Xu" <peterx@redhat.com>, "Fabiano Rosas" <farosas@suse.de>
Subject: [PULL 5/8] Revert "migration: activate TLS thread safety workaround"
Date: Fri, 16 Oct 2026 10:43:45 +0100	[thread overview]
Message-ID: <20261016094348.2616374-6-berrange@redhat.com> (raw)
In-Reply-To: <20261016094348.2616374-1-berrange@redhat.com>

This reverts commit eb3618e9e259ef93f5a1a76867fbccae540fcd61.

The workaround for the GNUTLS bug was not correct and it was
decided to rely on GNUTLS being patched by distros instead,
or users manually disabling use of the problematic ciphers.

Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 migration/tls.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/migration/tls.c b/migration/tls.c
index 89ba52de02a..b7914831923 100644
--- a/migration/tls.c
+++ b/migration/tls.c
@@ -88,10 +88,6 @@ void migration_tls_channel_process_incoming(QIOChannel *ioc, Error **errp)
 
     trace_migration_tls_incoming_handshake_start();
     qio_channel_set_name(QIO_CHANNEL(tioc), "migration-tls-incoming");
-    if (migrate_postcopy_ram() || migrate_return_path()) {
-        qio_channel_set_feature(QIO_CHANNEL(tioc),
-                                QIO_CHANNEL_FEATURE_CONCURRENT_IO);
-    }
     qio_channel_tls_handshake(tioc,
                               migration_tls_incoming_handshake,
                               NULL,
@@ -142,11 +138,6 @@ void migration_tls_channel_connect(MigrationState *s, QIOChannel *ioc,
 
     trace_migration_tls_outgoing_handshake_start();
     qio_channel_set_name(QIO_CHANNEL(tioc), "migration-tls-outgoing");
-
-    if (migrate_postcopy_ram() || migrate_return_path()) {
-        qio_channel_set_feature(QIO_CHANNEL(tioc),
-                                QIO_CHANNEL_FEATURE_CONCURRENT_IO);
-    }
     qio_channel_tls_handshake(tioc,
                               migration_tls_outgoing_handshake,
                               s,
-- 
2.56.0



  parent reply	other threads:[~2026-10-16  9:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16  9:43 [PULL 0/8] Misc fixes patches Daniel P. Berrangé
2026-10-16  9:43 ` [PULL 1/8] seccomp: really fix blocking of setns/execveat/unshare Daniel P. Berrangé
2026-10-16  9:43 ` [PULL 2/8] seccomp: drop redundant match for clone() flags == 0 Daniel P. Berrangé
2026-10-16  9:43 ` [PULL 3/8] qtest: fail fast when QEMU terminates early Daniel P. Berrangé
2026-10-16  9:43 ` [PULL 4/8] qom: deprecate use of instance level properties Daniel P. Berrangé
2026-10-16  9:43 ` Daniel P. Berrangé [this message]
2026-10-16  9:43 ` [PULL 6/8] Revert "io: add support for activating TLS thread safety workaround" Daniel P. Berrangé
2026-10-16  9:43 ` [PULL 7/8] Revert "crypto: add tracing & warning about GNUTLS countermeasures" Daniel P. Berrangé
2026-10-16  9:43 ` [PULL 8/8] Revert "crypto: implement workaround for GNUTLS thread safety problems" Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016094348.2616374-6-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=farosas@suse.de \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.