From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [RFC net-next v2 2/5] selftests: net: py: add metric policy output
Date: Fri, 16 Oct 2026 09:59:20 -0700 [thread overview]
Message-ID: <20261016095920.5723689f@kernel.org> (raw)
In-Reply-To: <20261005201115.2690830-3-sdf@fomichev.me>
On Mon, 5 Oct 2026 13:11:11 -0700 Stanislav Fomichev wrote:
> + ksft_metric_policy("nic.rx.dropped", summarize="max",
> + transform="rate", display_range={"min": 0})
IMO we should not be mixing any of this into the test.
We can hard code some heuristics into UI to match on names and create
sensible defaults. Here this feels out of place.
I would have expected only what you have as "regression policy"
in here. And only a subset of that. Naively we want to know
- if the metric is an error metric or perf metric (error metric
must be at 0, perf metric has to be analyzed for expected perf)
- whether it's a badness or goodness metric to distinguish wins
from regressions
next prev parent reply other threads:[~2026-10-16 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 20:11 [RFC net-next v2 0/5] selftests: net: add performance metric reporting Stanislav Fomichev
2026-10-05 20:11 ` [RFC net-next v2 1/5] selftests: net: py: add timestamped metric output Stanislav Fomichev
2026-10-16 16:52 ` Jakub Kicinski
2026-10-05 20:11 ` [RFC net-next v2 2/5] selftests: net: py: add metric policy output Stanislav Fomichev
2026-10-16 16:59 ` Jakub Kicinski [this message]
2026-10-05 20:11 ` [RFC net-next v2 3/5] selftests: drv-net: add an iperf performance test Stanislav Fomichev
2026-10-16 17:03 ` Jakub Kicinski
2026-10-05 20:11 ` [RFC net-next v2 4/5] selftests: drv-net: add a kperf runner Stanislav Fomichev
2026-10-16 17:05 ` Jakub Kicinski
2026-10-05 20:11 ` [RFC net-next v2 5/5] selftests: drv-net: measure devmem performance with kperf Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016095920.5723689f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.