Re: [PATCH v3 3/9] stop_machine: Introduce stop_machine_nmi_cpuslocked()

Re: [PATCH v3 3/9] stop_machine: Introduce stop_machine_nmi_cpuslocked()

[kernel test robot]

Hi Chang,

kernel test robot noticed the following build errors:

[auto build test ERROR on 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907]

url:    https://github.com/intel-lab-lkp/linux/commits/Chang-S-Bae/stop_machine-Refactor-multi-CPU-stop-glue-code/20261015-211418
base:   24a19b953e2a3d0ea5a8c4951a0ab8f32720c907
patch link:    https://lore.kernel.org/r/20261015211426.49114-4-chang.seok.bae%40intel.com
patch subject: [PATCH v3 3/9] stop_machine: Introduce stop_machine_nmi_cpuslocked()
config: i386-randconfig-1013-20261016 (https://download.01.org/0day-ci/archive/20261016/202610161559.cSgd4JA0-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.4.0-5) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261016/202610161559.cSgd4JA0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610161559.cSgd4JA0-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from kernel/sched/sched.h:63,
                    from kernel/sched/rq-offsets.c:5:
>> include/linux/stop_machine.h:226:74: error: unknown type name 'conststruct'; did you mean 'const_true'?
     226 | stop_machine_nmi_cpulocked(cpu_stop_nmisafe_fn_t nmisafe_fn, void *data, conststruct cpumask *cpus)
         |                                                                          ^~~~~~~~~~~
         |                                                                          const_true
   make[3]: *** [scripts/Makefile.build:185: kernel/sched/rq-offsets.s] Error 1 shuffle=3873254352
   make[3]: Target 'prepare' not remade because of errors.
   make[2]: *** [Makefile:1425: prepare0] Error 2 shuffle=3873254352
   make[2]: Target 'prepare' not remade because of errors.
   make[1]: *** [Makefile:248: __sub-make] Error 2 shuffle=3873254352
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:248: __sub-make] Error 2 shuffle=3873254352
   make: Target 'prepare' not remade because of errors.


vim +226 include/linux/stop_machine.h

   200	
   201	/**
   202	 * stop_machine_nmi_cpuslocked() - Freeze CPUs and run a function in NMI context
   203	 *
   204	 * @nmisafe_fn:	The function to run
   205	 * @data:	The data pointer for @nmisafe_fn()
   206	 * @cpus:	The CPUs to run @nmisafe_fn() on (NULL = one unspecified online CPU)
   207	 *
   208	 * Description: This stop_machine() variant runs @nmisafe_fn() from NMI context
   209	 * to prevent preemption by other NMIs. The callback must be built with noinstr.
   210	 * Other than that, the semantics match stop_machine_cpuslocked().
   211	 *
   212	 * Context: Must be called from within a cpus_read_lock() protected region.
   213	 * Avoid nested calls to cpus_read_lock().
   214	 *
   215	 * Return: 0 if all invocations of @nmisafe_fn return zero, -ENOMEM if cpumask
   216	 * allocation fails, -EINVAL if not initialized yet or any target CPU failed to
   217	 * receive NMI. Otherwise, the value returned by an arbitrarily chosen member of
   218	 * the set of calls to @nmisafe_fn that returned non-zero.
   219	 */
   220	int stop_machine_nmi_cpuslocked(cpu_stop_nmisafe_fn_t nmisafe_fn, void *data,
   221					const struct cpumask *cpus);
   222	
   223	#else
   224	static inline bool stop_machine_nmi_handler(void) { return false; }
   225	static inline int
 > 226	stop_machine_nmi_cpulocked(cpu_stop_nmisafe_fn_t nmisafe_fn, void *data, conststruct cpumask *cpus)
   227	{
   228		return 0;
   229	}
   230	#endif /* CONFIG_STOP_MACHINE_NMI */
   231	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki