[android-common:mirror-chromeos-5.10-arcvm 0/7] drivers/cpufreq/goldfish_cpufreq_stats.c:28:35: warning: integer literal is too large to be represented in type 'long', interpreting as 'unsigned long' per C89; this literal will have type 'long long' in C99 onwards

[android-common:mirror-chromeos-5.10-arcvm 0/7] drivers/cpufreq/goldfish_cpufreq_stats.c:28:35: warning: integer literal is too large to be represented in type 'long', interpreting as 'unsigned long' per C89; this literal will have type 'long long' in C99 onwards

[kernel test robot]

Hi Weilun,

FYI, the error/warning still remains.

tree:   https://android.googlesource.com/kernel/common mirror-chromeos-5.10-arcvm
head:   4e4377cd369feab676638318ab082efbd0d315eb
commit: a3f6baa6885122bc9b7f8ed273fd789a5f52fac3 [0/7] ANDROID: goldfish_cpufreq: Add goldfish cpufreq stats driver
config: i386-randconfig-2301-20261017 (https://download.01.org/0day-ci/archive/20261017/202610170342.VRbxJ8Ne-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 8a679464f19c426ef76aad9f4587b703dd3e584d)
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261017/202610170342.VRbxJ8Ne-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610170342.VRbxJ8Ne-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/cpufreq/goldfish_cpufreq_stats.c:28:35: warning: integer literal is too large to be represented in type 'long', interpreting as 'unsigned long' per C89; this literal will have type 'long long' in C99 onwards [-Wc99-compat]
      28 |         len = sprintf(buf, "%lu %llu\n", 3000000000, ++fake_time);
         |                                          ^
>> drivers/cpufreq/goldfish_cpufreq_stats.c:56:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
      56 |         int ret;
         |             ^
   2 warnings generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_VMASTER
   Depends on [n]: SOUND [=n] && !UML && SND [=n]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y]
   WARNING: unmet direct dependencies detected for SND_JACK
   Depends on [n]: SOUND [=n] && !UML && SND [=n]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y]
   WARNING: unmet direct dependencies detected for SND_JACK_INPUT_DEV
   Depends on [n]: SOUND [=n] && !UML && SND [=n] && SND_JACK [=y]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y]
   WARNING: unmet direct dependencies detected for SND_PCM_ELD
   Depends on [n]: SOUND [=n] && !UML && SND [=n]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y]
   WARNING: unmet direct dependencies detected for SND_INTEL_NHLT
   Depends on [n]: SOUND [=n] && !UML && SND [=n]
   Selected by [y]:
   - GKI_HIDDEN_SND_CONFIGS [=y] && ACPI [=y]
   WARNING: unmet direct dependencies detected for BALLOON_COMPACTION
   Depends on [n]: COMPACTION [=n] && MEMORY_BALLOON [=y]
   Selected by [y]:
   - GKI_HIDDEN_MM_CONFIGS [=y]


vim +28 drivers/cpufreq/goldfish_cpufreq_stats.c

    22	
    23	static ssize_t time_in_state_show(struct kobject *kobj,
    24			struct kobj_attribute *attr, char *buf)
    25	{
    26		ssize_t len = 0;
    27	
  > 28		len = sprintf(buf, "%lu %llu\n", 3000000000, ++fake_time);
    29		return len;
    30	}
    31	
    32	static struct kobj_attribute time_in_state =
    33		__ATTR_RO_MODE(time_in_state, 0444);
    34	
    35	static struct attribute *cpufreq_stats_attrs[] = {
    36		&time_in_state.attr,
    37		NULL
    38	};
    39	static struct attribute_group stats_attr_group = {
    40		.attrs = cpufreq_stats_attrs,
    41		.name = "stats"
    42	};
    43	
    44	static void cpufreq_stats_free(unsigned int cpu)
    45	{
    46		struct device *dev = get_cpu_device(cpu);
    47		struct kobject **kobj = &per_cpu(cpufreq_kobj, cpu);
    48	
    49		sysfs_remove_group(&dev->kobj, &stats_attr_group);
    50		kobject_put(*kobj);
    51		*kobj=NULL;
    52	}
    53	
    54	static void cpufreq_stats_create(unsigned int cpu)
    55	{
  > 56		int ret;
    57		struct device *dev = get_cpu_device(cpu);
    58		struct kobject **kobj = &per_cpu(cpufreq_kobj, cpu);
    59	
    60		*kobj = kobject_create_and_add("cpufreq", &dev->kobj);
    61		ret = sysfs_create_group(*kobj, &stats_attr_group);
    62	}
    63	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki