From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-comment <virtio-comment@lists.linux.dev>,
Cornelia Huck <cohuck@redhat.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Linlin Zhang <linlin.zhang@oss.qualcomm.com>,
neeraj.soni@oss.qualcomm.com,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 0/6] transport-mmio: Support administration virtqueues
Date: Sat, 17 Oct 2026 09:22:47 -0400 [thread overview]
Message-ID: <20261017092211-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20261017114556.1701355-1-parav@nvidia.com>
On Sat, Oct 17, 2026 at 02:45:50PM +0300, Parav Pandit wrote:
> Administration virtqueues and group administration commands are
> defined in a transport independent way, but only the PCI transport
> describes how a device exposes administration virtqueues. For
> MMIO, VIRTIO_F_ADMIN_VQ is listed as reserved for future use.
>
> Group administration commands for the Self group type, such as device
> capabilities and device resource objects, are equally useful for
> memory mapped virtio devices. This series adds administration
> virtqueue support to the MMIO transport. Only the Self group type is
> applicable to MMIO.
>
> Two read-only registers are added in the unused range between
> QueueReset and ConfigGeneration, mirroring the PCI admin_queue_index
> and admin_queue_num fields:
>
> AdminQueueIndex (0x0c4) - index of the first administration virtqueue
> AdminQueueNum (0x0c8) - number of administration virtqueues
>
> Their presence is indicated by VIRTIO_F_ADMIN_VQ, so no new MMIO
> Version is required and existing devices and drivers are unaffected.
> Administration virtqueues are configured, enabled, reset and notified
> like any other virtqueue.
>
> Patch summary:
> 1. Introduce administration virtqueues for the MMIO transport, limited
> to the Self group type.
> 2. Add the AdminQueueIndex and AdminQueueNum registers.
> 3. Remove VIRTIO_F_ADMIN_VQ from the MMIO reserved features and update
> the feature bit description.
> 4. Reference the transport specific discovery from the generic
> administration virtqueues section.
> 5. Add the missing PCI driver requirement for admin_queue_index and
> admin_queue_num, which the spec already describes as valid only if
> VIRTIO_F_ADMIN_VQ has been negotiated.
> 6. Add MMIO device and driver requirements and conformance references.
Thanks, will review. We also need ccw please.
> Parav Pandit (6):
> transport-mmio: Introduce administration virtqueues
> transport-mmio: Add administration virtqueue registers
> transport-mmio: Remove ADMIN_VQ from features reserved for future use
> admin: Reference transport specific administration virtqueue discovery
> transport-pci: Add missing driver requirement for admin queue fields
> transport-mmio: Add administration virtqueue requirements
>
> admin.tex | 6 ++-
> conformance.tex | 2 +
> content.tex | 3 ++
> transport-mmio.tex | 96 ++++++++++++++++++++++++++++++++++++++++------
> transport-pci.tex | 3 ++
> 5 files changed, 97 insertions(+), 13 deletions(-)
>
> --
> 2.43.0
prev parent reply other threads:[~2026-10-17 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 11:45 [PATCH 0/6] transport-mmio: Support administration virtqueues Parav Pandit
2026-10-17 11:45 ` [PATCH 1/6] transport-mmio: Introduce " Parav Pandit
2026-10-17 11:45 ` [PATCH 2/6] transport-mmio: Add administration virtqueue registers Parav Pandit
2026-10-17 11:45 ` [PATCH 3/6] transport-mmio: Remove ADMIN_VQ from features reserved for future use Parav Pandit
2026-10-17 11:45 ` [PATCH 4/6] admin: Reference transport specific administration virtqueue discovery Parav Pandit
2026-10-17 11:45 ` [PATCH 5/6] transport-pci: Add missing driver requirement for admin queue fields Parav Pandit
2026-10-17 11:45 ` [PATCH 6/6] transport-mmio: Add administration virtqueue requirements Parav Pandit
2026-10-17 13:22 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261017092211-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=linlin.zhang@oss.qualcomm.com \
--cc=mgurtovoy@nvidia.com \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=parav@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.