From: Parav Pandit <parav@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
virtio-comment <virtio-comment@lists.linux.dev>,
Cornelia Huck <cohuck@redhat.com>
Cc: Max Gurtovoy <mgurtovoy@nvidia.com>,
Linlin Zhang <linlin.zhang@oss.qualcomm.com>,
<neeraj.soni@oss.qualcomm.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
Parav Pandit <parav@nvidia.com>
Subject: [PATCH 5/6] transport-pci: Add missing driver requirement for admin queue fields
Date: Sat, 17 Oct 2026 14:45:55 +0300 [thread overview]
Message-ID: <20261017114556.1701355-6-parav@nvidia.com> (raw)
In-Reply-To: <20261017114556.1701355-1-parav@nvidia.com>
The description of admin_queue_index and admin_queue_num in the common
configuration structure already states that these fields are valid
only if VIRTIO_F_ADMIN_VQ has been negotiated. However, the
corresponding driver requirement was missing from the normative
statements.
Add this missing requirement: the driver must not access
admin_queue_index and admin_queue_num unless VIRTIO_F_ADMIN_VQ has
been negotiated. This does not change the existing behaviour; it only
captures what was already part of the specification as a normative
statement, and aligns the PCI transport with the equivalent MMIO
transport requirement for AdminQueueIndex and AdminQueueNum.
Fixes: 677aeaebf6a7 ("pci: add admin vq registers to virtio over pci")
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
transport-pci.tex | 3 +++
1 file changed, 3 insertions(+)
diff --git a/transport-pci.tex b/transport-pci.tex
index 95b08b8..0cd9eab 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -523,6 +523,9 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
were used before the queue reset.
(see \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}).
+The driver MUST NOT access \field{admin_queue_index} and
+\field{admin_queue_num} unless VIRTIO_F_ADMIN_VQ has been negotiated.
+
If VIRTIO_F_ADMIN_VQ has been negotiated, and if the driver
configures any administration virtqueues, the driver MUST
configure the administration virtqueues using the index
--
2.43.0
next prev parent reply other threads:[~2026-10-17 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 11:45 [PATCH 0/6] transport-mmio: Support administration virtqueues Parav Pandit
2026-10-17 11:45 ` [PATCH 1/6] transport-mmio: Introduce " Parav Pandit
2026-10-17 11:45 ` [PATCH 2/6] transport-mmio: Add administration virtqueue registers Parav Pandit
2026-10-17 11:45 ` [PATCH 3/6] transport-mmio: Remove ADMIN_VQ from features reserved for future use Parav Pandit
2026-10-17 11:45 ` [PATCH 4/6] admin: Reference transport specific administration virtqueue discovery Parav Pandit
2026-10-17 11:45 ` Parav Pandit [this message]
2026-10-17 11:45 ` [PATCH 6/6] transport-mmio: Add administration virtqueue requirements Parav Pandit
2026-10-17 13:22 ` [PATCH 0/6] transport-mmio: Support administration virtqueues Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261017114556.1701355-6-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=linlin.zhang@oss.qualcomm.com \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.