From: Carlo Szelinsky <github@szelinsky.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Kory Maincent <kory.maincent@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@kernel.org>
Cc: Corey Leavitt <corey@leavitt.info>,
Jonas Jelonek <jelonek.jonas@gmail.com>,
Simon Horman <horms@kernel.org>,
Aleksander Jan Bajkowski <olek2@wp.pl>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
netdev-bot+sashiko@kernel.org, sashiko-bot@kernel.org,
sashiko-reviews@lists.linux.dev, devicetree@vger.kernel.org,
Kyle Swenson <kyle.swenson@est.tech>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v8 5/7] net: pse-pd: check the PI vpwr supply before registering the controller
Date: Sun, 18 Oct 2026 00:47:15 +0200 [thread overview]
Message-ID: <20261017224715.1527426-1-github@szelinsky.de> (raw)
In-Reply-To: <179122160924.434549.13478805521146010203@kernel.org>
On Mon, 05 Oct 2026 17:33:29 +0000, netdev-bot+sashiko@kernel.org wrote:
> [Severity: Low]
> This isn't a bug, but the commit message only describes the future
> phylib notifier case. It leaves out a change that applies today.
...
> Could the commit message mention this?
Agreed. The v9 commit message says so: a PI whose provider appears late
now gets its power domain, which pse_register_pw_ds() used to skip.
> [Severity: Medium]
> Can this check pass while the PI regulator registration still defers its
> supply?
Yes. The check does not copy the regulator core exactly: a provider that
is registered, but whose device is not bound yet, still passes. That PI
then gets no power domain, and the v9 commit message says so. Closing
this fully would need an event from the regulator core when the provider
binds, which does not exist today. The window is small: the provider has
to be registered but not yet bound while the PSE driver probes.
> [Severity: Medium]
> Does this new -EPROBE_DEFER exit leak the pd692x0 power budget claimed on
> the vmain regulator?
Yes. That is an older bug in pd692x0: it already leaks the budget on any
probe failure after setup_pi_matrix(). Its fix goes to net: the budget
is now released through devres.
Carlo
next prev parent reply other threads:[~2026-10-17 22:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 16:42 [PATCH net-next v8 0/7] net: pse-pd: decouple controller lookup from MDIO probe Carlo Szelinsky
2026-10-04 16:42 ` [PATCH net-next v8 1/7] net: pse-pd: add notifier chain for controller lifecycle events Carlo Szelinsky
2026-10-13 9:39 ` Kory Maincent
2026-10-04 16:42 ` [PATCH net-next v8 2/7] net: pse-pd: fire lifecycle events on controller register/unregister Carlo Szelinsky
2026-10-05 17:33 ` netdev-bot+sashiko
2026-10-17 22:45 ` Carlo Szelinsky
2026-10-13 9:39 ` Kory Maincent
2026-10-04 16:42 ` [PATCH net-next v8 3/7] net: pse-pd: unwind allocations when controller registration fails Carlo Szelinsky
2026-10-05 16:43 ` sashiko-bot
2026-10-17 22:47 ` Carlo Szelinsky
2026-10-05 17:33 ` netdev-bot+sashiko
2026-10-17 22:46 ` Carlo Szelinsky
2026-10-13 9:39 ` Kory Maincent
2026-10-04 16:42 ` [PATCH net-next v8 4/7] net: pse-pd: si3474: use dev_err_probe() for controller registration Carlo Szelinsky
2026-10-04 16:42 ` [PATCH net-next v8 5/7] net: pse-pd: check the PI vpwr supply before registering the controller Carlo Szelinsky
2026-10-05 17:33 ` netdev-bot+sashiko
2026-10-17 22:47 ` Carlo Szelinsky [this message]
2026-10-04 16:42 ` [PATCH net-next v8 6/7] of: property: do not let "pses" block a consumer's probe Carlo Szelinsky
2026-10-05 17:33 ` netdev-bot+sashiko
2026-10-17 22:47 ` Carlo Szelinsky
2026-10-04 16:42 ` [PATCH net-next v8 7/7] net: phy: own phydev->psec via PSE notifier and remove fwnode_mdio hook Carlo Szelinsky
2026-10-05 17:33 ` netdev-bot+sashiko
2026-10-17 22:47 ` Carlo Szelinsky
2026-10-13 7:40 ` [PATCH net-next v8 0/7] net: pse-pd: decouple controller lookup from MDIO probe Paolo Abeni
2026-10-13 8:39 ` Kory Maincent
2026-10-13 9:09 ` Carlo Szelinsky
2026-10-14 19:03 ` Kyle Swenson
2026-10-14 19:41 ` Oleksij Rempel
2026-10-17 22:47 ` Carlo Szelinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261017224715.1527426-1-github@szelinsky.de \
--to=github@szelinsky.de \
--cc=andrew+netdev@lunn.ch \
--cc=broonie@kernel.org \
--cc=corey@leavitt.info \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jelonek.jonas@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=kyle.swenson@est.tech \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olek2@wp.pl \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.