All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Titouan Christophe <titouan.christophe@mind.be>
Cc: ps.report@gmx.net, yann.morin@orange.com,
	thomas.petazzoni@bootlin.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 0/7] Update kconfig inrastructure to Linux 7.2.9
Date: Sun, 18 Oct 2026 19:31:37 +0200	[thread overview]
Message-ID: <20261018173137.GA383673@pevik> (raw)
In-Reply-To: <5a67d18f-24f5-4426-9a55-82bdef6f13f3@mind.be>

> Hello Petr,

> First of all, thank you for having looked into this series !

Yw, I wish I had more time for testing (hopefully I find some more time).
So far I checked only "make {defconfig,nconfig,menuconfig,help}".
Big thank you to do that update.

> On 16/10/26 23:29, Petr Vorel wrote:
> > Thank you! FYI Now rebasing to current master requires resolve another conflict due
> > 5177cf9c2f ("package/openssl: move libopenssl/libressl options out of the choice")
> > (Not difficult to solve, but if you rebase you make it easier for reviewers.)
> I rebased on top of latest master, resolving the conflict, and pushed to
> https://gitlab.com/essensium-mind/buildroot/-/commits/bump-kconfig

Thank you! Maybe once a while rebase and force push until finally merged?

> > Slightly problematic is that output/ format changed. Therefore
> > without 'rm -rf output' make config fails:

> > $ make defconfig
> > Config.in:23: can't open file "(BASE_DIR)/.br2-external.in.paths"
> > make[1]: *** [Makefile:1050: defconfig] Error 1
> > make: *** [Makefile:83: _all] Error 2

> > Obviously this part in Config.in is wrong:

> > # br2-external paths definitions
> > source "$(BASE_DIR)/.br2-external.in.paths"

> > bisecting shows the first bad commit
> > 121d3e6800 ("*/Config.in: use the new $(VAR) syntax")

> > With removing output directory first everything works.
> Actually, only output/build/buildroot-config needs to be removed:

I guess there is no way to avoid people bump into this problem.
Maybe at least to document the need of removing the file in the git commit
message.

>     $ make defconfig
>     Config.in:23: can't open file "(BASE_DIR)/.br2-external.in.paths"
>     make: *** [Makefile:1050: defconfig] Error 1

>     $ rm -r output/build/buildroot-config
>     $ make defconfig
>     [...]
>     #
>     # configuration written to /home/titou/Code/buildroot/.config
>     #

> So there is probably some incorrect build dependency (kconfig source ->
> binaries).
> I will look into this.

Could be. Again, thank you for having a look.

And, if you have enough time and motivation, after this is merged, my personal
wish would be to speedup 'make help' (it takes 9 sec on my laptop, kernel's
target is much faster), but this is not due the update (an old problem).

> > $ rm -rf output/
> > $ make defconfig
> > ...

> > # No change to ...buildroot/.config


> There *are* some changes though !
> This is because of upstream commit aff11cd983 [1]. Before this series in


> Buildroot there was only the title of a menu in .config, now there is an end
> marker as well.
> See this example:

>      #
>      # Database
>     @@ -1829,6 +1855,7 @@
>      # sqlitecpp needs a toolchain w/ C++, threads, gcc >= 4.9
>      #
>      # BR2_PACKAGE_UNIXODBC is not set
>     +# end of Database

Yes, I noticed that during 'make defconfig' output comparison, done by aff11cd983 [1].

Kind regards,
Petr

> I checked that this is the only change in .config output:

>     diff -u .config.old .config | grep -E '^[+-]' | grep -v '# end of'
>     --- .config.old 2026-10-18 17:21:54.495007495 +0200
>     +++ .config 2026-10-18 17:44:13.970027594 +0200
>     -# Buildroot 2026.08-1042-g279f4b6237 Configuration
>     +# Buildroot 2026.08-1048-g55ffb69e12 Configuration


> Best regards,
> Titouan

> [1] aff11cd983 ("kconfig: Terminate menu blocks with a comment in the
> generated config")
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/kconfig?id=aff11cd983ec0850651ee9b1c2a88b33358cb2f2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-10-18 17:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10 15:11 [Buildroot] [PATCH 0/7] Update kconfig inrastructure to Linux 7.2.9 Titouan Christophe via buildroot
2026-10-10 15:11 ` [Buildroot] [PATCH 1/7] Makefile: always use a base config file for defconfig Titouan Christophe via buildroot
2026-10-16 21:30   ` Petr Vorel
2026-10-10 15:11 ` [Buildroot] [PATCH 2/7] */Config.in: use the new $(VAR) syntax Titouan Christophe via buildroot
2026-10-16 22:17   ` Petr Vorel
2026-10-18 14:06     ` Titouan Christophe via buildroot
2026-10-19 15:34       ` Petr Vorel
2026-10-10 15:11 ` [Buildroot] [PATCH 3/7] */Config.in: replace bool entries with prompt within all choices Titouan Christophe via buildroot
2026-10-16 22:25   ` Petr Vorel
2026-10-10 15:11 ` [Buildroot] [PATCH 5/7] package/openssl: move libopenssl/libressl options out of the choice Titouan Christophe via buildroot
2026-10-16 22:51   ` Petr Vorel
2026-10-10 15:11 ` [Buildroot] [PATCH 6/7] docs/manual: add migration notes for changes in the kconfig syntax Titouan Christophe via buildroot
2026-10-16 22:53   ` Petr Vorel
2026-10-10 15:11 ` [Buildroot] [PATCH 7/7] Makefile: add new target "yellowconfig" based on kconfiglib Titouan Christophe via buildroot
2026-10-16 21:44   ` Petr Vorel
2026-10-11 19:12 ` [Buildroot] [PATCH 0/7] Update kconfig inrastructure to Linux 7.2.9 Petr Vorel
2026-10-11 19:30   ` Titouan Christophe via buildroot
2026-10-16 21:29     ` Petr Vorel
2026-10-18 16:30       ` Titouan Christophe via buildroot
2026-10-18 17:31         ` Petr Vorel [this message]
     [not found] ` <20261010151121.876133-5-titouan.christophe@mind.be>
2026-10-16 22:47   ` [Buildroot] [PATCH 4/7] support/kconfig: update to kconfig from " Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261018173137.GA383673@pevik \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=ps.report@gmx.net \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=titouan.christophe@mind.be \
    --cc=yann.morin@orange.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.