All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] dt-bindings: iio: adc: add documentation for adi,ad7816
@ 2026-10-18 11:00 wrmfwv
  2026-10-18 15:39 ` Joshua Crofts
  0 siblings, 1 reply; 2+ messages in thread
From: wrmfwv @ 2026-10-18 11:00 UTC (permalink / raw)
  To: nuno.sa, jic23, robh
  Cc: Michael.Hennerich, dlechner, andy, krzk+dt, conor+dt, linux,
	linux-iio, devicetree, linux-kernel, Tenglong Guo, Sashiko AI

From: Tenglong Guo <admin@micronull.cn>

Add a YAML binding document for the AD7816 family of ADCs.
This fixes the checkpatch.pl warning about un-documented
DT compatible strings in the staging driver.

Reviewed-by: Sashiko AI <sashiko-bot@kernel.org>
Signed-off-by: Tenglong Guo <admin@micronull.cn>
---
 .../bindings/iio/adc/adi,ad7816.yaml          | 83 +++++++++++++++++++
 1 file changed, 83 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7816.yaml

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7816.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7816.yaml
new file mode 100644
index 000000000000..a969e046883a
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7816.yaml
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/adi,ad7816.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD7816/AD7817/AD7818 ADC
+
+maintainers:
+  - Tenglong Guo <admin@micronull.cn>
+
+description: |
+  The AD7816/AD7817/AD7818 are 10-bit ADCs with on-chip temperature sensors.
+  They use a SPI interface for communication.
+
+properties:
+  compatible:
+    enum:
+      - adi,ad7816
+      - adi,ad7817
+      - adi,ad7818
+
+  reg:
+    maxItems: 1
+
+  rdwr-gpios:
+    maxItems: 1
+    description: GPIO connected to the RD/WR pin.
+
+  convert-gpios:
+    maxItems: 1
+    description: GPIO connected to the CONVST pin.
+
+  busy-gpios:
+    maxItems: 1
+    description: GPIO connected to the BUSY pin. Required for AD7816 and AD7817.
+
+  interrupts:
+    maxItems: 1
+    description: Optional interrupt for over-temperature indication.
+
+required:
+  - compatible
+  - reg
+  - rdwr-gpios
+  - convert-gpios
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - adi,ad7816
+              - adi,ad7817
+    then:
+      required:
+        - busy-gpios
+    else:
+      properties:
+        busy-gpios: false
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        adc@0 {
+            compatible = "adi,ad7816";
+            reg = <0>;
+            rdwr-gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
+            convert-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
+            busy-gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>;
+            interrupts-extended = <&gpio0 4 IRQ_TYPE_LEVEL_LOW>;
+        };
+    };
+...
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] dt-bindings: iio: adc: add documentation for adi,ad7816
  2026-10-18 11:00 [PATCH v3] dt-bindings: iio: adc: add documentation for adi,ad7816 wrmfwv
@ 2026-10-18 15:39 ` Joshua Crofts
  0 siblings, 0 replies; 2+ messages in thread
From: Joshua Crofts @ 2026-10-18 15:39 UTC (permalink / raw)
  To: wrmfwv
  Cc: nuno.sa, jic23, robh, Michael.Hennerich, dlechner, andy, krzk+dt,
	conor+dt, linux, linux-iio, devicetree, linux-kernel,
	Tenglong Guo, Sashiko AI

On Sun, 18 Oct 2026 19:00:15 +0800
wrmfwv@163.com wrote:

> From: Tenglong Guo <admin@micronull.cn>
> 
> Add a YAML binding document for the AD7816 family of ADCs.
> This fixes the checkpatch.pl warning about un-documented
> DT compatible strings in the staging driver.
> 
> Reviewed-by: Sashiko AI <sashiko-bot@kernel.org>

No, an AI cannot be credited in any tag (except in Assisted-by
but it will be deprecated). The v2 review returned several
issues as well, so it's definitely not worth a Reviewed-by tag
either.

As for the binding, I've sent a patch removing the AD7816 from
the kernel [1].

[1] https://lore.kernel.org/all/20261006115119.1416-1-joshua.crofts1@gmail.com/

-- 
Kind regards,
Joshua Crofts

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-18 15:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-18 11:00 [PATCH v3] dt-bindings: iio: adc: add documentation for adi,ad7816 wrmfwv
2026-10-18 15:39 ` Joshua Crofts

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.