All of lore.kernel.org
 help / color / mirror / Atom feed
* [sailus-media-tree:media-ref 2/17] drivers/media/mc/mc-devnode.c:233:40: error: 'mdev' undeclared; did you mean 'cdev'?
@ 2026-10-18 13:35 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-10-18 13:35 UTC (permalink / raw)
  To: Sakari Ailus; +Cc: oe-kbuild-all, linux-media

tree:   git://linuxtv.org/sailus/media_tree.git media-ref
head:   cf47170584526b52366e936406ce2430b99a03a9
commit: 803515300f06fabf69ad489f3f1f8e5ab3f4717f [2/17] media: mc: Merge struct media_device back into struct media_devnode
config: arm-randconfig-1003-20261018 (https://download.01.org/0day-ci/archive/20261018/202610182143.lRvPL9ir-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261018/202610182143.lRvPL9ir-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610182143.lRvPL9ir-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/media/mc/mc-devnode.c: In function 'media_devnode_register':
>> drivers/media/mc/mc-devnode.c:233:40: error: 'mdev' undeclared (first use in this function); did you mean 'cdev'?
     233 |         dev_set_drvdata(&devnode->dev, mdev);
         |                                        ^~~~
         |                                        cdev
   drivers/media/mc/mc-devnode.c:233:40: note: each undeclared identifier is reported only once for each function it appears in
--
   In file included from include/linux/module.h:23,
                    from include/linux/device/driver.h:21,
                    from include/linux/device.h:32,
                    from include/linux/pci.h:38,
                    from drivers/media/mc/mc-device.c:19:
   drivers/media/mc/mc-device.c:31:31: error: expected ';' before 'int'
      31 | module_param(kaboom, unsigned int, 0077);
         |                               ^~~
   include/linux/moduleparam.h:163:23: note: in definition of macro 'module_param_named'
     163 |         param_check_##type(name, &(value));                                \
         |                       ^~~~
   drivers/media/mc/mc-device.c:31:1: note: in expansion of macro 'module_param'
      31 | module_param(kaboom, unsigned int, 0077);
         | ^~~~~~~~~~~~
   include/linux/moduleparam.h:163:32: error: expected ')' before ',' token
     163 |         param_check_##type(name, &(value));                                \
         |                                ^
   include/linux/moduleparam.h:140:9: note: in expansion of macro 'module_param_named'
     140 |         module_param_named(name, name, type, perm)
         |         ^~~~~~~~~~~~~~~~~~
   drivers/media/mc/mc-device.c:31:1: note: in expansion of macro 'module_param'
      31 | module_param(kaboom, unsigned int, 0077);
         | ^~~~~~~~~~~~
   include/linux/moduleparam.h:164:32: error: 'param_ops_unsigned' undeclared here (not in a function); did you mean 'param_ops_uint'?
     164 |         module_param_cb(name, &param_ops_##type, &value, perm);            \
         |                                ^~~~~~~~~~
   include/linux/moduleparam.h:305:46: note: in definition of macro '__module_param_call'
     305 |         = { __param_str_##name, THIS_MODULE, ops,                       \
         |                                              ^~~
   include/linux/moduleparam.h:164:9: note: in expansion of macro 'module_param_cb'
     164 |         module_param_cb(name, &param_ops_##type, &value, perm);            \
         |         ^~~~~~~~~~~~~~~
   include/linux/moduleparam.h:140:9: note: in expansion of macro 'module_param_named'
     140 |         module_param_named(name, name, type, perm)
         |         ^~~~~~~~~~~~~~~~~~
   drivers/media/mc/mc-device.c:31:1: note: in expansion of macro 'module_param'
      31 | module_param(kaboom, unsigned int, 0077);
         | ^~~~~~~~~~~~
   drivers/media/mc/mc-device.c:31:31: error: expected '}' before 'int'
      31 | module_param(kaboom, unsigned int, 0077);
         |                               ^~~
   include/linux/moduleparam.h:305:46: note: in definition of macro '__module_param_call'
     305 |         = { __param_str_##name, THIS_MODULE, ops,                       \
         |                                              ^~~
   include/linux/moduleparam.h:164:9: note: in expansion of macro 'module_param_cb'
     164 |         module_param_cb(name, &param_ops_##type, &value, perm);            \
         |         ^~~~~~~~~~~~~~~
   include/linux/moduleparam.h:140:9: note: in expansion of macro 'module_param_named'
     140 |         module_param_named(name, name, type, perm)
         |         ^~~~~~~~~~~~~~~~~~
   drivers/media/mc/mc-device.c:31:1: note: in expansion of macro 'module_param'
      31 | module_param(kaboom, unsigned int, 0077);
         | ^~~~~~~~~~~~
   include/linux/moduleparam.h:305:11: note: to match this '{'
     305 |         = { __param_str_##name, THIS_MODULE, ops,                       \
         |           ^
   include/linux/moduleparam.h:189:9: note: in expansion of macro '__module_param_call'
     189 |         __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
         |         ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:164:9: note: in expansion of macro 'module_param_cb'
     164 |         module_param_cb(name, &param_ops_##type, &value, perm);            \
         |         ^~~~~~~~~~~~~~~
   include/linux/moduleparam.h:140:9: note: in expansion of macro 'module_param_named'
     140 |         module_param_named(name, name, type, perm)
         |         ^~~~~~~~~~~~~~~~~~
   drivers/media/mc/mc-device.c:31:1: note: in expansion of macro 'module_param'
      31 | module_param(kaboom, unsigned int, 0077);
         | ^~~~~~~~~~~~
   drivers/media/mc/mc-device.c: In function '__media_device_register':
>> drivers/media/mc/mc-device.c:761:56: error: 'devnode' undeclared (first use in this function); did you mean 'd_inode'?
     761 |         mdev->media_dir = debugfs_create_dir(dev_name(&devnode->dev),
         |                                                        ^~~~~~~
         |                                                        d_inode
   drivers/media/mc/mc-device.c:761:56: note: each undeclared identifier is reported only once for each function it appears in


vim +233 drivers/media/mc/mc-devnode.c

cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  201  
803515300f06fab drivers/media/mc/mc-devnode.c Sakari Ailus          2016-06-18  202  int __must_check media_devnode_register(struct media_devnode *devnode,
85de721c46ba8ad drivers/media/media-devnode.c Sakari Ailus          2013-12-12  203  					struct module *owner)
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  204  {
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  205  	int minor;
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  206  	int ret;
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  207  
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  208  	/* Part 1: Find a free minor number */
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  209  	mutex_lock(&media_devnode_lock);
b5c7e7ec7d3418a drivers/media/mc/mc-devnode.c Yury Norov            2021-08-14  210  	minor = find_first_zero_bit(media_devnode_nums, MEDIA_NUM_DEVICES);
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  211  	if (minor == MEDIA_NUM_DEVICES) {
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  212  		mutex_unlock(&media_devnode_lock);
3c16b2b330e3339 drivers/media/media-devnode.c Sachin Kamat          2012-09-24  213  		pr_err("could not get a free minor\n");
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  214  		return -ENFILE;
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  215  	}
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  216  
8c89ddd536bbe97 drivers/media/media-devnode.c Laurent Pinchart      2011-05-30  217  	set_bit(minor, media_devnode_nums);
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  218  	mutex_unlock(&media_devnode_lock);
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  219  
163f1e93e995048 drivers/media/media-devnode.c Mauro Carvalho Chehab 2016-03-23  220  	devnode->minor = minor;
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  221  
803515300f06fab drivers/media/mc/mc-devnode.c Sakari Ailus          2016-06-18  222  	/* Part 2: Initialize the media and character devices */
803515300f06fab drivers/media/mc/mc-devnode.c Sakari Ailus          2016-06-18  223  	cdev_init(&devnode->cdev, &media_devnode_fops);
803515300f06fab drivers/media/mc/mc-devnode.c Sakari Ailus          2016-06-18  224  	devnode->cdev.owner = owner;
803515300f06fab drivers/media/mc/mc-devnode.c Sakari Ailus          2016-06-18  225  	kobject_set_name(&devnode->cdev.kobj, "media%d", devnode->minor);
803515300f06fab drivers/media/mc/mc-devnode.c Sakari Ailus          2016-06-18  226  
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  227  	devnode->dev.bus = &media_bus_type;
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  228  	devnode->dev.devt = MKDEV(MAJOR(media_dev_t), devnode->minor);
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  229  	devnode->dev.release = media_devnode_release;
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  230  	if (devnode->parent)
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  231  		devnode->dev.parent = devnode->parent;
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  232  	dev_set_name(&devnode->dev, "media%d", devnode->minor);
de9f0c2a1ce3d97 drivers/media/mc/mc-devnode.c Hans Verkuil          2025-11-28 @233  	dev_set_drvdata(&devnode->dev, mdev);
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  234  	device_initialize(&devnode->dev);
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  235  
803515300f06fab drivers/media/mc/mc-devnode.c Sakari Ailus          2016-06-18  236  	/* Part 3: Add the media and character devices */
4bc60736154bc9e drivers/media/mc/mc-devnode.c Hans Verkuil          2024-02-23  237  	set_bit(MEDIA_FLAG_REGISTERED, &devnode->flags);
857313e51006ff5 drivers/media/media-devnode.c Logan Gunthorpe       2017-03-17  238  	ret = cdev_device_add(&devnode->cdev, &devnode->dev);
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  239  	if (ret < 0) {
857313e51006ff5 drivers/media/media-devnode.c Logan Gunthorpe       2017-03-17  240  		pr_err("%s: cdev_device_add failed\n", __func__);
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  241  		goto cdev_add_error;
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  242  	}
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  243  
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  244  	return 0;
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  245  
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  246  cdev_add_error:
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  247  	mutex_lock(&media_devnode_lock);
163f1e93e995048 drivers/media/media-devnode.c Mauro Carvalho Chehab 2016-03-23  248  	clear_bit(devnode->minor, media_devnode_nums);
88336e174645948 drivers/media/media-devnode.c Max Kellermann        2016-03-21  249  	mutex_unlock(&media_devnode_lock);
5b28dde51d0ccc5 drivers/media/media-devnode.c Shuah Khan            2016-05-04  250  	put_device(&devnode->dev);
803515300f06fab drivers/media/mc/mc-devnode.c Sakari Ailus          2016-06-18  251  
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  252  	return ret;
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  253  }
cf4b9211b5680cd drivers/media/media-devnode.c Laurent Pinchart      2009-12-09  254  

:::::: The code at line 233 was first introduced by commit
:::::: de9f0c2a1ce3d97561d5cf4678b80e13943647fd media: mc: add debugfs node to keep track of requests

:::::: TO: Hans Verkuil <hverkuil+cisco@kernel.org>
:::::: CC: Hans Verkuil <hverkuil+cisco@kernel.org>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-10-18 13:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-18 13:35 [sailus-media-tree:media-ref 2/17] drivers/media/mc/mc-devnode.c:233:40: error: 'mdev' undeclared; did you mean 'cdev'? kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.