Re: [PATCH 5/7] phy: qcom-mipi-csi2: Add qcs8300 CSI2 PHY support

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anusha Arun Nandi <anusha.nandi@oss.qualcomm.com>
Cc: bod@kernel.org, vkoul@kernel.org, kishon@kernel.org,
	robh@kernel.org,  krzk+dt@kernel.org, conor+dt@kernel.org,
	neil.armstrong@linaro.org, mani@kernel.org,
	 gjorgji.rosikopulos@oss.qualcomm.com,
	hariram.purushothaman@oss.qualcomm.com, akapatra@quicinc.com,
	 jigarkumar.zala@oss.qualcomm.com, loic.poulain@oss.qualcomm.com,
	vladimir.zapolskiy@linaro.org,  linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-media@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] phy: qcom-mipi-csi2: Add qcs8300 CSI2 PHY support
Date: Mon, 19 Oct 2026 09:18:50 +0200	[thread overview]
Message-ID: <20261019-elastic-psychedelic-chamois-e8bbae@quoll> (raw)
In-Reply-To: <20261016235502.2274268-6-anusha.nandi@oss.qualcomm.com>

On Fri, Oct 16, 2026 at 04:55:00PM -0700, Anusha Arun Nandi wrote:
> Bind the new "qcom,qcs8300-csi2-phy" compatible to the existing
> sa8775p SoC configuration (mipi_csi2_dphy_sa8775p). QCS8300
> and SA8775P share the same CSIPHY: in the legacy in-tree
> CAMSS driver (camss-csiphy-3ph-1-0.c) the CAMSS_8300 and CAMSS_8775P
> cases fall through to the same D-PHY lane_regs_sa8775p[] init sequence
> and common_regs_offset (0x800), and camss.c gives both SoCs the same
> pd_name = "top" Titan Top GDSC. No new register data or power-domain
> wiring is therefore needed; only the compatible string is added.
> 
> Signed-off-by: Anusha Arun Nandi <anusha.nandi@oss.qualcomm.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c b/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c
> index 821c6a0a916c..cef4a90ca539 100644
> --- a/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c
> +++ b/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c
> @@ -453,6 +453,7 @@ static int phy_qcom_mipi_csi2_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id phy_qcom_mipi_csi2_of_match_table[] = {
> +	{ .compatible	= "qcom,qcs8300-csi2-phy", .data = &mipi_csi2_dphy_sa8775p },

So devices are fully compatible? Then express it and drop this.

Best regards,
Krzysztof