[PATCH] ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD

[PATCH] ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD

[Takashi Iwai]

There have been reports about a regression with the recent boot quirk
for Behringer devices; it broke UMC204HD models(1397:0508 and
1397:0509).  The quirk was to just run usb_get_descriptor(), so I
expected it rather harmful, but in this case, it doesn't look so,
resulting in an error like 'failed to read device descriptor: -110'
that leads to a fatal probe error.

As a quick workaround, skip the quirk for those UMC204HD models.

Fixes: b5c4823cf3e4 ("ALSA: usb-audio: Apply boot quirk for Behringer models generically")
Reported-by: Will Bush <will@willbush.dev>
Closes: https://lore.kernel.org/45162613-2802-401c-84c9-742f9c8c68e6@app.fastmail.com
Closes: https://bugzilla.suse.com/show_bug.cgi?id=1285896
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/usb/quirks.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 4fadb1fdcdea..4ac4aef47dd7 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev,
 	}
 
 	/* Behringer devices may need explicit device descriptor read at boot */
-	if (USB_ID_VENDOR(id) == 0x1397)
+	if (USB_ID_VENDOR(id) == 0x1397) {
+		/* the quirk seems breaking on some Behringer devices */
+		switch (id) {
+		case USB_ID(0x1397, 0x0508): /* UMC204HD */
+		case USB_ID(0x1397, 0x0509): /* UMC204HD */
+			return 0;
+		}
 		return snd_usb_cm1a_boot_quirk(dev);
+	}
 
 	return 0;
 }
-- 
2.55.0