All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Andrew Goodbody <andrew.goodbody@linaro.org>
Cc: Ettore Chimenti <ettore.chimenti@linaro.org>,
	Paul Walmsley <paul@pwsan.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <linux@armlinux.org.uk>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Christopher Obbard <chris.obbard@oss.qualcomm.com>,
	Linus Walleij <linusw@kernel.org>,
	Rouven Czerwinski <rouven.czerwinski@linaro.org>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 06/10] ARM: dts: omap: dm816x: Update USB node
Date: Mon, 19 Oct 2026 15:45:03 +0200	[thread overview]
Message-ID: <20261019154503.2111a89c@kemnade.info> (raw)
In-Reply-To: <8a8313f1-d525-45d3-9044-b5f7a00b256d@linaro.org>

On Mon, 19 Oct 2026 10:36:37 +0100
Andrew Goodbody <andrew.goodbody@linaro.org> wrote:

> On 17/10/2026 07:39, Andreas Kemnade wrote:
> > On Fri, 16 Oct 2026 16:41:21 +0200
> > Ettore Chimenti <ettore.chimenti@linaro.org> wrote:
> >   
> >> From: Andrew Goodbody <andrew.goodbody@linaro.org>
> >>
> >> USB node was not working correctly with DMA enabled as the supporting
> >> code had been updated without updating this SoC's device tree. Bring the
> >> device tree more up to date so that it works with DMA enabled.
> >>
> >> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
> >> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
> >> ---
> >>   arch/arm/boot/dts/ti/omap/dm816x.dtsi | 41 +++++++++++++++++++++--------------
> >>   1 file changed, 25 insertions(+), 16 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> >> index 7f3ef3a00ab8..5be9efc60785 100644
> >> --- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> >> +++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> >> @@ -574,18 +574,27 @@ uart3: serial@48024000 {
> >>   		};
> >>   
> >>   		/* NOTE: USB needs a transceiver driver for phys to work */
> >> -		usb: usb_otg_hs@47401000 {
> >> -			compatible = "ti,am33xx-usb";
> >> -			reg = <0x47401000 0x400000>;
> >> -			ranges;
> >> +		usb: target-module@47400000 {
> >> +			compatible = "ti,sysc-omap4", "ti,sysc";
> >> +			ti,hwmods = "usb_otg_hs";  
> > 
> > Why do we still need this? It is depcrecated.
> > 
> > Regards,
> > Andreas  
> 
> Without that line we get the following on boot and USB does not work
> 
> [    0.110148] omap_hwmod: usb_otg_hs: no dt node

It is somewhat odd to use both ti-sysc and hwmod. It looks like a
half conversion.

For an example how usb_otg_hs was converted to ti-sysc for omap3, look at
42a79edd4a3dc1bb8e89fd2849f9e8e1e1c13977...v6.1-rc1

It has no hwmod stuff left.

Regards,
Andreas


  reply	other threads:[~2026-10-19 13:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 14:41 [PATCH 00/10] ARM: dts: dm816x: fixes and peripheral updates for DM8168 SoC Ettore Chimenti
2026-10-16 14:41 ` [PATCH 01/10] ARM: ti81xx: Prevent USB being put into idle Ettore Chimenti
2026-10-17  6:53   ` Andreas Kemnade
2026-10-19  9:28     ` Andrew Goodbody
2026-10-16 14:41 ` [PATCH 02/10] dt-bindings: pinctrl: Add devicetree bindings for DM816x SoC Pinctrl Ettore Chimenti
2026-10-16 14:45   ` sashiko-bot
2026-10-16 14:51   ` Krzysztof Kozlowski
2026-10-16 15:07     ` Ettore Chimenti
2026-10-19  6:46       ` Krzysztof Kozlowski
2026-10-20 10:18         ` Ettore Chimenti
2026-10-20 11:22           ` Krzysztof Kozlowski
2026-10-20 12:16             ` Ettore Chimenti
2026-10-20 19:51           ` Andreas Kemnade
2026-10-21 16:03             ` Ettore Chimenti
2026-10-16 14:41 ` [PATCH 03/10] ARM: dts: omap: dm816x: use dedicated SoC pinctrl Ettore Chimenti
2026-10-16 14:49   ` sashiko-bot
2026-10-16 14:41 ` [PATCH 04/10] ARM: dts: omap: dm816x: Fix pinctrl range Ettore Chimenti
2026-10-16 14:41 ` [PATCH 05/10] ARM: dts: omap: dm816x: refactor and align MMC node Ettore Chimenti
2026-10-16 14:41 ` [PATCH 06/10] ARM: dts: omap: dm816x: Update USB node Ettore Chimenti
2026-10-16 14:54   ` sashiko-bot
2026-10-17  6:39   ` Andreas Kemnade
2026-10-19  9:36     ` Andrew Goodbody
2026-10-19 13:45       ` Andreas Kemnade [this message]
2026-10-19 16:32         ` Andrew Goodbody
2026-10-16 14:41 ` [PATCH 07/10] ARM: omap: dm816x: Match up capability flags for USB Ettore Chimenti
2026-10-16 14:41 ` [PATCH 08/10] ARM: dts: omap: dm816x: Correct speed for sysclk5 Ettore Chimenti
2026-10-16 14:53   ` sashiko-bot
2026-10-16 14:41 ` [PATCH 09/10] ARM: dts: omap: dm8168-evm: Correct SD card pinmux Ettore Chimenti
2026-10-16 14:41 ` [PATCH 10/10] ARM: dts: omap: dm8168-evm: enable MUSB multipoint support Ettore Chimenti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019154503.2111a89c@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=aaro.koskinen@iki.fi \
    --cc=andrew.goodbody@linaro.org \
    --cc=chris.obbard@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ettore.chimenti@linaro.org \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=paul@pwsan.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=rouven.czerwinski@linaro.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.