From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Igor Opaniuk <igor.opaniuk@gmail.com>, u-boot@lists.u-boot-project.org
Cc: Jan Kehren <jan.kehren@emteria.com>,
Guillaume La Roque <glaroque@baylibre.com>,
Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Subject: [PATCH v2 03/10] test/py: android: Drop verbose printing and unused return
Date: Tue, 20 Oct 2026 11:25:52 +0200 [thread overview]
Message-ID: <20261020-test-avb-fixes-v2-3-997f8f04fd3f@kernel.org> (raw)
In-Reply-To: <20261020-test-avb-fixes-v2-0-997f8f04fd3f@kernel.org>
The setup_android_image() is only called once. The callers does not use
the return value.
Drop the unused return. While at it, also remove the verbose printing.
Reviewed-by: Guillaume La Roque <glaroque@baylibre.com>
Reviewed-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Tested-by: Guillaume La Roque <glaroque@baylibre.com>
Tested-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
---
test/py/tests/test_android/android_image.py | 6 ------
1 file changed, 6 deletions(-)
diff --git a/test/py/tests/test_android/android_image.py b/test/py/tests/test_android/android_image.py
index 3bea311586bf..8b536754656e 100644
--- a/test/py/tests/test_android/android_image.py
+++ b/test/py/tests/test_android/android_image.py
@@ -81,8 +81,6 @@ def setup_android_image(ubman):
with open(fname, 'wb') as outf:
outf.write(disk_data)
- print(f'wrote to {fname}')
-
mmc_dev = 8
fname = os.path.join(ubman.config.source_dir, f'mmc{mmc_dev}.img')
utils.run_and_log(ubman, f'qemu-img create {fname} 20M')
@@ -129,7 +127,3 @@ def setup_android_image(ubman):
with open(fname, 'wb') as outf:
outf.write(disk_data)
-
- print(f'wrote to {fname}')
-
- return fname
--
2.56.0
next prev parent reply other threads:[~2026-10-20 9:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 9:25 [PATCH v2 00/10] Fix AVB pytest suite for sandbox Mattijs Korpershoek
2026-10-20 9:25 ` [PATCH v2 01/10] avb: Use map_to_sysmem() for flush_cache() address Mattijs Korpershoek
2026-10-22 8:25 ` Simon Glass
2026-10-20 9:25 ` [PATCH v2 02/10] test/py: android: Move android image creation to a dedicated file Mattijs Korpershoek
2026-10-22 8:25 ` Simon Glass
2026-10-20 9:25 ` Mattijs Korpershoek [this message]
2026-10-22 8:25 ` [PATCH v2 03/10] test/py: android: Drop verbose printing and unused return Simon Glass
2026-10-20 9:25 ` [PATCH v2 04/10] test/py: android: Use for loop to create the images / update disks Mattijs Korpershoek
2026-10-22 8:25 ` Simon Glass
2026-10-20 9:25 ` [PATCH v2 05/10] test/py: android: Add create_gpt_image() for image creation Mattijs Korpershoek
2026-10-20 15:07 ` Guillaume La Roque
2026-10-22 8:26 ` Simon Glass
2026-10-22 13:24 ` Mattijs Korpershoek
2026-10-20 9:25 ` [PATCH v2 06/10] test/py: android: Add setup_android_v{4,2}_image subfunctions Mattijs Korpershoek
2026-10-22 8:26 ` [PATCH v2 06/10] test/py: android: Add setup_android_v{4, 2}_image subfunctions Simon Glass
2026-10-20 9:25 ` [PATCH v2 07/10] test/py: avb: Use format specifiers instead of str() for mmc_dev Mattijs Korpershoek
2026-10-22 8:59 ` Simon Glass
2026-10-20 9:25 ` [PATCH v2 08/10] test/py: avb: Move mmc device number to a pytest fixture Mattijs Korpershoek
2026-10-22 8:26 ` Simon Glass
2026-10-20 9:25 ` [PATCH v2 09/10] test/py: avb: Add sandbox AVB testing with dedicated mmc12 device Mattijs Korpershoek
2026-10-22 8:26 ` Simon Glass
2026-10-22 12:53 ` Mattijs Korpershoek
2026-10-20 9:25 ` [PATCH v2 10/10] test/py: avb: Fix find() logic when matching response strings Mattijs Korpershoek
2026-10-20 15:07 ` Guillaume La Roque
2026-10-22 8:26 ` Simon Glass
2026-10-22 12:22 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020-test-avb-fixes-v2-3-997f8f04fd3f@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=glaroque@baylibre.com \
--cc=igor.opaniuk@gmail.com \
--cc=igor.opaniuk@oss.qualcomm.com \
--cc=jan.kehren@emteria.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.