Re: [PATCH v2 10/10] test/py: avb: Fix find() logic when matching response strings

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Simon,

Thank you for the review.

On Thu, Oct 22, 2026 at 01:26, Simon Glass <sjg@chromium.org> wrote:

> Hi Mattijs,
>
> On 2026-10-20T09:25:49, Mattijs Korpershoek <mkorpershoek@kernel.org> wrote:
>> test/py: avb: Fix find() logic when matching response strings
>>
>> The AVB test suite runs some avb commands (such as "avb verify") and
>> then parses the console output for success/failure.
>>
>> It does so by using the string.find() function which returns:
>> * -1 when the subsystring does not exist
>
> Typo: 'subsystring' should be 'substring'

Will fix in v3.

>
>> * 0/a positive number when the substring exists
>>
>> For example, here is the output of:
>> $ ./test/py/test.py --bd sandbox --build -k test_avb_verify -s -v
>>
>> Hit any key to stop autoboot: 0
>> => =>  avb init 1
>> => => avb verify
>> get_partition: no MMC device at slot 1
>> get_partition: no MMC device at slot 1
>> avb_slot_verify.c:644: ERROR: boot: Error loading footer.
>> Verification failed, reason: I/O error occurred while trying to load data
>> => PASSED
>> [...]
>>
>>  test/py/tests/test_android/test_avb.py | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>
>> diff --git a/test/py/tests/test_android/test_avb.py b/test/py/tests/test_android/test_avb.py
>> @@ -64,7 +64,7 @@ def test_avb_verify(ubman, avb_device_id):
>> -    assert response.find(success_str)
>> +    assert response.find(success_str) != -1
>
> It would be worth using the 'in' operator here and elsewhere, e.g.
> 'assert success_str in response', since that is the usual Python
> idiom. It also helps with debugging: pytest's assertion rewriting then
> shows both the expected string and the console output on failure,
> whereas '!= -1' just gives '-1 != -1'. What do you think?

Indeed, that's a good suggestion, thank you. Will do in v3.

>
> Regards,
> Simon