* [android-common:android13-5.10-2026-10 1/1] drivers/of/base.c:1786: warning: Excess function parameter 'prob' description in '__of_add_property'
@ 2026-10-19 23:19 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-10-19 23:19 UTC (permalink / raw)
To: cros-kernel-buildreports; +Cc: oe-kbuild-all
tree: https://android.googlesource.com/kernel/common android13-5.10-2026-10
head: a4c2f82969bc5fa7fcc21ede4b690ece7ff72335
commit: 58ccdcc9d7208f938a13604fec07fc7e521918ae [1/1] of: base: Fix some formatting issues and provide missing descriptions
config: arm-randconfig-r2104-20261018 (https://download.01.org/0day-ci/archive/20261020/202610200109.8eqlE587-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261020/202610200109.8eqlE587-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610200109.8eqlE587-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/of/base.c:1786: warning: Function parameter or member 'prop' not described in '__of_add_property'
>> drivers/of/base.c:1786: warning: Excess function parameter 'prob' description in '__of_add_property'
drivers/of/base.c:1809: warning: Function parameter or member 'prop' not described in 'of_add_property'
>> drivers/of/base.c:1809: warning: Excess function parameter 'prob' description in 'of_add_property'
drivers/of/base.c:1860: warning: Function parameter or member 'prop' not described in 'of_remove_property'
>> drivers/of/base.c:1860: warning: Excess function parameter 'prob' description in 'of_remove_property'
vim +1786 drivers/of/base.c
bd69f73f2c81ee Grant Likely 2013-02-10 1779
62664f67775fad Xiubo Li 2014-01-22 1780 /**
62664f67775fad Xiubo Li 2014-01-22 1781 * __of_add_property - Add a property to a node without lock operations
58ccdcc9d7208f Lee Jones 2021-03-18 1782 * @np: Caller's Device Node
58ccdcc9d7208f Lee Jones 2021-03-18 1783 * @prob: Property to add
62664f67775fad Xiubo Li 2014-01-22 1784 */
d8c50088417ebf Pantelis Antoniou 2014-07-04 1785 int __of_add_property(struct device_node *np, struct property *prop)
62664f67775fad Xiubo Li 2014-01-22 @1786 {
62664f67775fad Xiubo Li 2014-01-22 1787 struct property **next;
62664f67775fad Xiubo Li 2014-01-22 1788
62664f67775fad Xiubo Li 2014-01-22 1789 prop->next = NULL;
62664f67775fad Xiubo Li 2014-01-22 1790 next = &np->properties;
62664f67775fad Xiubo Li 2014-01-22 1791 while (*next) {
62664f67775fad Xiubo Li 2014-01-22 1792 if (strcmp(prop->name, (*next)->name) == 0)
62664f67775fad Xiubo Li 2014-01-22 1793 /* duplicate ! don't insert it */
62664f67775fad Xiubo Li 2014-01-22 1794 return -EEXIST;
62664f67775fad Xiubo Li 2014-01-22 1795
62664f67775fad Xiubo Li 2014-01-22 1796 next = &(*next)->next;
62664f67775fad Xiubo Li 2014-01-22 1797 }
62664f67775fad Xiubo Li 2014-01-22 1798 *next = prop;
62664f67775fad Xiubo Li 2014-01-22 1799
62664f67775fad Xiubo Li 2014-01-22 1800 return 0;
62664f67775fad Xiubo Li 2014-01-22 1801 }
62664f67775fad Xiubo Li 2014-01-22 1802
02af11b03fce3d Grant Likely 2009-11-23 1803 /**
79d1c712958f94 Nathan Fontenot 2012-10-02 1804 * of_add_property - Add a property to a node
58ccdcc9d7208f Lee Jones 2021-03-18 1805 * @np: Caller's Device Node
58ccdcc9d7208f Lee Jones 2021-03-18 1806 * @prob: Property to add
02af11b03fce3d Grant Likely 2009-11-23 1807 */
79d1c712958f94 Nathan Fontenot 2012-10-02 1808 int of_add_property(struct device_node *np, struct property *prop)
02af11b03fce3d Grant Likely 2009-11-23 @1809 {
02af11b03fce3d Grant Likely 2009-11-23 1810 unsigned long flags;
1cf3d8b3d24cd3 Nathan Fontenot 2012-10-02 1811 int rc;
1cf3d8b3d24cd3 Nathan Fontenot 2012-10-02 1812
8a2b22a2595bf8 Grant Likely 2014-07-23 1813 mutex_lock(&of_mutex);
02af11b03fce3d Grant Likely 2009-11-23 1814
d6d3c4e656513d Thomas Gleixner 2013-02-06 1815 raw_spin_lock_irqsave(&devtree_lock, flags);
62664f67775fad Xiubo Li 2014-01-22 1816 rc = __of_add_property(np, prop);
d6d3c4e656513d Thomas Gleixner 2013-02-06 1817 raw_spin_unlock_irqrestore(&devtree_lock, flags);
02af11b03fce3d Grant Likely 2009-11-23 1818
8a2b22a2595bf8 Grant Likely 2014-07-23 1819 if (!rc)
75b57ecf9d1d1e Grant Likely 2014-02-20 1820 __of_add_property_sysfs(np, prop);
02af11b03fce3d Grant Likely 2009-11-23 1821
8a2b22a2595bf8 Grant Likely 2014-07-23 1822 mutex_unlock(&of_mutex);
8a2b22a2595bf8 Grant Likely 2014-07-23 1823
259092a35c7e11 Grant Likely 2014-07-16 1824 if (!rc)
259092a35c7e11 Grant Likely 2014-07-16 1825 of_property_notify(OF_RECONFIG_ADD_PROPERTY, np, prop, NULL);
259092a35c7e11 Grant Likely 2014-07-16 1826
62664f67775fad Xiubo Li 2014-01-22 1827 return rc;
02af11b03fce3d Grant Likely 2009-11-23 1828 }
02af11b03fce3d Grant Likely 2009-11-23 1829
d8c50088417ebf Pantelis Antoniou 2014-07-04 1830 int __of_remove_property(struct device_node *np, struct property *prop)
d8c50088417ebf Pantelis Antoniou 2014-07-04 1831 {
d8c50088417ebf Pantelis Antoniou 2014-07-04 1832 struct property **next;
d8c50088417ebf Pantelis Antoniou 2014-07-04 1833
d8c50088417ebf Pantelis Antoniou 2014-07-04 1834 for (next = &np->properties; *next; next = &(*next)->next) {
d8c50088417ebf Pantelis Antoniou 2014-07-04 1835 if (*next == prop)
d8c50088417ebf Pantelis Antoniou 2014-07-04 1836 break;
d8c50088417ebf Pantelis Antoniou 2014-07-04 1837 }
d8c50088417ebf Pantelis Antoniou 2014-07-04 1838 if (*next == NULL)
d8c50088417ebf Pantelis Antoniou 2014-07-04 1839 return -ENODEV;
d8c50088417ebf Pantelis Antoniou 2014-07-04 1840
d8c50088417ebf Pantelis Antoniou 2014-07-04 1841 /* found the node */
d8c50088417ebf Pantelis Antoniou 2014-07-04 1842 *next = prop->next;
d8c50088417ebf Pantelis Antoniou 2014-07-04 1843 prop->next = np->deadprops;
d8c50088417ebf Pantelis Antoniou 2014-07-04 1844 np->deadprops = prop;
d8c50088417ebf Pantelis Antoniou 2014-07-04 1845
d8c50088417ebf Pantelis Antoniou 2014-07-04 1846 return 0;
d8c50088417ebf Pantelis Antoniou 2014-07-04 1847 }
d8c50088417ebf Pantelis Antoniou 2014-07-04 1848
02af11b03fce3d Grant Likely 2009-11-23 1849 /**
79d1c712958f94 Nathan Fontenot 2012-10-02 1850 * of_remove_property - Remove a property from a node.
58ccdcc9d7208f Lee Jones 2021-03-18 1851 * @np: Caller's Device Node
58ccdcc9d7208f Lee Jones 2021-03-18 1852 * @prob: Property to remove
02af11b03fce3d Grant Likely 2009-11-23 1853 *
02af11b03fce3d Grant Likely 2009-11-23 1854 * Note that we don't actually remove it, since we have given out
02af11b03fce3d Grant Likely 2009-11-23 1855 * who-knows-how-many pointers to the data using get-property.
02af11b03fce3d Grant Likely 2009-11-23 1856 * Instead we just move the property to the "dead properties"
02af11b03fce3d Grant Likely 2009-11-23 1857 * list, so it won't be found any more.
02af11b03fce3d Grant Likely 2009-11-23 1858 */
79d1c712958f94 Nathan Fontenot 2012-10-02 1859 int of_remove_property(struct device_node *np, struct property *prop)
02af11b03fce3d Grant Likely 2009-11-23 @1860 {
02af11b03fce3d Grant Likely 2009-11-23 1861 unsigned long flags;
1cf3d8b3d24cd3 Nathan Fontenot 2012-10-02 1862 int rc;
1cf3d8b3d24cd3 Nathan Fontenot 2012-10-02 1863
201b3fe586361c Suraj Jitindar Singh 2016-04-28 1864 if (!prop)
201b3fe586361c Suraj Jitindar Singh 2016-04-28 1865 return -ENODEV;
201b3fe586361c Suraj Jitindar Singh 2016-04-28 1866
8a2b22a2595bf8 Grant Likely 2014-07-23 1867 mutex_lock(&of_mutex);
02af11b03fce3d Grant Likely 2009-11-23 1868
d6d3c4e656513d Thomas Gleixner 2013-02-06 1869 raw_spin_lock_irqsave(&devtree_lock, flags);
d8c50088417ebf Pantelis Antoniou 2014-07-04 1870 rc = __of_remove_property(np, prop);
d6d3c4e656513d Thomas Gleixner 2013-02-06 1871 raw_spin_unlock_irqrestore(&devtree_lock, flags);
02af11b03fce3d Grant Likely 2009-11-23 1872
8a2b22a2595bf8 Grant Likely 2014-07-23 1873 if (!rc)
8a2b22a2595bf8 Grant Likely 2014-07-23 1874 __of_remove_property_sysfs(np, prop);
02af11b03fce3d Grant Likely 2009-11-23 1875
8a2b22a2595bf8 Grant Likely 2014-07-23 1876 mutex_unlock(&of_mutex);
75b57ecf9d1d1e Grant Likely 2014-02-20 1877
259092a35c7e11 Grant Likely 2014-07-16 1878 if (!rc)
259092a35c7e11 Grant Likely 2014-07-16 1879 of_property_notify(OF_RECONFIG_REMOVE_PROPERTY, np, prop, NULL);
02af11b03fce3d Grant Likely 2009-11-23 1880
8a2b22a2595bf8 Grant Likely 2014-07-23 1881 return rc;
02af11b03fce3d Grant Likely 2009-11-23 1882 }
0f7c5317b89058 Florian Fainelli 2020-09-04 1883 EXPORT_SYMBOL_GPL(of_remove_property);
02af11b03fce3d Grant Likely 2009-11-23 1884
:::::: The code at line 1786 was first introduced by commit
:::::: 62664f67775fad840cf6f68d6b5f428817bef6c5 of: add __of_add_property() without lock operations
:::::: TO: Xiubo Li <Li.Xiubo@freescale.com>
:::::: CC: Grant Likely <grant.likely@linaro.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-19 23:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-19 23:19 [android-common:android13-5.10-2026-10 1/1] drivers/of/base.c:1786: warning: Excess function parameter 'prob' description in '__of_add_property' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.