All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Damon Ding <damon.ding@rock-chips.com>
Cc: Sandy Huang <hjc@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Andy Yan <andy.yan@rock-chips.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Robert Foss <rfoss@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Dave Jones <s.dave.jones@gmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH v3 1/6] dt-bindings: display: rockchip: analogix-dp: Add support for RK3568
Date: Wed, 21 Oct 2026 08:30:02 -0500	[thread overview]
Message-ID: <20261021133002.GA3886567-robh@kernel.org> (raw)
In-Reply-To: <20261020030916.3223833-2-damon.ding@rock-chips.com>

On Tue, Oct 20, 2026 at 11:09:11AM +0800, Damon Ding wrote:
> Document the "rockchip,rk3568-edp" compatible.  Like RK3576/RK3588,
> the RK3568 eDP controller has the dp/pclk/hclk clocks and dp/apb
> resets, but unlike them it does not use GRF registers, so make the
> "rockchip,grf" property conditional on the SoC.
> 
> Also document the optional avdd-0v9 and avdd-1v8 supplies, which are
> needed by the RK3568 eDP controller.
> 
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
> ---
>  .../rockchip/rockchip,analogix-dp.yaml        | 25 ++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> index 39dafe75a680..f8670a4e0430 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> @@ -15,6 +15,7 @@ properties:
>      enum:
>        - rockchip,rk3288-dp
>        - rockchip,rk3399-edp
> +      - rockchip,rk3568-edp
>        - rockchip,rk3576-edp
>        - rockchip,rk3588-edp
>  
> @@ -47,6 +48,16 @@ properties:
>        - const: dp
>        - const: apb
>  
> +  avdd-0v9-supply:
> +    description:
> +      A 0.9V supply that powers up the SoC internal circuitry. The actual
> +      supply source varies between different boards.
> +
> +  avdd-1v8-supply:
> +    description:
> +      A 1.8V supply that powers up the SoC internal circuitry. The actual
> +      supply source varies between different boards.
> +

Are these valid for other compatibles?

Rob


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Damon Ding <damon.ding@rock-chips.com>
Cc: Sandy Huang <hjc@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Andy Yan <andy.yan@rock-chips.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Robert Foss <rfoss@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Dave Jones <s.dave.jones@gmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH v3 1/6] dt-bindings: display: rockchip: analogix-dp: Add support for RK3568
Date: Wed, 21 Oct 2026 08:30:02 -0500	[thread overview]
Message-ID: <20261021133002.GA3886567-robh@kernel.org> (raw)
In-Reply-To: <20261020030916.3223833-2-damon.ding@rock-chips.com>

On Tue, Oct 20, 2026 at 11:09:11AM +0800, Damon Ding wrote:
> Document the "rockchip,rk3568-edp" compatible.  Like RK3576/RK3588,
> the RK3568 eDP controller has the dp/pclk/hclk clocks and dp/apb
> resets, but unlike them it does not use GRF registers, so make the
> "rockchip,grf" property conditional on the SoC.
> 
> Also document the optional avdd-0v9 and avdd-1v8 supplies, which are
> needed by the RK3568 eDP controller.
> 
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
> ---
>  .../rockchip/rockchip,analogix-dp.yaml        | 25 ++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> index 39dafe75a680..f8670a4e0430 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> @@ -15,6 +15,7 @@ properties:
>      enum:
>        - rockchip,rk3288-dp
>        - rockchip,rk3399-edp
> +      - rockchip,rk3568-edp
>        - rockchip,rk3576-edp
>        - rockchip,rk3588-edp
>  
> @@ -47,6 +48,16 @@ properties:
>        - const: dp
>        - const: apb
>  
> +  avdd-0v9-supply:
> +    description:
> +      A 0.9V supply that powers up the SoC internal circuitry. The actual
> +      supply source varies between different boards.
> +
> +  avdd-1v8-supply:
> +    description:
> +      A 1.8V supply that powers up the SoC internal circuitry. The actual
> +      supply source varies between different boards.
> +

Are these valid for other compatibles?

Rob

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Damon Ding <damon.ding@rock-chips.com>
Cc: Sandy Huang <hjc@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Andy Yan <andy.yan@rock-chips.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Robert Foss <rfoss@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Dave Jones <s.dave.jones@gmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH v3 1/6] dt-bindings: display: rockchip: analogix-dp: Add support for RK3568
Date: Wed, 21 Oct 2026 08:30:02 -0500	[thread overview]
Message-ID: <20261021133002.GA3886567-robh@kernel.org> (raw)
In-Reply-To: <20261020030916.3223833-2-damon.ding@rock-chips.com>

On Tue, Oct 20, 2026 at 11:09:11AM +0800, Damon Ding wrote:
> Document the "rockchip,rk3568-edp" compatible.  Like RK3576/RK3588,
> the RK3568 eDP controller has the dp/pclk/hclk clocks and dp/apb
> resets, but unlike them it does not use GRF registers, so make the
> "rockchip,grf" property conditional on the SoC.
> 
> Also document the optional avdd-0v9 and avdd-1v8 supplies, which are
> needed by the RK3568 eDP controller.
> 
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
> ---
>  .../rockchip/rockchip,analogix-dp.yaml        | 25 ++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> index 39dafe75a680..f8670a4e0430 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> @@ -15,6 +15,7 @@ properties:
>      enum:
>        - rockchip,rk3288-dp
>        - rockchip,rk3399-edp
> +      - rockchip,rk3568-edp
>        - rockchip,rk3576-edp
>        - rockchip,rk3588-edp
>  
> @@ -47,6 +48,16 @@ properties:
>        - const: dp
>        - const: apb
>  
> +  avdd-0v9-supply:
> +    description:
> +      A 0.9V supply that powers up the SoC internal circuitry. The actual
> +      supply source varies between different boards.
> +
> +  avdd-1v8-supply:
> +    description:
> +      A 1.8V supply that powers up the SoC internal circuitry. The actual
> +      supply source varies between different boards.
> +

Are these valid for other compatibles?

Rob

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-10-21 13:30 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  3:09 [PATCH v3 0/6] Add eDP support for RK3568 Damon Ding
2026-10-20  3:09 ` Damon Ding
2026-10-20  3:09 ` Damon Ding
2026-10-20  3:09 ` [PATCH v3 1/6] dt-bindings: display: rockchip: analogix-dp: Add " Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-21 13:30   ` Rob Herring [this message]
2026-10-21 13:30     ` Rob Herring
2026-10-21 13:30     ` Rob Herring
2026-10-23  2:34     ` Damon Ding
2026-10-23  2:34       ` Damon Ding
2026-10-23  2:34       ` Damon Ding
2026-10-20  3:09 ` [PATCH v3 2/6] dt-bindings: phy: Add rockchip,rk3568-edp-phy Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-21 13:34   ` Rob Herring
2026-10-21 13:34     ` Rob Herring
2026-10-21 13:34     ` Rob Herring
2026-10-23  3:56     ` Damon Ding
2026-10-23  3:56       ` Damon Ding
2026-10-23  3:56       ` Damon Ding
2026-10-20  3:09 ` [PATCH v3 3/6] drm/bridge: analogix_dp: Add support for RK3568 Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-20  3:09 ` [PATCH v3 4/6] phy: rockchip: Add support for Naneng eDP phy Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-20  3:09 ` [PATCH v3 5/6] drm/rockchip: analogix_dp: Add support for RK3568 Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-20  3:09 ` [PATCH v3 6/6] arm64: dts: rockchip: rk356x: Add eDP controller and phy nodes Damon Ding
2026-10-20  3:09   ` Damon Ding
2026-10-20  3:09   ` Damon Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021133002.GA3886567-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=andy.yan@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=damon.ding@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mani@kernel.org \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=s.dave.jones@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.