From: Jason Gunthorpe <jgg@nvidia.com>
To: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
Cc: "Alexandre Ghiti" <alex@ghiti.fr>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"David Sterba" <dsterba@suse.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org, linux-efi@vger.kernel.org,
linux-riscv@lists.infradead.org,
"Mark Rutland" <mark.rutland@arm.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <pjw@kernel.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Simon Glass" <sjg@chromium.org>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Nick Terrell" <terrelln@fb.com>, "Will Deacon" <will@kernel.org>,
"Alexandre Ghiti" <alexghiti@rivosinc.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
linux-integrity@vger.kernel.org,
"Palmer Dabbelt" <palmer@rivosinc.com>,
patches@lists.linux.dev, "Piotr Król" <piotr.krol@3mdeb.com>,
"Ross Philipson" <ross.philipson@gmail.com>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Song Shuai" <songshuaishuai@tinylab.org>
Subject: Re: [PATCH v2 14/15] arm64: drtm: Call UNPROTECT_MEMORY
Date: Wed, 21 Oct 2026 14:50:10 -0300 [thread overview]
Message-ID: <20261021175010.GV3008132@nvidia.com> (raw)
In-Reply-To: <20261021104726.00002640@oss.qualcomm.com>
On Wed, Oct 21, 2026 at 10:47:26AM -0700, Jonathan Cameron wrote:
> On Fri, 2 Oct 2026 20:31:51 -0300
> Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> > The stub always requests ARM_DRTM_LAUNCH_DMA_COMPLETE. On a system
> > with an SMMU the COMPLETE option is sanely implemented using the SMMU
> > global abort register. DMA_COMPLETE should be mostly a no-op. It
> > seems to be designed for the region protection mode that Linux does
> > not use.
> >
> > However, the FW can still do something interesting under it and we
> > should call it. Choose late_initcall as we know the SMMU drivers are
> > loaded by then. If some platform does actually block DMA beyond the
> > SMMU, then this would result in a noisy failure of built-in driver
> > DMA, not a silent security gap.
> >
> > The platforms I'm aware of are OK with this placement, and it is a
> > reasonable place to start.
> >
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> > ---
> > arch/arm64/kernel/drtm.c | 39 +++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 39 insertions(+)
> >
> > diff --git a/arch/arm64/kernel/drtm.c b/arch/arm64/kernel/drtm.c
> > index 14493948a27f0d..6062980a5d9e53 100644
> > --- a/arch/arm64/kernel/drtm.c
> > +++ b/arch/arm64/kernel/drtm.c
> > @@ -3,8 +3,47 @@
> > *
> > * Support functions for ARM DEN 0113 "DRTM Architecture for Arm"
> > */
> > +#include <linux/bug.h>
> > #include <linux/efi.h>
> > +#include <linux/init.h>
> > +#include <linux/printk.h>
> >
> > #include <asm/drtm.h>
> >
> > struct arm64_drtm_handoff arm64_drtm_handoff __efi_data_handoff;
> > +
> > +static int __init arm64_drtm_unprotect_memory(void)
> > +{
> > + s64 status;
> > +
> > + if (!arm64_drtm_handoff.drtm_enabled)
> > + return 0;
> > +
> > + /*
> > + * Currently Linux can only fully support a DRTM implementation that
> > + * relies only the SMMU.
>
> That sentence doesn't parse. relies on maybe?
Yes
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
Cc: "Alexandre Ghiti" <alex@ghiti.fr>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"David Sterba" <dsterba@suse.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org, linux-efi@vger.kernel.org,
linux-riscv@lists.infradead.org,
"Mark Rutland" <mark.rutland@arm.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <pjw@kernel.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Simon Glass" <sjg@chromium.org>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Nick Terrell" <terrelln@fb.com>, "Will Deacon" <will@kernel.org>,
"Alexandre Ghiti" <alexghiti@rivosinc.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
linux-integrity@vger.kernel.org,
"Palmer Dabbelt" <palmer@rivosinc.com>,
patches@lists.linux.dev, "Piotr Król" <piotr.krol@3mdeb.com>,
"Ross Philipson" <ross.philipson@gmail.com>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Song Shuai" <songshuaishuai@tinylab.org>
Subject: Re: [PATCH v2 14/15] arm64: drtm: Call UNPROTECT_MEMORY
Date: Wed, 21 Oct 2026 14:50:10 -0300 [thread overview]
Message-ID: <20261021175010.GV3008132@nvidia.com> (raw)
In-Reply-To: <20261021104726.00002640@oss.qualcomm.com>
On Wed, Oct 21, 2026 at 10:47:26AM -0700, Jonathan Cameron wrote:
> On Fri, 2 Oct 2026 20:31:51 -0300
> Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> > The stub always requests ARM_DRTM_LAUNCH_DMA_COMPLETE. On a system
> > with an SMMU the COMPLETE option is sanely implemented using the SMMU
> > global abort register. DMA_COMPLETE should be mostly a no-op. It
> > seems to be designed for the region protection mode that Linux does
> > not use.
> >
> > However, the FW can still do something interesting under it and we
> > should call it. Choose late_initcall as we know the SMMU drivers are
> > loaded by then. If some platform does actually block DMA beyond the
> > SMMU, then this would result in a noisy failure of built-in driver
> > DMA, not a silent security gap.
> >
> > The platforms I'm aware of are OK with this placement, and it is a
> > reasonable place to start.
> >
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> > ---
> > arch/arm64/kernel/drtm.c | 39 +++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 39 insertions(+)
> >
> > diff --git a/arch/arm64/kernel/drtm.c b/arch/arm64/kernel/drtm.c
> > index 14493948a27f0d..6062980a5d9e53 100644
> > --- a/arch/arm64/kernel/drtm.c
> > +++ b/arch/arm64/kernel/drtm.c
> > @@ -3,8 +3,47 @@
> > *
> > * Support functions for ARM DEN 0113 "DRTM Architecture for Arm"
> > */
> > +#include <linux/bug.h>
> > #include <linux/efi.h>
> > +#include <linux/init.h>
> > +#include <linux/printk.h>
> >
> > #include <asm/drtm.h>
> >
> > struct arm64_drtm_handoff arm64_drtm_handoff __efi_data_handoff;
> > +
> > +static int __init arm64_drtm_unprotect_memory(void)
> > +{
> > + s64 status;
> > +
> > + if (!arm64_drtm_handoff.drtm_enabled)
> > + return 0;
> > +
> > + /*
> > + * Currently Linux can only fully support a DRTM implementation that
> > + * relies only the SMMU.
>
> That sentence doesn't parse. relies on maybe?
Yes
Jason
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-10-21 17:50 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 23:31 [PATCH v2 00/15] arm64: DRTM, boot portion Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-02 23:31 ` [PATCH v2 01/15] efi/libstub: Fix error unwind freeing fdt in allocate_new_fdt_and_exit_boot() Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-02 23:31 ` [PATCH v2 02/15] efi/riscv: libstub: Don't set image_size in handle_kernel_image() Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-21 16:00 ` Jonathan Cameron
2026-10-21 16:00 ` Jonathan Cameron
2026-10-02 23:31 ` [PATCH v2 03/15] efi/libstub: Free cmdline_ptr in efi_pe_entry Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-21 16:08 ` Jonathan Cameron
2026-10-21 16:08 ` Jonathan Cameron
2026-10-02 23:31 ` [PATCH v2 04/15] efi/libstub: Add a general way to get symbols from the vmlinux into zboot Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-21 16:16 ` Jonathan Cameron
2026-10-21 16:16 ` Jonathan Cameron
2026-10-02 23:31 ` [PATCH v2 05/15] arm64/efi: Use CONFIG_EFI_STUB_IMAGE_INFO for code_size Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-02 23:31 ` [PATCH v2 06/15] efi/zboot: Lift efi_cache_sync_image() from efi_zboot_decompress() Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-21 16:33 ` Jonathan Cameron
2026-10-21 16:33 ` Jonathan Cameron
2026-10-02 23:31 ` [PATCH v2 07/15] efi/libstub: Add generic arch callbacks for DRTM Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-21 16:51 ` Jonathan Cameron
2026-10-21 16:51 ` Jonathan Cameron
2026-10-02 23:31 ` [PATCH v2 08/15] efi/libstub: Have efi_kaslr_relocate_kernel() handle extra_size Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-21 17:06 ` Jonathan Cameron
2026-10-21 17:06 ` Jonathan Cameron
2026-10-02 23:31 ` [PATCH v2 09/15] efi: Add a __efi_data_handoff section annotation Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-02 23:31 ` [PATCH v2 10/15] efi/libstub: Put the stub's writable data in unique sections for DRTM Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-02 23:31 ` [PATCH v2 11/15] arm64: drtm: Add macro definitions for DEN0113 Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-21 17:43 ` Jonathan Cameron
2026-10-21 17:43 ` Jonathan Cameron
2026-10-02 23:31 ` [PATCH v2 12/15] arm64: drtm: Update the linker script for EFI_STUB_DRTM Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-20 22:49 ` Yeoreum Yun
2026-10-20 22:49 ` Yeoreum Yun
2026-10-21 12:20 ` Jason Gunthorpe
2026-10-21 12:20 ` Jason Gunthorpe
2026-10-02 23:31 ` [PATCH v2 13/15] arm64: drtm: Add drtm_entry point to head.S Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-02 23:31 ` [PATCH v2 14/15] arm64: drtm: Call UNPROTECT_MEMORY Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-21 17:47 ` Jonathan Cameron
2026-10-21 17:47 ` Jonathan Cameron
2026-10-21 17:50 ` Jason Gunthorpe [this message]
2026-10-21 17:50 ` Jason Gunthorpe
2026-10-02 23:31 ` [PATCH v2 15/15] efi/arm64: Implement ARM64 DRTM in the stub Jason Gunthorpe
2026-10-02 23:31 ` Jason Gunthorpe
2026-10-16 16:54 ` Jason Gunthorpe
2026-10-16 16:54 ` Jason Gunthorpe
2026-10-20 23:24 ` Yeoreum Yun
2026-10-20 23:24 ` Yeoreum Yun
2026-10-20 23:34 ` Jason Gunthorpe
2026-10-20 23:34 ` Jason Gunthorpe
2026-10-21 6:14 ` Yeoreum Yun
2026-10-21 6:14 ` Yeoreum Yun
2026-10-21 8:08 ` Yeoreum Yun
2026-10-21 8:08 ` Yeoreum Yun
2026-10-21 14:06 ` Jason Gunthorpe
2026-10-21 14:06 ` Jason Gunthorpe
2026-10-21 14:17 ` Yeoreum Yun
2026-10-21 14:17 ` Yeoreum Yun
2026-10-21 18:11 ` Jonathan Cameron
2026-10-21 18:11 ` Jonathan Cameron
2026-10-06 10:30 ` [PATCH v2 00/15] arm64: DRTM, boot portion Ard Biesheuvel
2026-10-06 10:30 ` Ard Biesheuvel
2026-10-16 16:51 ` Jason Gunthorpe
2026-10-16 16:51 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021175010.GV3008132@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex@ghiti.fr \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor.dooley@microchip.com \
--cc=corbet@lwn.net \
--cc=dsterba@suse.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jonathan.cameron@oss.qualcomm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=patches@lists.linux.dev \
--cc=piotr.krol@3mdeb.com \
--cc=pjw@kernel.org \
--cc=rdunlap@infradead.org \
--cc=ross.philipson@gmail.com \
--cc=samitolvanen@google.com \
--cc=sjg@chromium.org \
--cc=skhan@linuxfoundation.org \
--cc=songshuaishuai@tinylab.org \
--cc=terrelln@fb.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.