From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Jesper X Nilsson <jesper.x.nilsson@axis.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Stefan Windfeldt-Prytz" <stefan.windfeldt-prytz@axis.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH 2/3] iio: light: opt4001: refactor driver to prepare to support more devices
Date: Fri, 23 Oct 2026 11:10:32 +0200 [thread overview]
Message-ID: <20261023111032.0000019b@gmail.com> (raw)
In-Reply-To: <20261023-opt4041-v1-2-45227f82d05c@axis.com>
On Fri, 23 Oct 2026 09:48:14 +0200
Jesper X Nilsson <jesper.x.nilsson@axis.com> wrote:
> Prepare opt4001 driver to be able to support OPT4041. Extend struct
> opt4001_chip_info with fields channels and device_id because OPT4041 has
> two channels and another device id.
>
> Datasheet: https://www.ti.com/lit/gpn/opt4041
> Assisted-by: LLM
This tag has been deprecated.
> Signed-off-by: Jesper X Nilsson <jesper.x.nilsson@axis.com>
...
> @@ -388,19 +411,19 @@ static int opt4001_probe(struct i2c_client *client)
> return dev_err_probe(&client->dev, ret,
> "failed to reinit regmap cache\n");
>
> + chip->chip_info = i2c_get_match_data(client);
+ null check and return -ENODATA on failure.
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-10-23 9:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 7:48 [PATCH 0/3] This series adds support for Texas Instruments OPT4041 Ambient light sensor Jesper X Nilsson
2026-10-23 7:48 ` [PATCH 1/3] dt-bindings: iio: light: opt4001: add opt4041 Jesper X Nilsson
2026-10-23 7:48 ` [PATCH 2/3] iio: light: opt4001: refactor driver to prepare to support more devices Jesper X Nilsson
2026-10-23 9:07 ` Andy Shevchenko
2026-10-23 10:07 ` Jesper X Nilsson
2026-10-23 20:51 ` Jonathan Cameron
2026-10-23 9:10 ` Joshua Crofts [this message]
2026-10-23 9:16 ` Joshua Crofts
2026-10-23 10:22 ` Jesper X Nilsson
2026-10-23 7:48 ` [PATCH 3/3] iio: light: opt4001: add support for opt4041 Jesper X Nilsson
2026-10-23 9:14 ` Andy Shevchenko
2026-10-23 10:19 ` Jesper X Nilsson
2026-10-23 9:17 ` [PATCH 0/3] This series adds support for Texas Instruments OPT4041 Ambient light sensor Andy Shevchenko
2026-10-23 10:20 ` Jesper X Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023111032.0000019b@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jesper.x.nilsson@axis.com \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=stefan.windfeldt-prytz@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.