* [merged mm-stable] mm-damon-core-reduce-stack-usage-further.patch removed from -mm tree
@ 2026-10-24 8:58 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-10-24 8:58 UTC (permalink / raw)
To: mm-commits, sj, ravis.opensrc, ndesaulniers, nathan, morbo,
justinstitt, arnd, akpm
The quilt patch titled
Subject: mm/damon/core: reduce stack usage further
has been removed from the -mm tree. Its filename was
mm-damon-core-reduce-stack-usage-further.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Arnd Bergmann <arnd@arndb.de>
Subject: mm/damon/core: reduce stack usage further
Date: Mon, 28 Sep 2026 01:39:56 -0700
In a previous patch, I had annotated kdamond_tune_intervals() as
noinline_for_stack in order to not exceed the stack frame warning limit.
Unfortunately, my current linux-next randconfig builds show a similar
problem again with clang-21:
mm/damon/core.c:3953:12: error: stack frame size (1288) exceeds limit (1280) in 'kdamond_fn' [-Werror,-Wframe-larger-than]
3953 | static int kdamond_fn(void *data)
Do the same thing with kdamond_apply_schemes(), kdamond_merge_regions(),
and kdamond_split_regions(), which also have individually large stacks.
This should work to keep the deepest total stack depth down much more as
well as avoid the warning.
I also tried to reduce the complexity of kdamond_fn() itself by splitting
out the while() loop into a separate function. While this arguably led to
slightly more readable code, it had no effect on the total stack usage and
just made the new function the largest stack user and had a nonzero risk
of me getting the conversion wrong.
Link: https://lore.kernel.org/20260928083959.4030-3-sj@kernel.org
Fixes: 5a00cae64de1 ("mm/damon/core: reduce kernel stack usage")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: SJ Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: SJ Park <sj@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Bill Wendling <morbo@google.com>
Cc: Justin Stitt <justinstitt@google.com>
Cc: Ravi Jonnalagadda <ravis.opensrc@gmail.com>
Cc: Nathan Chancellor <nathan@kernel.org>
---
mm/damon/core.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--- a/mm/damon/core.c~mm-damon-core-reduce-stack-usage-further
+++ a/mm/damon/core.c
@@ -3433,7 +3433,7 @@ static void damos_trace_stat(struct damo
trace_call__damos_stat_after_apply_interval(cidx, sidx, &s->stat);
}
-static void kdamond_apply_schemes(struct damon_ctx *c)
+static noinline_for_stack void kdamond_apply_schemes(struct damon_ctx *c)
{
struct damon_target *t;
struct damos *s;
@@ -3589,8 +3589,9 @@ set_prev_continue:
* while DAMON is running. For such a case, repeat merging until the limit is
* met while increasing @threshold up to possible maximum level.
*/
-static void kdamond_merge_regions(struct damon_ctx *c, unsigned int threshold,
- unsigned long sz_limit)
+static noinline_for_stack void kdamond_merge_regions(struct damon_ctx *c,
+ unsigned int threshold,
+ unsigned long sz_limit)
{
struct damon_target *t;
unsigned int nr_regions;
@@ -3734,7 +3735,7 @@ static void damon_split_some_regions(str
* split was unnecessarily made, later 'kdamond_merge_regions()' will revert
* it.
*/
-static void kdamond_split_regions(struct damon_ctx *ctx)
+static noinline_for_stack void kdamond_split_regions(struct damon_ctx *ctx)
{
struct damon_target *t;
unsigned long nr_regions = 0;
_
Patches currently in -mm which might be from arnd@arndb.de are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-24 8:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-24 8:58 [merged mm-stable] mm-damon-core-reduce-stack-usage-further.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.