* fs/nfs/dir.c:754:18: error: implicit declaration of function 'd_alloc_trylock'; did you mean 'folio_trylock'?
@ 2026-10-24 19:39 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-10-24 19:39 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "bisect to a FBC not belonging to original linux-review patches: branch: linux-review/UPDATE-20261023-132215/NeilBrown/nfs-fix-open-blocking-with-d_fsdata/20261023-125011, commit: 35a484f473611abf930868ed5f6c1d55bc741880"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: NeilBrown <neil@brown.name>
CC: 0day robot <lkp@intel.com>
tree: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20261023-132215/NeilBrown/nfs-fix-open-blocking-with-d_fsdata/20261023-125011
head: e3a7aa9117daa6410fe3ee62c36e5397e61a664d
commit: 35a484f473611abf930868ed5f6c1d55bc741880 nfs: Use d_alloc_trylock() in nfs_prime_dcache()
date: 24 hours ago
:::::: branch date: 24 hours ago
:::::: commit date: 24 hours ago
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20261025/202610250334.kJaJSkIT-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261025/202610250334.kJaJSkIT-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202610250334.kJaJSkIT-lkp@intel.com/
All errors (new ones prefixed by >>):
fs/nfs/dir.c: In function 'nfs_prime_dcache':
>> fs/nfs/dir.c:754:18: error: implicit declaration of function 'd_alloc_trylock'; did you mean 'folio_trylock'? [-Wimplicit-function-declaration]
754 | dentry = d_alloc_trylock(parent, &filename);
| ^~~~~~~~~~~~~~~
| folio_trylock
>> fs/nfs/dir.c:754:16: error: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
754 | dentry = d_alloc_trylock(parent, &filename);
| ^
vim +754 fs/nfs/dir.c
230bc98f7a2a49e Trond Myklebust 2022-02-17 723
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 724 static
a1147b8281bda99 Trond Myklebust 2020-02-05 725 void nfs_prime_dcache(struct dentry *parent, struct nfs_entry *entry,
a1147b8281bda99 Trond Myklebust 2020-02-05 726 unsigned long dir_verifier)
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 727 {
26fe57502870394 Linus Torvalds 2012-05-10 728 struct qstr filename = QSTR_INIT(entry->name, entry->len);
4a201d6e3f4253f Trond Myklebust 2010-10-23 729 struct dentry *dentry;
4a201d6e3f4253f Trond Myklebust 2010-10-23 730 struct dentry *alias;
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 731 struct inode *inode;
aa9c2669626ca7e David Quigley 2013-05-22 732 int status;
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 733
fa9233699cc1dc2 Trond Myklebust 2015-02-23 734 if (!(entry->fattr->valid & NFS_ATTR_FATTR_FILEID))
fa9233699cc1dc2 Trond Myklebust 2015-02-23 735 return;
6c441c254eea235 Trond Myklebust 2015-02-22 736 if (!(entry->fattr->valid & NFS_ATTR_FATTR_FSID))
6c441c254eea235 Trond Myklebust 2015-02-22 737 return;
78d04af4995a135 Trond Myklebust 2016-09-20 738 if (filename.len == 0)
78d04af4995a135 Trond Myklebust 2016-09-20 739 return;
78d04af4995a135 Trond Myklebust 2016-09-20 740 /* Validate that the name doesn't contain any illegal '\0' */
78d04af4995a135 Trond Myklebust 2016-09-20 741 if (strnlen(filename.name, filename.len) != filename.len)
78d04af4995a135 Trond Myklebust 2016-09-20 742 return;
78d04af4995a135 Trond Myklebust 2016-09-20 743 /* ...or '/' */
78d04af4995a135 Trond Myklebust 2016-09-20 744 if (strnchr(filename.name, filename.len, '/'))
78d04af4995a135 Trond Myklebust 2016-09-20 745 return;
4a201d6e3f4253f Trond Myklebust 2010-10-23 746 if (filename.name[0] == '.') {
4a201d6e3f4253f Trond Myklebust 2010-10-23 747 if (filename.len == 1)
4a201d6e3f4253f Trond Myklebust 2010-10-23 748 return;
4a201d6e3f4253f Trond Myklebust 2010-10-23 749 if (filename.len == 2 && filename.name[1] == '.')
4a201d6e3f4253f Trond Myklebust 2010-10-23 750 return;
4a201d6e3f4253f Trond Myklebust 2010-10-23 751 }
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 752
9ac3d3e8460e3fa Al Viro 2016-04-28 753 again:
35a484f473611ab NeilBrown 2026-10-23 @754 dentry = d_alloc_trylock(parent, &filename);
9ac3d3e8460e3fa Al Viro 2016-04-28 755 if (IS_ERR(dentry))
9ac3d3e8460e3fa Al Viro 2016-04-28 756 return;
35a484f473611ab NeilBrown 2026-10-23 757
9ac3d3e8460e3fa Al Viro 2016-04-28 758 if (!d_in_lookup(dentry)) {
6c441c254eea235 Trond Myklebust 2015-02-22 759 /* Is there a mountpoint here? If so, just exit */
6c441c254eea235 Trond Myklebust 2015-02-22 760 if (!nfs_fsid_equal(&NFS_SB(dentry->d_sb)->fsid,
6c441c254eea235 Trond Myklebust 2015-02-22 761 &entry->fattr->fsid))
6c441c254eea235 Trond Myklebust 2015-02-22 762 goto out;
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 763 if (nfs_same_file(dentry, entry)) {
7dc72d5f7a0ec97 Trond Myklebust 2016-09-22 764 if (!entry->fh->size)
7dc72d5f7a0ec97 Trond Myklebust 2016-09-22 765 goto out;
a1147b8281bda99 Trond Myklebust 2020-02-05 766 nfs_set_verifier(dentry, dir_verifier);
2b0143b5c986be1 David Howells 2015-03-17 767 status = nfs_refresh_inode(d_inode(dentry), entry->fattr);
aa9c2669626ca7e David Quigley 2013-05-22 768 if (!status)
dd225cb3b02b827 Anna Schumaker 2021-10-22 769 nfs_setsecurity(d_inode(dentry), entry->fattr);
eace45a18ccb34a Trond Myklebust 2022-02-19 770 trace_nfs_readdir_lookup_revalidate(d_inode(parent),
eace45a18ccb34a Trond Myklebust 2022-02-19 771 dentry, 0, status);
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 772 goto out;
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 773 } else {
eace45a18ccb34a Trond Myklebust 2022-02-19 774 trace_nfs_readdir_lookup_revalidate_failed(
eace45a18ccb34a Trond Myklebust 2022-02-19 775 d_inode(parent), dentry, 0);
5542aa2fa7f6cdd Eric W. Biederman 2014-02-13 776 d_invalidate(dentry);
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 777 dput(dentry);
9ac3d3e8460e3fa Al Viro 2016-04-28 778 dentry = NULL;
9ac3d3e8460e3fa Al Viro 2016-04-28 779 goto again;
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 780 }
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 781 }
7dc72d5f7a0ec97 Trond Myklebust 2016-09-22 782 if (!entry->fh->size) {
7dc72d5f7a0ec97 Trond Myklebust 2016-09-22 783 d_lookup_done(dentry);
7dc72d5f7a0ec97 Trond Myklebust 2016-09-22 784 goto out;
7dc72d5f7a0ec97 Trond Myklebust 2016-09-22 785 }
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 786
9bd545539b23372 Trond Myklebust 2025-11-19 787 nfs_set_verifier(dentry, dir_verifier);
cf7ab00aabbf9c8 Anna Schumaker 2021-10-22 788 inode = nfs_fhget(dentry->d_sb, entry->fh, entry->fattr);
41d28bca2da4bd7 Al Viro 2014-10-12 789 alias = d_splice_alias(inode, dentry);
9ac3d3e8460e3fa Al Viro 2016-04-28 790 d_lookup_done(dentry);
9ac3d3e8460e3fa Al Viro 2016-04-28 791 if (alias) {
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 792 if (IS_ERR(alias))
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 793 goto out;
9bd545539b23372 Trond Myklebust 2025-11-19 794 nfs_set_verifier(alias, dir_verifier);
9ac3d3e8460e3fa Al Viro 2016-04-28 795 dput(dentry);
9ac3d3e8460e3fa Al Viro 2016-04-28 796 dentry = alias;
9ac3d3e8460e3fa Al Viro 2016-04-28 797 }
eace45a18ccb34a Trond Myklebust 2022-02-19 798 trace_nfs_readdir_lookup(d_inode(parent), dentry, 0);
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 799 out:
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 800 dput(dentry);
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 801 }
d39ab9de3b80da5 Bryan Schumaker 2010-09-24 802
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-24 19:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-24 19:39 fs/nfs/dir.c:754:18: error: implicit declaration of function 'd_alloc_trylock'; did you mean 'folio_trylock'? kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.