* [PATCH v5 1/5] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.*
2026-10-25 13:55 [PATCH v5 0/5] hw/loogarch: Fix UART ACPI properties and FDT pillow
@ 2026-10-25 13:55 ` pillow
2026-10-25 13:55 ` [PATCH v5 2/5] hw/loongarch/virt-acpi-build: Drop invalid _DSD UART clock property pillow
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: pillow @ 2026-10-25 13:55 UTC (permalink / raw)
To: qemu-devel
Cc: 17746591750, maobibo, lixianglai, jiaxun.yang, mst, imammedo,
anisinha, waysorrypub
Signed-off-by: pillow <waysorrypub@gmail.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523..2ed837f 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,5 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/loongarch64/virt/DSDT",
+"tests/data/acpi/loongarch64/virt/DSDT.memhp",
+"tests/data/acpi/loongarch64/virt/DSDT.numamem",
+"tests/data/acpi/loongarch64/virt/DSDT.topology",
--
2.56.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v5 2/5] hw/loongarch/virt-acpi-build: Drop invalid _DSD UART clock property
2026-10-25 13:55 [PATCH v5 0/5] hw/loogarch: Fix UART ACPI properties and FDT pillow
2026-10-25 13:55 ` [PATCH v5 1/5] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* pillow
@ 2026-10-25 13:55 ` pillow
2026-10-25 13:55 ` [PATCH v5 3/5] hw/loongarch/virt-acpi-build: Drop UART _CCA declaration pillow
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: pillow @ 2026-10-25 13:55 UTC (permalink / raw)
To: qemu-devel
Cc: 17746591750, maobibo, lixianglai, jiaxun.yang, mst, imammedo,
anisinha, waysorrypub
Delete the code that constructs the _DSD property and its dedicated
variables. The original property had three problems: its name was
misspelled, the key and value order was reversed, and it described a 100
MHz clock, which does not match the device model.
The property can be removed directly because the UART model's input
clock matches the Linux 8250 PnP driver default of 1,843,200 Hz, so no
_DSD override is needed.
Signed-off-by: pillow <waysorrypub@gmail.com>
---
hw/loongarch/virt-acpi-build.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/hw/loongarch/virt-acpi-build.c b/hw/loongarch/virt-acpi-build.c
index 54965f0..981e609 100644
--- a/hw/loongarch/virt-acpi-build.c
+++ b/hw/loongarch/virt-acpi-build.c
@@ -314,7 +314,6 @@ static void build_uart_device_aml(Aml *table, int index)
{
Aml *dev;
Aml *crs;
- Aml *pkg0, *pkg1, *pkg2;
Aml *scope;
uint32_t uart_irq;
uint64_t base;
@@ -335,15 +334,6 @@ static void build_uart_device_aml(Aml *table, int index)
aml_append(crs, aml_interrupt(AML_CONSUMER, AML_LEVEL, AML_ACTIVE_HIGH,
AML_SHARED, &uart_irq, 1));
aml_append(dev, aml_name_decl("_CRS", crs));
- pkg0 = aml_package(0x2);
- aml_append(pkg0, aml_int(0x05F5E100));
- aml_append(pkg0, aml_string("clock-frenquency"));
- pkg1 = aml_package(0x1);
- aml_append(pkg1, pkg0);
- pkg2 = aml_package(0x2);
- aml_append(pkg2, aml_touuid("DAFFD814-6EBA-4D8C-8A91-BC9BBF4AA301"));
- aml_append(pkg2, pkg1);
- aml_append(dev, aml_name_decl("_DSD", pkg2));
aml_append(scope, dev);
aml_append(table, scope);
}
--
2.56.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v5 3/5] hw/loongarch/virt-acpi-build: Drop UART _CCA declaration
2026-10-25 13:55 [PATCH v5 0/5] hw/loogarch: Fix UART ACPI properties and FDT pillow
2026-10-25 13:55 ` [PATCH v5 1/5] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* pillow
2026-10-25 13:55 ` [PATCH v5 2/5] hw/loongarch/virt-acpi-build: Drop invalid _DSD UART clock property pillow
@ 2026-10-25 13:55 ` pillow
2026-10-25 13:55 ` [PATCH v5 4/5] hw/loongarch/virt: Fix UART clock frequency in FDT pillow
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: pillow @ 2026-10-25 13:55 UTC (permalink / raw)
To: qemu-devel
Cc: 17746591750, maobibo, lixianglai, jiaxun.yang, mst, imammedo,
anisinha, waysorrypub
Remove the _CCA property from the UART device. _CCA describes a
device's DMA cache coherency attributes. This UART does not support
DMA, so there is no need to declare this property.
Signed-off-by: pillow <waysorrypub@gmail.com>
---
hw/loongarch/virt-acpi-build.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/loongarch/virt-acpi-build.c b/hw/loongarch/virt-acpi-build.c
index 981e609..c560f25 100644
--- a/hw/loongarch/virt-acpi-build.c
+++ b/hw/loongarch/virt-acpi-build.c
@@ -324,7 +324,6 @@ static void build_uart_device_aml(Aml *table, int index)
dev = aml_device("COM%d", index);
aml_append(dev, aml_name_decl("_HID", aml_string("PNP0501")));
aml_append(dev, aml_name_decl("_UID", aml_int(index)));
- aml_append(dev, aml_name_decl("_CCA", aml_int(1)));
crs = aml_resource_template();
aml_append(crs,
aml_qword_memory(AML_POS_DECODE, AML_MIN_FIXED, AML_MAX_FIXED,
--
2.56.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v5 4/5] hw/loongarch/virt: Fix UART clock frequency in FDT
2026-10-25 13:55 [PATCH v5 0/5] hw/loogarch: Fix UART ACPI properties and FDT pillow
` (2 preceding siblings ...)
2026-10-25 13:55 ` [PATCH v5 3/5] hw/loongarch/virt-acpi-build: Drop UART _CCA declaration pillow
@ 2026-10-25 13:55 ` pillow
2026-10-25 13:55 ` [PATCH v5 5/5] tests/data/acpi/loongarch64: Update expected DSDT.* pillow
2026-10-28 1:24 ` [PATCH v5 0/5] hw/loogarch: Fix UART ACPI properties and FDT Bibo Mao
5 siblings, 0 replies; 7+ messages in thread
From: pillow @ 2026-10-25 13:55 UTC (permalink / raw)
To: qemu-devel
Cc: 17746591750, maobibo, lixianglai, jiaxun.yang, mst, imammedo,
anisinha, waysorrypub
The UART uses baudbase = 115200, corresponding to an input clock of
1843200 Hz. Update the FDT clock-frequency property to match the model.
Signed-off-by: pillow <waysorrypub@gmail.com>
---
hw/loongarch/virt-fdt-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/loongarch/virt-fdt-build.c b/hw/loongarch/virt-fdt-build.c
index c6f5d02..7be71e2 100644
--- a/hw/loongarch/virt-fdt-build.c
+++ b/hw/loongarch/virt-fdt-build.c
@@ -474,7 +474,7 @@ static void fdt_add_uart_node(LoongArchVirtMachineState *lvms,
qemu_fdt_add_subnode(ms->fdt, nodename);
qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "ns16550a");
qemu_fdt_setprop_cells(ms->fdt, nodename, "reg", 0x0, base, 0x0, size);
- qemu_fdt_setprop_cell(ms->fdt, nodename, "clock-frequency", 100000000);
+ qemu_fdt_setprop_cell(ms->fdt, nodename, "clock-frequency", 1843200);
if (chosen) {
qemu_fdt_setprop_string(ms->fdt, "/chosen", "stdout-path", nodename);
}
--
2.56.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v5 5/5] tests/data/acpi/loongarch64: Update expected DSDT.*
2026-10-25 13:55 [PATCH v5 0/5] hw/loogarch: Fix UART ACPI properties and FDT pillow
` (3 preceding siblings ...)
2026-10-25 13:55 ` [PATCH v5 4/5] hw/loongarch/virt: Fix UART clock frequency in FDT pillow
@ 2026-10-25 13:55 ` pillow
2026-10-28 1:24 ` [PATCH v5 0/5] hw/loogarch: Fix UART ACPI properties and FDT Bibo Mao
5 siblings, 0 replies; 7+ messages in thread
From: pillow @ 2026-10-25 13:55 UTC (permalink / raw)
To: qemu-devel
Cc: 17746591750, maobibo, lixianglai, jiaxun.yang, mst, imammedo,
anisinha, waysorrypub
--- tests/data/acpi/loongarch64/virt/DSDT (before)
+++ tests/data/acpi/loongarch64/virt/DSDT (after)
@@ -6,7 +6,6 @@
{
Name (_HID, "PNP0501" /* 16550A-compatible COM Serial Port */) // _HID: Hardware ID
Name (_UID, Zero) // _UID: Unique ID
- Name (_CCA, One) // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
@@ -21,18 +20,6 @@
0x00000042,
}
})
- Name (_DSD, Package (0x02) // _DSD: Device-Specific Data
- {
- ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
- Package (0x01)
- {
- Package (0x02)
- {
- 0x05F5E100,
- "clock-frenquency"
- }
- }
- })
}
}
@@ -42,7 +29,6 @@
{
Name (_HID, "PNP0501" /* 16550A-compatible COM Serial Port */) // _HID: Hardware ID
Name (_UID, One) // _UID: Unique ID
- Name (_CCA, One) // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
@@ -57,18 +43,6 @@
0x00000043,
}
})
- Name (_DSD, Package (0x02) // _DSD: Device-Specific Data
- {
- ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
- Package (0x01)
- {
- Package (0x02)
- {
- 0x05F5E100,
- "clock-frenquency"
- }
- }
- })
}
}
@@ -78,7 +52,6 @@
{
Name (_HID, "PNP0501" /* 16550A-compatible COM Serial Port */) // _HID: Hardware ID
Name (_UID, 0x02) // _UID: Unique ID
- Name (_CCA, One) // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
@@ -93,18 +66,6 @@
0x00000044,
}
})
- Name (_DSD, Package (0x02) // _DSD: Device-Specific Data
- {
- ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
- Package (0x01)
- {
- Package (0x02)
- {
- 0x05F5E100,
- "clock-frenquency"
- }
- }
- })
}
}
@@ -114,7 +75,6 @@
{
Name (_HID, "PNP0501" /* 16550A-compatible COM Serial Port */) // _HID: Hardware ID
Name (_UID, 0x03) // _UID: Unique ID
- Name (_CCA, One) // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
@@ -127,18 +87,6 @@
Interrupt (ResourceConsumer, Level, ActiveHigh, Shared, ,, )
{
0x00000045,
- }
- })
- Name (_DSD, Package (0x02) // _DSD: Device-Specific Data
- {
- ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
- Package (0x01)
- {
- Package (0x02)
- {
- 0x05F5E100,
- "clock-frenquency"
- }
}
})
}
Signed-off-by: pillow <waysorrypub@gmail.com>
---
tests/data/acpi/loongarch64/virt/DSDT | Bin 4603 -> 4351 bytes
tests/data/acpi/loongarch64/virt/DSDT.memhp | Bin 5824 -> 5572 bytes
tests/data/acpi/loongarch64/virt/DSDT.numamem | Bin 4609 -> 4357 bytes
.../data/acpi/loongarch64/virt/DSDT.topology | Bin 4905 -> 4653 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 4 ----
5 files changed, 4 deletions(-)
diff --git a/tests/data/acpi/loongarch64/virt/DSDT b/tests/data/acpi/loongarch64/virt/DSDT
index 09aa903c4e875f541223e36f59b28e101599df20..9850873cfe67a9397149967c66690933f2b69d94 100644
GIT binary patch
delta 133
zcmeyZ{9lpFCD<k8zW@URBjZFaX)YJG_+Y2_=q4Z5iTctLzlcsu)lw2b2s-=w8gj&Y
zc)IWg_yri48W=Kg#D{viO#I-?FW?H*>dWfv?`t$!fk}jsY2rtT$?F)kxRE3$%P`4I
Q{31Fzm`Q8%HYQho0N#2fuK)l5
delta 368
zcmeyb_*<FFCD<k8w;%%pW6VS@X)b53_+Y2_=q7K@iTct^&W;mTOHPc}O5})l33d@O
zW)c+U5)irZ|JJU&9^bBsduH$VTFfXU!zd)l#KZ9LD=TkuPJVK>Zdy@lUSVl!UUDUa
z0K!0Le_un6cn?n(-T=P<15*P-29EepPZvgxcxRA3&MxFz;sSNG59h?6G7wi!)?(D6
Yiiwls8DU0FVAL`v(~+BZFuL;t03+sg%K!iX
diff --git a/tests/data/acpi/loongarch64/virt/DSDT.memhp b/tests/data/acpi/loongarch64/virt/DSDT.memhp
index a069d6878fb45fa6b0e6342eedb0eb3d25eb20da..5a6a3bc29e75ff5a20b7aa1d87dfff0cf8595668 100644
GIT binary patch
delta 133
zcmX@0dqkVdCD<k8h$sUCBilqSX)YJG_+Y2_=q4Z5iTctLzlcsu)lw2b2s-=w8gj&Y
zc)IWg_yri48W=Kg#D{viO#I-?FW?H*>dWfv?`t$!fk}jsY2rtT$?F)kxRE3$%P`4I
Q{31Fzm`Q8%HYP3+0F#p><^TWy
delta 368
zcmX@2eL$DXCD<k8fEWV<W8y?EX)b53_+Y2_=q7K@iTct^&W;mTOHPc}O5})l33d@O
zW)c+U5)irZ|JJU&9^bBsduH$VTFfXU!zd)l#KZ9LD=TkuPJVK>Zdy@lUSVl!UUDUa
z0K!0Le_un6cn?n(-T=P<15*P-29EepPZvgxcxRA3&MxFz;sSNG59h?6G7wi!)?(D6
Yiiwls8DU0FVAL`v(~+BZF!G2108#&S0ssI2
diff --git a/tests/data/acpi/loongarch64/virt/DSDT.numamem b/tests/data/acpi/loongarch64/virt/DSDT.numamem
index 78ece52f57a383db128c7d1a08526e15ab911bb7..3a6580b4ee93f9d2a44faffd6ffe9d3ae9ecd4d2 100644
GIT binary patch
delta 133
zcmZovX;tEK33dr#6=Yyw?3u_V&E>)tAM6w#-Q>eMQD1uE7tx8ST1o;4L1%woLymY4
zPZ!<*zW@VM149Om_)t%mi65N#1ze$8eOaCTeT^n7Fo`fSP5dY^c^#t`H<ILJ877&D
QUqmMdGihz!#^lWp04cmARR910
delta 368
zcmZowYE<EJ33dr#6k=dtd_Iv&n#-9hKG-Qfy2+b!qP{efv*X0ok`v>#5;@{sf?b4+
znFNKo1VnE9zqKo`$G2<Zp4t1o7BdRTFbYXB@i096%F3IZlb@Wen^u&XS6G^wmt4sp
zfH2V6-`9{M-ow*{H^48zz|_Eyfg?WD(}j^E-Wg<%vkUo_xIkU)!#VM%48+xwwHURi
XV&dd@MwpQk7`4pFbmZn8jK2H;E9!J{
diff --git a/tests/data/acpi/loongarch64/virt/DSDT.topology b/tests/data/acpi/loongarch64/virt/DSDT.topology
index 7ab23f47cc82dd7bc1975e17893a8cd61039e66d..7901fd9e07225a9d726f94e83e11724d9daae013 100644
GIT binary patch
delta 133
zcmZ3fwpNA9CD<iISBQauv1B5bG?xooe6Uk|bdwM3M1ARrUqmOSYAFdI1fBhT4LRaH
zJY9GL`~nP24GbAL;zK=MCVp_{7jT7Y^<{PT_cfZVz$C)RH1VUv<aLZ%+(?p>Wte0p
Qei5A<%%rt>8&k0W0A36v;{X5v
delta 368
zcmZ3hvQmx9CD<iIQ<#B)@%%(CX)b53_+Y2_=q7K@iTct^&W;mTOHPc}O5})l33d@O
zW)c+U5)irZ|JJU&9^bBsduH$VTFfXU!zd)l#KZ9LD=TkuPJVK>Zdy@lUSVl!UUDUa
z0K!0Le_un6cn?n(-T=P<15*P-29EepPZvgxcxRA3&MxFz;sSNG59h?6G7wi!)?(D6
Yiiwls8DU0FVAL`v(~+BZFqR4c0KD;Z{{R30
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 2ed837f..dfb8523 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,5 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/loongarch64/virt/DSDT",
-"tests/data/acpi/loongarch64/virt/DSDT.memhp",
-"tests/data/acpi/loongarch64/virt/DSDT.numamem",
-"tests/data/acpi/loongarch64/virt/DSDT.topology",
--
2.56.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v5 0/5] hw/loogarch: Fix UART ACPI properties and FDT
2026-10-25 13:55 [PATCH v5 0/5] hw/loogarch: Fix UART ACPI properties and FDT pillow
` (4 preceding siblings ...)
2026-10-25 13:55 ` [PATCH v5 5/5] tests/data/acpi/loongarch64: Update expected DSDT.* pillow
@ 2026-10-28 1:24 ` Bibo Mao
5 siblings, 0 replies; 7+ messages in thread
From: Bibo Mao @ 2026-10-28 1:24 UTC (permalink / raw)
To: pillow, qemu-devel
Cc: 17746591750, lixianglai, jiaxun.yang, mst, imammedo, anisinha
On 2026/10/25 下午9:55, pillow wrote:
> This series fixes the UART description for LoongArch virt.
>
> The ACPI _DSD property built for the UART has three problems: the
> property name is misspelled, the key and value order is reversed, and
> it describes a 100 MHz clock that does not match the device model.
> The property can be dropped directly because the UART model's input
> clock matches the Linux 8250 PnP driver default of 1,843,200 Hz, so no
> _DSD override is needed.
>
> The _CCA property is also unnecessary. _CCA describes a device's DMA
> cache coherency attribute, and this UART does not support DMA, so there
> is no reason to declare it.
>
> The UART clock frequency in the FDT is corrected to 1,843,200 Hz, and
> the expected ACPI tables are updated accordingly.
>
> pillow (5):
> bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.*
> hw/loongarch/virt-acpi-build: Drop invalid _DSD UART clock property
> hw/loongarch/virt-acpi-build: Drop UART _CCA declaration
> hw/loongarch/virt: Fix UART clock frequency in FDT
> tests/data/acpi/loongarch64: Update expected DSDT.*
>
> hw/loongarch/virt-acpi-build.c | 11 -----------
> hw/loongarch/virt-fdt-build.c | 2 +-
> tests/data/acpi/loongarch64/virt/DSDT | Bin 4603 -> 4351 bytes
> tests/data/acpi/loongarch64/virt/DSDT.memhp | Bin 5824 -> 5572 bytes
> tests/data/acpi/loongarch64/virt/DSDT.numamem | Bin 4609 -> 4357 bytes
> .../data/acpi/loongarch64/virt/DSDT.topology | Bin 4905 -> 4653 bytes
> 6 files changed, 1 insertion(+), 12 deletions(-)
>
Removing _STA works on some x86 windows and linux guest OSs by testing,
with LoongArch it works well on Linux guest OS.
For this series:
Reviewed-by: Bibo Mao <maobibo@loongson.cn>
^ permalink raw reply [flat|nested] 7+ messages in thread