* [android-common:android13-5.10-lts 6/6] security/smack/smack_lsm.c:1261: warning: Excess function parameter 'mnt_userns' description in 'smack_inode_setxattr'
@ 2026-10-26 0:31 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-10-26 0:31 UTC (permalink / raw)
To: cros-kernel-buildreports; +Cc: oe-kbuild-all
tree: https://android.googlesource.com/kernel/common android13-5.10-lts
head: f61a392235e085addf6e809b78c6e6114320e6e7
commit: 665f9113e0d21ab27c56d99180e45790fda6e15f [6/6] Smack: fix W=1 build warnings
config: i386-randconfig-2000-20261025 (https://download.01.org/0day-ci/archive/20261026/202610260105.HlEhbjTV-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261026/202610260105.HlEhbjTV-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610260105.HlEhbjTV-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> security/smack/smack_lsm.c:1261: warning: Excess function parameter 'mnt_userns' description in 'smack_inode_setxattr'
>> security/smack/smack_lsm.c:1384: warning: Excess function parameter 'mnt_userns' description in 'smack_inode_removexattr'
>> security/smack/smack_lsm.c:1445: warning: Excess function parameter 'mnt_userns' description in 'smack_inode_getsecurity'
vim +1261 security/smack/smack_lsm.c
e114e473771c84 Casey Schaufler 2008-02-04 1245
e114e473771c84 Casey Schaufler 2008-02-04 1246 /**
e114e473771c84 Casey Schaufler 2008-02-04 1247 * smack_inode_setxattr - Smack check for setting xattrs
665f9113e0d21a Casey Schaufler 2021-10-13 1248 * @mnt_userns: active user namespace
e114e473771c84 Casey Schaufler 2008-02-04 1249 * @dentry: the object
e114e473771c84 Casey Schaufler 2008-02-04 1250 * @name: name of the attribute
e95ef49b7f8f49 Lukasz Pawelczyk 2014-08-29 1251 * @value: value of the attribute
e95ef49b7f8f49 Lukasz Pawelczyk 2014-08-29 1252 * @size: size of the value
e114e473771c84 Casey Schaufler 2008-02-04 1253 * @flags: unused
e114e473771c84 Casey Schaufler 2008-02-04 1254 *
e114e473771c84 Casey Schaufler 2008-02-04 1255 * This protects the Smack attribute explicitly.
e114e473771c84 Casey Schaufler 2008-02-04 1256 *
e114e473771c84 Casey Schaufler 2008-02-04 1257 * Returns 0 if access is permitted, an error code otherwise
e114e473771c84 Casey Schaufler 2008-02-04 1258 */
8f0cfa52a1d4ff David Howells 2008-04-29 1259 static int smack_inode_setxattr(struct dentry *dentry, const char *name,
8f0cfa52a1d4ff David Howells 2008-04-29 1260 const void *value, size_t size, int flags)
e114e473771c84 Casey Schaufler 2008-02-04 @1261 {
ecfcc53fef3c35 Etienne Basset 2009-04-08 1262 struct smk_audit_info ad;
19760ad03cc639 Casey Schaufler 2013-12-16 1263 struct smack_known *skp;
19760ad03cc639 Casey Schaufler 2013-12-16 1264 int check_priv = 0;
19760ad03cc639 Casey Schaufler 2013-12-16 1265 int check_import = 0;
19760ad03cc639 Casey Schaufler 2013-12-16 1266 int check_star = 0;
bcdca225bfa016 Casey Schaufler 2008-02-23 1267 int rc = 0;
bcdca225bfa016 Casey Schaufler 2008-02-23 1268
19760ad03cc639 Casey Schaufler 2013-12-16 1269 /*
19760ad03cc639 Casey Schaufler 2013-12-16 1270 * Check label validity here so import won't fail in post_setxattr
19760ad03cc639 Casey Schaufler 2013-12-16 1271 */
e114e473771c84 Casey Schaufler 2008-02-04 1272 if (strcmp(name, XATTR_NAME_SMACK) == 0 ||
e114e473771c84 Casey Schaufler 2008-02-04 1273 strcmp(name, XATTR_NAME_SMACKIPIN) == 0 ||
19760ad03cc639 Casey Schaufler 2013-12-16 1274 strcmp(name, XATTR_NAME_SMACKIPOUT) == 0) {
19760ad03cc639 Casey Schaufler 2013-12-16 1275 check_priv = 1;
19760ad03cc639 Casey Schaufler 2013-12-16 1276 check_import = 1;
19760ad03cc639 Casey Schaufler 2013-12-16 1277 } else if (strcmp(name, XATTR_NAME_SMACKEXEC) == 0 ||
7898e1f8e9eb1b Casey Schaufler 2011-01-17 1278 strcmp(name, XATTR_NAME_SMACKMMAP) == 0) {
19760ad03cc639 Casey Schaufler 2013-12-16 1279 check_priv = 1;
19760ad03cc639 Casey Schaufler 2013-12-16 1280 check_import = 1;
19760ad03cc639 Casey Schaufler 2013-12-16 1281 check_star = 1;
5c6d1125f8dbd1 Jarkko Sakkinen 2010-12-07 1282 } else if (strcmp(name, XATTR_NAME_SMACKTRANSMUTE) == 0) {
19760ad03cc639 Casey Schaufler 2013-12-16 1283 check_priv = 1;
a354d9e3b66c1e Roberto Sassu 2023-11-16 1284 if (!S_ISDIR(d_backing_inode(dentry)->i_mode) ||
a354d9e3b66c1e Roberto Sassu 2023-11-16 1285 size != TRANS_TRUE_SIZE ||
5c6d1125f8dbd1 Jarkko Sakkinen 2010-12-07 1286 strncmp(value, TRANS_TRUE, TRANS_TRUE_SIZE) != 0)
5c6d1125f8dbd1 Jarkko Sakkinen 2010-12-07 1287 rc = -EINVAL;
bcdca225bfa016 Casey Schaufler 2008-02-23 1288 } else
bcdca225bfa016 Casey Schaufler 2008-02-23 1289 rc = cap_inode_setxattr(dentry, name, value, size, flags);
e114e473771c84 Casey Schaufler 2008-02-04 1290
19760ad03cc639 Casey Schaufler 2013-12-16 1291 if (check_priv && !smack_privileged(CAP_MAC_ADMIN))
19760ad03cc639 Casey Schaufler 2013-12-16 1292 rc = -EPERM;
19760ad03cc639 Casey Schaufler 2013-12-16 1293
19760ad03cc639 Casey Schaufler 2013-12-16 1294 if (rc == 0 && check_import) {
b862e561bad637 Konstantin Khlebnikov 2014-08-07 1295 skp = size ? smk_import_entry(value, size) : NULL;
e774ad683f425a Lukasz Pawelczyk 2015-04-20 1296 if (IS_ERR(skp))
e774ad683f425a Lukasz Pawelczyk 2015-04-20 1297 rc = PTR_ERR(skp);
e774ad683f425a Lukasz Pawelczyk 2015-04-20 1298 else if (skp == NULL || (check_star &&
19760ad03cc639 Casey Schaufler 2013-12-16 1299 (skp == &smack_known_star || skp == &smack_known_web)))
19760ad03cc639 Casey Schaufler 2013-12-16 1300 rc = -EINVAL;
19760ad03cc639 Casey Schaufler 2013-12-16 1301 }
19760ad03cc639 Casey Schaufler 2013-12-16 1302
a269434d2fb48a Eric Paris 2011-04-25 1303 smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_DENTRY);
ecfcc53fef3c35 Etienne Basset 2009-04-08 1304 smk_ad_setfield_u_fs_path_dentry(&ad, dentry);
ecfcc53fef3c35 Etienne Basset 2009-04-08 1305
d166c8024d620d Casey Schaufler 2014-08-27 1306 if (rc == 0) {
c6f493d631c4d4 David Howells 2015-03-17 1307 rc = smk_curacc(smk_of_inode(d_backing_inode(dentry)), MAY_WRITE, &ad);
c6f493d631c4d4 David Howells 2015-03-17 1308 rc = smk_bu_inode(d_backing_inode(dentry), MAY_WRITE, rc);
d166c8024d620d Casey Schaufler 2014-08-27 1309 }
bcdca225bfa016 Casey Schaufler 2008-02-23 1310
bcdca225bfa016 Casey Schaufler 2008-02-23 1311 return rc;
e114e473771c84 Casey Schaufler 2008-02-04 1312 }
e114e473771c84 Casey Schaufler 2008-02-04 1313
e114e473771c84 Casey Schaufler 2008-02-04 1314 /**
e114e473771c84 Casey Schaufler 2008-02-04 1315 * smack_inode_post_setxattr - Apply the Smack update approved above
e114e473771c84 Casey Schaufler 2008-02-04 1316 * @dentry: object
e114e473771c84 Casey Schaufler 2008-02-04 1317 * @name: attribute name
e114e473771c84 Casey Schaufler 2008-02-04 1318 * @value: attribute value
e114e473771c84 Casey Schaufler 2008-02-04 1319 * @size: attribute size
e114e473771c84 Casey Schaufler 2008-02-04 1320 * @flags: unused
e114e473771c84 Casey Schaufler 2008-02-04 1321 *
e114e473771c84 Casey Schaufler 2008-02-04 1322 * Set the pointer in the inode blob to the entry found
e114e473771c84 Casey Schaufler 2008-02-04 1323 * in the master label list.
e114e473771c84 Casey Schaufler 2008-02-04 1324 */
8f0cfa52a1d4ff David Howells 2008-04-29 1325 static void smack_inode_post_setxattr(struct dentry *dentry, const char *name,
8f0cfa52a1d4ff David Howells 2008-04-29 1326 const void *value, size_t size, int flags)
e114e473771c84 Casey Schaufler 2008-02-04 1327 {
2f823ff8bec03a Casey Schaufler 2013-05-22 1328 struct smack_known *skp;
fb4021b6fb5818 Casey Schaufler 2018-11-12 1329 struct inode_smack *isp = smack_inode(d_backing_inode(dentry));
676dac4b1bee04 Casey Schaufler 2010-12-02 1330
2f823ff8bec03a Casey Schaufler 2013-05-22 1331 if (strcmp(name, XATTR_NAME_SMACKTRANSMUTE) == 0) {
2f823ff8bec03a Casey Schaufler 2013-05-22 1332 isp->smk_flags |= SMK_INODE_TRANSMUTE;
2f823ff8bec03a Casey Schaufler 2013-05-22 1333 return;
2f823ff8bec03a Casey Schaufler 2013-05-22 1334 }
2f823ff8bec03a Casey Schaufler 2013-05-22 1335
676dac4b1bee04 Casey Schaufler 2010-12-02 1336 if (strcmp(name, XATTR_NAME_SMACK) == 0) {
9598f4c9e7069a José Bollo 2014-04-03 1337 skp = smk_import_entry(value, size);
e774ad683f425a Lukasz Pawelczyk 2015-04-20 1338 if (!IS_ERR(skp))
21c7eae21a2100 Lukasz Pawelczyk 2014-08-29 1339 isp->smk_inode = skp;
5c6d1125f8dbd1 Jarkko Sakkinen 2010-12-07 1340 } else if (strcmp(name, XATTR_NAME_SMACKEXEC) == 0) {
9598f4c9e7069a José Bollo 2014-04-03 1341 skp = smk_import_entry(value, size);
e774ad683f425a Lukasz Pawelczyk 2015-04-20 1342 if (!IS_ERR(skp))
2f823ff8bec03a Casey Schaufler 2013-05-22 1343 isp->smk_task = skp;
7898e1f8e9eb1b Casey Schaufler 2011-01-17 1344 } else if (strcmp(name, XATTR_NAME_SMACKMMAP) == 0) {
9598f4c9e7069a José Bollo 2014-04-03 1345 skp = smk_import_entry(value, size);
e774ad683f425a Lukasz Pawelczyk 2015-04-20 1346 if (!IS_ERR(skp))
2f823ff8bec03a Casey Schaufler 2013-05-22 1347 isp->smk_mmap = skp;
2f823ff8bec03a Casey Schaufler 2013-05-22 1348 }
e114e473771c84 Casey Schaufler 2008-02-04 1349
e114e473771c84 Casey Schaufler 2008-02-04 1350 return;
e114e473771c84 Casey Schaufler 2008-02-04 1351 }
e114e473771c84 Casey Schaufler 2008-02-04 1352
ce8a432197d989 Casey Schaufler 2011-09-29 1353 /**
e114e473771c84 Casey Schaufler 2008-02-04 1354 * smack_inode_getxattr - Smack check on getxattr
e114e473771c84 Casey Schaufler 2008-02-04 1355 * @dentry: the object
e114e473771c84 Casey Schaufler 2008-02-04 1356 * @name: unused
e114e473771c84 Casey Schaufler 2008-02-04 1357 *
e114e473771c84 Casey Schaufler 2008-02-04 1358 * Returns 0 if access is permitted, an error code otherwise
e114e473771c84 Casey Schaufler 2008-02-04 1359 */
8f0cfa52a1d4ff David Howells 2008-04-29 1360 static int smack_inode_getxattr(struct dentry *dentry, const char *name)
e114e473771c84 Casey Schaufler 2008-02-04 1361 {
ecfcc53fef3c35 Etienne Basset 2009-04-08 1362 struct smk_audit_info ad;
d166c8024d620d Casey Schaufler 2014-08-27 1363 int rc;
ecfcc53fef3c35 Etienne Basset 2009-04-08 1364
a269434d2fb48a Eric Paris 2011-04-25 1365 smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_DENTRY);
ecfcc53fef3c35 Etienne Basset 2009-04-08 1366 smk_ad_setfield_u_fs_path_dentry(&ad, dentry);
ecfcc53fef3c35 Etienne Basset 2009-04-08 1367
c6f493d631c4d4 David Howells 2015-03-17 1368 rc = smk_curacc(smk_of_inode(d_backing_inode(dentry)), MAY_READ, &ad);
c6f493d631c4d4 David Howells 2015-03-17 1369 rc = smk_bu_inode(d_backing_inode(dentry), MAY_READ, rc);
d166c8024d620d Casey Schaufler 2014-08-27 1370 return rc;
e114e473771c84 Casey Schaufler 2008-02-04 1371 }
e114e473771c84 Casey Schaufler 2008-02-04 1372
ce8a432197d989 Casey Schaufler 2011-09-29 1373 /**
e114e473771c84 Casey Schaufler 2008-02-04 1374 * smack_inode_removexattr - Smack check on removexattr
665f9113e0d21a Casey Schaufler 2021-10-13 1375 * @mnt_userns: active user namespace
e114e473771c84 Casey Schaufler 2008-02-04 1376 * @dentry: the object
e114e473771c84 Casey Schaufler 2008-02-04 1377 * @name: name of the attribute
e114e473771c84 Casey Schaufler 2008-02-04 1378 *
e114e473771c84 Casey Schaufler 2008-02-04 1379 * Removing the Smack attribute requires CAP_MAC_ADMIN
e114e473771c84 Casey Schaufler 2008-02-04 1380 *
e114e473771c84 Casey Schaufler 2008-02-04 1381 * Returns 0 if access is permitted, an error code otherwise
e114e473771c84 Casey Schaufler 2008-02-04 1382 */
8f0cfa52a1d4ff David Howells 2008-04-29 1383 static int smack_inode_removexattr(struct dentry *dentry, const char *name)
e114e473771c84 Casey Schaufler 2008-02-04 @1384 {
676dac4b1bee04 Casey Schaufler 2010-12-02 1385 struct inode_smack *isp;
ecfcc53fef3c35 Etienne Basset 2009-04-08 1386 struct smk_audit_info ad;
bcdca225bfa016 Casey Schaufler 2008-02-23 1387 int rc = 0;
e114e473771c84 Casey Schaufler 2008-02-04 1388
bcdca225bfa016 Casey Schaufler 2008-02-23 1389 if (strcmp(name, XATTR_NAME_SMACK) == 0 ||
bcdca225bfa016 Casey Schaufler 2008-02-23 1390 strcmp(name, XATTR_NAME_SMACKIPIN) == 0 ||
676dac4b1bee04 Casey Schaufler 2010-12-02 1391 strcmp(name, XATTR_NAME_SMACKIPOUT) == 0 ||
5c6d1125f8dbd1 Jarkko Sakkinen 2010-12-07 1392 strcmp(name, XATTR_NAME_SMACKEXEC) == 0 ||
7898e1f8e9eb1b Casey Schaufler 2011-01-17 1393 strcmp(name, XATTR_NAME_SMACKTRANSMUTE) == 0 ||
5e9ab593c2da30 Pankaj Kumar 2013-12-13 1394 strcmp(name, XATTR_NAME_SMACKMMAP) == 0) {
1880eff77e7a7c Casey Schaufler 2012-06-05 1395 if (!smack_privileged(CAP_MAC_ADMIN))
bcdca225bfa016 Casey Schaufler 2008-02-23 1396 rc = -EPERM;
bcdca225bfa016 Casey Schaufler 2008-02-23 1397 } else
bcdca225bfa016 Casey Schaufler 2008-02-23 1398 rc = cap_inode_removexattr(dentry, name);
bcdca225bfa016 Casey Schaufler 2008-02-23 1399
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1400 if (rc != 0)
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1401 return rc;
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1402
a269434d2fb48a Eric Paris 2011-04-25 1403 smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_DENTRY);
ecfcc53fef3c35 Etienne Basset 2009-04-08 1404 smk_ad_setfield_u_fs_path_dentry(&ad, dentry);
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1405
c6f493d631c4d4 David Howells 2015-03-17 1406 rc = smk_curacc(smk_of_inode(d_backing_inode(dentry)), MAY_WRITE, &ad);
c6f493d631c4d4 David Howells 2015-03-17 1407 rc = smk_bu_inode(d_backing_inode(dentry), MAY_WRITE, rc);
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1408 if (rc != 0)
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1409 return rc;
bcdca225bfa016 Casey Schaufler 2008-02-23 1410
fb4021b6fb5818 Casey Schaufler 2018-11-12 1411 isp = smack_inode(d_backing_inode(dentry));
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1412 /*
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1413 * Don't do anything special for these.
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1414 * XATTR_NAME_SMACKIPIN
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1415 * XATTR_NAME_SMACKIPOUT
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1416 */
8012495e177bbf José Bollo 2016-01-12 1417 if (strcmp(name, XATTR_NAME_SMACK) == 0) {
fc64005c93090c Al Viro 2016-04-10 1418 struct super_block *sbp = dentry->d_sb;
8012495e177bbf José Bollo 2016-01-12 1419 struct superblock_smack *sbsp = sbp->s_security;
8012495e177bbf José Bollo 2016-01-12 1420
8012495e177bbf José Bollo 2016-01-12 1421 isp->smk_inode = sbsp->smk_default;
8012495e177bbf José Bollo 2016-01-12 1422 } else if (strcmp(name, XATTR_NAME_SMACKEXEC) == 0)
676dac4b1bee04 Casey Schaufler 2010-12-02 1423 isp->smk_task = NULL;
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1424 else if (strcmp(name, XATTR_NAME_SMACKMMAP) == 0)
7898e1f8e9eb1b Casey Schaufler 2011-01-17 1425 isp->smk_mmap = NULL;
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1426 else if (strcmp(name, XATTR_NAME_SMACKTRANSMUTE) == 0)
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1427 isp->smk_flags &= ~SMK_INODE_TRANSMUTE;
676dac4b1bee04 Casey Schaufler 2010-12-02 1428
f59bdfba3e2b0b Casey Schaufler 2014-04-10 1429 return 0;
e114e473771c84 Casey Schaufler 2008-02-04 1430 }
e114e473771c84 Casey Schaufler 2008-02-04 1431
e114e473771c84 Casey Schaufler 2008-02-04 1432 /**
e114e473771c84 Casey Schaufler 2008-02-04 1433 * smack_inode_getsecurity - get smack xattrs
665f9113e0d21a Casey Schaufler 2021-10-13 1434 * @mnt_userns: active user namespace
e114e473771c84 Casey Schaufler 2008-02-04 1435 * @inode: the object
e114e473771c84 Casey Schaufler 2008-02-04 1436 * @name: attribute name
e114e473771c84 Casey Schaufler 2008-02-04 1437 * @buffer: where to put the result
57e7ba04d422c3 Casey Schaufler 2017-09-19 1438 * @alloc: duplicate memory
e114e473771c84 Casey Schaufler 2008-02-04 1439 *
e114e473771c84 Casey Schaufler 2008-02-04 1440 * Returns the size of the attribute or an error code
e114e473771c84 Casey Schaufler 2008-02-04 1441 */
ea861dfd9e0e7e Andreas Gruenbacher 2015-12-24 1442 static int smack_inode_getsecurity(struct inode *inode,
e114e473771c84 Casey Schaufler 2008-02-04 1443 const char *name, void **buffer,
e114e473771c84 Casey Schaufler 2008-02-04 1444 bool alloc)
e114e473771c84 Casey Schaufler 2008-02-04 @1445 {
e114e473771c84 Casey Schaufler 2008-02-04 1446 struct socket_smack *ssp;
e114e473771c84 Casey Schaufler 2008-02-04 1447 struct socket *sock;
e114e473771c84 Casey Schaufler 2008-02-04 1448 struct super_block *sbp;
e114e473771c84 Casey Schaufler 2008-02-04 1449 struct inode *ip = (struct inode *)inode;
21c7eae21a2100 Lukasz Pawelczyk 2014-08-29 1450 struct smack_known *isp;
297c51c63fe156 Roberto Sassu 2023-05-08 1451 struct inode_smack *ispp;
297c51c63fe156 Roberto Sassu 2023-05-08 1452 size_t label_len;
297c51c63fe156 Roberto Sassu 2023-05-08 1453 char *label = NULL;
e114e473771c84 Casey Schaufler 2008-02-04 1454
297c51c63fe156 Roberto Sassu 2023-05-08 1455 if (strcmp(name, XATTR_SMACK_SUFFIX) == 0) {
e114e473771c84 Casey Schaufler 2008-02-04 1456 isp = smk_of_inode(inode);
297c51c63fe156 Roberto Sassu 2023-05-08 1457 } else if (strcmp(name, XATTR_SMACK_TRANSMUTE) == 0) {
297c51c63fe156 Roberto Sassu 2023-05-08 1458 ispp = smack_inode(inode);
297c51c63fe156 Roberto Sassu 2023-05-08 1459 if (ispp->smk_flags & SMK_INODE_TRANSMUTE)
297c51c63fe156 Roberto Sassu 2023-05-08 1460 label = TRANS_TRUE;
297c51c63fe156 Roberto Sassu 2023-05-08 1461 else
297c51c63fe156 Roberto Sassu 2023-05-08 1462 label = "";
297c51c63fe156 Roberto Sassu 2023-05-08 1463 } else {
e114e473771c84 Casey Schaufler 2008-02-04 1464 /*
e114e473771c84 Casey Schaufler 2008-02-04 1465 * The rest of the Smack xattrs are only on sockets.
e114e473771c84 Casey Schaufler 2008-02-04 1466 */
e114e473771c84 Casey Schaufler 2008-02-04 1467 sbp = ip->i_sb;
e114e473771c84 Casey Schaufler 2008-02-04 1468 if (sbp->s_magic != SOCKFS_MAGIC)
e114e473771c84 Casey Schaufler 2008-02-04 1469 return -EOPNOTSUPP;
e114e473771c84 Casey Schaufler 2008-02-04 1470
e114e473771c84 Casey Schaufler 2008-02-04 1471 sock = SOCKET_I(ip);
2e1d146a19f294 Ahmed S. Darwish 2008-02-13 1472 if (sock == NULL || sock->sk == NULL)
e114e473771c84 Casey Schaufler 2008-02-04 1473 return -EOPNOTSUPP;
e114e473771c84 Casey Schaufler 2008-02-04 1474
3628f8be466567 Casey Schaufler 2026-07-23 1475 ssp = smack_sock(sock->sk);
e114e473771c84 Casey Schaufler 2008-02-04 1476
e114e473771c84 Casey Schaufler 2008-02-04 1477 if (strcmp(name, XATTR_SMACK_IPIN) == 0)
21c7eae21a2100 Lukasz Pawelczyk 2014-08-29 1478 isp = ssp->smk_in;
e114e473771c84 Casey Schaufler 2008-02-04 1479 else if (strcmp(name, XATTR_SMACK_IPOUT) == 0)
21c7eae21a2100 Lukasz Pawelczyk 2014-08-29 1480 isp = ssp->smk_out;
e114e473771c84 Casey Schaufler 2008-02-04 1481 else
e114e473771c84 Casey Schaufler 2008-02-04 1482 return -EOPNOTSUPP;
57e7ba04d422c3 Casey Schaufler 2017-09-19 1483 }
e114e473771c84 Casey Schaufler 2008-02-04 1484
297c51c63fe156 Roberto Sassu 2023-05-08 1485 if (!label)
297c51c63fe156 Roberto Sassu 2023-05-08 1486 label = isp->smk_known;
297c51c63fe156 Roberto Sassu 2023-05-08 1487
297c51c63fe156 Roberto Sassu 2023-05-08 1488 label_len = strlen(label);
297c51c63fe156 Roberto Sassu 2023-05-08 1489
57e7ba04d422c3 Casey Schaufler 2017-09-19 1490 if (alloc) {
297c51c63fe156 Roberto Sassu 2023-05-08 1491 *buffer = kstrdup(label, GFP_KERNEL);
57e7ba04d422c3 Casey Schaufler 2017-09-19 1492 if (*buffer == NULL)
57e7ba04d422c3 Casey Schaufler 2017-09-19 1493 return -ENOMEM;
e114e473771c84 Casey Schaufler 2008-02-04 1494 }
e114e473771c84 Casey Schaufler 2008-02-04 1495
297c51c63fe156 Roberto Sassu 2023-05-08 1496 return label_len;
e114e473771c84 Casey Schaufler 2008-02-04 1497 }
e114e473771c84 Casey Schaufler 2008-02-04 1498
:::::: The code at line 1261 was first introduced by commit
:::::: e114e473771c848c3cfec05f0123e70f1cdbdc99 Smack: Simplified Mandatory Access Control Kernel
:::::: TO: Casey Schaufler <casey@schaufler-ca.com>
:::::: CC: Linus Torvalds <torvalds@woody.linux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-26 0:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-26 0:31 [android-common:android13-5.10-lts 6/6] security/smack/smack_lsm.c:1261: warning: Excess function parameter 'mnt_userns' description in 'smack_inode_setxattr' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.