From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 8/8] qapi: print a message before aborting for -compat violations
Date: Wed, 28 Oct 2026 13:36:03 +0000 [thread overview]
Message-ID: <20261028133603.1893289-9-berrange@redhat.com> (raw)
In-Reply-To: <20261028133603.1893289-1-berrange@redhat.com>
When using the 'crash' policy with -compat options, QEMU will
abort() on a policy violation. All the user sees is a core
dump though and while the stack trace will ultimately show
what the violation was, it can be hard to reverse engineer
the cause when variables are optimized out. If the crash is
within a CI system, it can be even harder to determine what
the cause was as a core dump may not be available.
Printing a message when crashing is easier to diagnose when
limited context is available.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
qapi/qapi-util.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/qapi/qapi-util.c b/qapi/qapi-util.c
index c845cadbdf2..1141813747b 100644
--- a/qapi/qapi-util.c
+++ b/qapi/qapi-util.c
@@ -37,6 +37,9 @@ static bool compat_policy_input_ok1(CompatPolicyInput policy,
adjective, kind, name);
return false;
case COMPAT_POLICY_INPUT_CRASH:
+ error_report("%s %s %s disabled by policy, aborting",
+ adjective, kind, name);
+ /* fallthrough */
default:
abort();
}
--
2.56.0
prev parent reply other threads:[~2026-10-28 13:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 13:35 [PATCH 0/8] qapi: last minute improvements/changes to -compat insecure-types Daniel P. Berrangé
2026-10-28 13:35 ` [PATCH 1/8] qapi: make 'CompatPolicy' the first arg in compat_policy_input_ok Daniel P. Berrangé
2026-10-28 13:35 ` [PATCH 2/8] qapi: add 'warn' option to CompatPolicyInput Daniel P. Berrangé
2026-10-29 6:56 ` Markus Armbruster
2026-10-29 10:48 ` Daniel P. Berrangé
2026-10-28 13:35 ` [PATCH 3/8] qapi: rename 'insecure-types' to 'insecure-input' Daniel P. Berrangé
2026-10-28 13:35 ` [PATCH 4/8] qapi: drop CompatPolicySecurity and use CompatPolicyInput Daniel P. Berrangé
2026-10-29 6:15 ` Markus Armbruster
2026-10-29 10:48 ` Daniel P. Berrangé
2026-10-28 13:36 ` [PATCH 5/8] qapi: rename compat_policy_check_security method Daniel P. Berrangé
2026-10-28 13:36 ` [PATCH 6/8] qapi: reverse arg order in compat_policy_security_ok Daniel P. Berrangé
2026-10-28 13:36 ` [PATCH 7/8] qemu-options: document -compat insecure-input parameter Daniel P. Berrangé
2026-10-29 6:52 ` Markus Armbruster
2026-10-29 10:56 ` Daniel P. Berrangé
2026-10-29 14:13 ` Markus Armbruster
2026-10-29 14:44 ` Daniel P. Berrangé
2026-10-28 13:36 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028133603.1893289-9-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.