From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/8] qapi: add 'warn' option to CompatPolicyInput
Date: Thu, 29 Oct 2026 07:56:52 +0100 [thread overview]
Message-ID: <87zevxf0zv.fsf@pond.sub.org> (raw)
In-Reply-To: <20261028133603.1893289-3-berrange@redhat.com> ("Daniel P. Berrangé"'s message of "Wed, 28 Oct 2026 13:35:57 +0000")
Daniel P. Berrangé <berrange@redhat.com> writes:
> This prints a warning on stderr every time a policy violation
> is encountered, but accepts the input.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
"Every time" can be annoying. It's commonly easy to avoid, e.g. with
warn_report_once(), but not here, so we don't. Because it's annoying,
we don't make it the default, unlike other deprecation warnings.
If you agree with the above, please work it into the commit message, and
consider whether documentation should mention it, too.
next prev parent reply other threads:[~2026-10-29 6:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 13:35 [PATCH 0/8] qapi: last minute improvements/changes to -compat insecure-types Daniel P. Berrangé
2026-10-28 13:35 ` [PATCH 1/8] qapi: make 'CompatPolicy' the first arg in compat_policy_input_ok Daniel P. Berrangé
2026-10-28 13:35 ` [PATCH 2/8] qapi: add 'warn' option to CompatPolicyInput Daniel P. Berrangé
2026-10-29 6:56 ` Markus Armbruster [this message]
2026-10-29 10:48 ` Daniel P. Berrangé
2026-10-28 13:35 ` [PATCH 3/8] qapi: rename 'insecure-types' to 'insecure-input' Daniel P. Berrangé
2026-10-28 13:35 ` [PATCH 4/8] qapi: drop CompatPolicySecurity and use CompatPolicyInput Daniel P. Berrangé
2026-10-29 6:15 ` Markus Armbruster
2026-10-29 10:48 ` Daniel P. Berrangé
2026-10-28 13:36 ` [PATCH 5/8] qapi: rename compat_policy_check_security method Daniel P. Berrangé
2026-10-28 13:36 ` [PATCH 6/8] qapi: reverse arg order in compat_policy_security_ok Daniel P. Berrangé
2026-10-28 13:36 ` [PATCH 7/8] qemu-options: document -compat insecure-input parameter Daniel P. Berrangé
2026-10-29 6:52 ` Markus Armbruster
2026-10-29 10:56 ` Daniel P. Berrangé
2026-10-29 14:13 ` Markus Armbruster
2026-10-29 14:44 ` Daniel P. Berrangé
2026-10-28 13:36 ` [PATCH 8/8] qapi: print a message before aborting for -compat violations Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zevxf0zv.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.