Re: [PATCH 2/2] firmware: meson: sm: make power-off work on S4

From: kernel test robot <lkp@intel.com>
To: christian.koever-draxl@student.uibk.ac.at, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	neil.armstrong@linaro.org, khilman@baylibre.com,
	jbrunet@baylibre.com, martin.blumenstingl@googlemail.com
Cc: oe-kbuild-all@lists.linux.dev, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Christian Stefan Kövér-Draxl" <ckoever@outlook.de>
Subject: Re: [PATCH 2/2] firmware: meson: sm: make power-off work on S4
Date: Wed, 28 Oct 2026 18:53:45 +0800	[thread overview]
Message-ID: <202610281810.Or8lhrj7-lkp@intel.com> (raw)
In-Reply-To: <20261025192144.208954-3-christian.koever-draxl@student.uibk.ac.at>

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on 7be4bc52fd9e0e55dc9a2e0232b89427d2c4b614]

url:    https://github.com/intel-lab-lkp/linux/commits/christian-koever-draxl-student-uibk-ac-at/dt-bindings-firmware-amlogic-meson-gxbb-sm-add-amlogic-meson-s4-sm/20261025-202143
base:   7be4bc52fd9e0e55dc9a2e0232b89427d2c4b614
patch link:    https://lore.kernel.org/r/20261025192144.208954-3-christian.koever-draxl%40student.uibk.ac.at
patch subject: [PATCH 2/2] firmware: meson: sm: make power-off work on S4
config: arm64-randconfig-1000-20261028 (https://download.01.org/0day-ci/archive/20261028/202610281810.Or8lhrj7-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261028/202610281810.Or8lhrj7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610281810.Or8lhrj7-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/firmware/meson/meson_sm.c: In function 'meson_sm_power_off_prepare':
>> drivers/firmware/meson/meson_sm.c:318:6: error: implicit declaration of function 'freeze_secondary_cpus'; did you mean 'thaw_secondary_cpus'? [-Werror=implicit-function-declaration]
     if (freeze_secondary_cpus(0))
         ^~~~~~~~~~~~~~~~~~~~~
         thaw_secondary_cpus
   cc1: some warnings being treated as errors

vim +318 drivers/firmware/meson/meson_sm.c

   308	
   309	/*
   310	 * The S4 firmware implements PSCI SYSTEM_OFF as DDR self-refresh: on the
   311	 * power key it jumps back to the kernel instead of booting, which hangs the
   312	 * board. Setting the shutdown flag first makes it cold-boot instead, and the
   313	 * secondary CPUs must have been taken down through PSCI CPU_OFF beforehand,
   314	 * otherwise the wake-up path hangs as well.
   315	 */
   316	static int meson_sm_power_off_prepare(struct sys_off_data *data)
   317	{
 > 318		if (freeze_secondary_cpus(0))
   319			pr_warn("meson-sm: failed to stop secondary CPUs\n");
   320	
   321		return NOTIFY_DONE;
   322	}
   323	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki